💬 fanquake commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-2081780084)
Yea. I think we can merge our independant oss-fuzz bump, then merge this, then revert the oss-fuzz change if/when the global oss-fuzz bump happens. That has dragged on a bit too long, and is just blocking things here.

📝 fanquake opened a pull request: "depends: sqlite 3.45.3"
(https://github.com/bitcoin/bitcoin/pull/29991)
Update sqlite in depends from [3.38.5](https://sqlite.org/releaselog/3_38_5.html) to [3.45.3](https://sqlite.org/releaselog/3_45_3.html).

💬 maflcko commented on pull request "guix: build with glibc 2.31":
(https://github.com/bitcoin/bitcoin/pull/29987#issuecomment-2082038386)
It would be good to mention that this drops support for Ubuntu Bionic 18.04 and RHEL-8 (and forks) completely, going forward.

💬 fanquake commented on pull request "guix: build with glibc 2.31":
(https://github.com/bitcoin/bitcoin/pull/29987#issuecomment-2082041899)
That is shown in the changes in symbol-check, but I'll add it to the op, and can add a rel note.

💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2082089346)
Rebased for merge conflict and to apply fixup commits.

👍 maflcko approved a pull request: "fuzz: don't allow adding duplicate transactions to the mempool"
(https://github.com/bitcoin/bitcoin/pull/29990#pullrequestreview-2027780727)
lgtm ACK cc15c5bfd1eb3903de246c124702a7c66c687008

I guess this isn't due to a fuzz crash, because the only thing that's off is `cachedInnerUsage` (and friends), which are not checked in this fuzz target?

💬 laanwj commented on pull request "depends: Fix build of Qt for 32-bit platforms with recent glibc":
(https://github.com/bitcoin/bitcoin/pull/29985#issuecomment-2082091570)
Force-pushed to apply @hebasto's comment to make the patch apply cleanly.

💬 virtu commented on pull request "contrib: Add asmap-tool":
(https://github.com/bitcoin/bitcoin/pull/28793#issuecomment-2082138376)
ACK [6abe772](https://github.com/bitcoin/bitcoin/commit/6abe772a17e09fe96e68cd3311280d5a30f6378b)

Tested decoding and encoding some [demo ASMaps](https://github.com/fjahr/asmap-data).

Also made sure encoding yields a reproducible ordering by decoding, `shuf`'ling, and re-encoded an ASMap and making sure the resulting encoding was identical to the original one.

👋 Sjors's pull request is ready for review: "doc: add LLVM instruction for macOS < 13"
(https://github.com/bitcoin/bitcoin/pull/29934)

💬 Sjors commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2082144574)
I dropped the `@14` from the default instruction, but added a hint to try `@17` if that fails. That worked when I tested and I don't expect Homebrew formulas for older versions to change much moving forward, nor llvm 17 itself.

💬 Sjors commented on pull request "build: Bump clang minimum supported version to 15":
(https://github.com/bitcoin/bitcoin/pull/29165#issuecomment-2082152250)
@maflcko the updated wording in #29934 is such this PR won't conflict with it.

💬 maflcko commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2082159132)
utACK 22574046c90c0662f3aa9b1baea074aff54f92a9

💬 Sjors commented on issue "Add IPv6 pinhole support using UPnP / NAT-PMP":
(https://github.com/bitcoin/bitcoin/issues/17012#issuecomment-2082162255)
> The good part is that it's just a matter of sending one fixed-size binary UDP packet to the default gateway and parsing the result.

Nice!

💬 laanwj commented on issue "Add IPv6 pinhole support using UPnP / NAT-PMP":
(https://github.com/bitcoin/bitcoin/issues/17012#issuecomment-2082215034)
> Nice!

If you'd like to test, i have a branch here: https://github.com/laanwj/bitcoin/tree/2024-04-pcp-pinhole
It is a PoC that replaces [bitcoind.cpp](https://github.com/laanwj/bitcoin/blob/2024-04-pcp-pinhole/src/bitcoind.cpp) with a program that (on Linux only for now):

- Enumerates local publicly routable IPv6 addresses
- Gets the default gateway to get the PCP endpoint
- Requests pinholes for 100 seconds to port 1234 on all addreses, and prints the result

i've tried it on two r
...

💬 0xB10C commented on pull request "tracing: cast block_connected duration to µs":
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2082221803)
> Any reason not to just stick to nanoseconds and harden it against future accidents?

I think updating the documentation and using `Ticks<std::chrono::nanoseconds>` would work just as well, yes..

💬 sdaftuar commented on pull request "fuzz: don't allow adding duplicate transactions to the mempool":
(https://github.com/bitcoin/bitcoin/pull/29990#issuecomment-2082230525)
> I guess this isn't due to a fuzz crash, because the only thing that's off is `cachedInnerUsage` (and friends), which are not checked in this fuzz target?

Correct, I didn't see any fuzz crash on master, but this issue was leading to crashes in my cluster mempool branch, where the inconsistency manifested itself sooner.

📝 luchenhan opened a pull request: "chore: fix some typos"
(https://github.com/bitcoin/bitcoin/pull/29992)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "chore: fix some typos"
(https://github.com/bitcoin/bitcoin/pull/29992)

💬 fanquake commented on pull request "chore: fix some typos":
(https://github.com/bitcoin/bitcoin/pull/29992#issuecomment-2082247128)
Please send changes to the minisketch subtree to the upstream repository. See the notes on subtrees in the [developer-notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees).

The change to the Boost macro is also in upstream code.

👍 hebasto approved a pull request: "depends: Fix build of Qt for 32-bit platforms with recent glibc"
(https://github.com/bitcoin/bitcoin/pull/29985#pullrequestreview-2027951391)
re-ACK 2e266f33b5d2be5c233c2c692481f75785714fa1.