💬 achow101 commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#issuecomment-2079935291)
ACK e1be443315be6ba6c80267e0e6be59deee77de50

📝 sr-gi opened a pull request: "fuzz: txorphan tests fixups"
(https://github.com/bitcoin/bitcoin/pull/29974)
Motivated by https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1576401327

Adds the following fixups in txorphan fuzz tests:

- Don't bond the output count of the created orphans based on the number of available coins
- Allow duplicate inputs, when applicable, but don't store duplicate outpoints

## Rationale

The way the test is currently written, duplicate inputs are allowed based on a random flag (`duplicate_input`). If the flag is unset, upon selecting an outpoint as input f
...

💬 achow101 commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1581409638)
Can you briefly explain why these `operator=` are made private as opposed to deleting them?

💬 sr-gi commented on pull request "cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-2080011427)
What is the state of this @stratospher? Are you still looking for feedback on https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1548215577?

💬 instagibbs commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1581471581)
to make the link locally explicit?
```Suggestion
while (!selected_outpoints.empty()) {
assert(!duplicate_input);
```

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1581476471)
Good point

💬 achow101 commented on pull request "test: Run framework unit tests in parallel":
(https://github.com/bitcoin/bitcoin/pull/29771#issuecomment-2080042323)
ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d

🚀 achow101 merged a pull request: "test: Run framework unit tests in parallel"
(https://github.com/bitcoin/bitcoin/pull/29771)

💬 sipsorcery commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080056823)
tACK 09f5a74198c328c80539c17d951a70558e6b361e.

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080063019)
@sipsorcery
> tACK [09f5a74](https://github.com/bitcoin/bitcoin/commit/09f5a74198c328c80539c17d951a70558e6b361e).

Wrong commit hash?

:)

💬 sipsorcery commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080067678)
> @sipsorcery
>
> > tACK [09f5a74](https://github.com/bitcoin/bitcoin/commit/09f5a74198c328c80539c17d951a70558e6b361e).
>
> Wrong commit hash?
>
> :)

Every time :( I wish there were timestamps on the Github list. If only my old brain could remember to use git log next time.

tACK #18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd

🤔 sipa reviewed a pull request: "build: Enable fuzz binary in MSVC"
(https://github.com/bitcoin/bitcoin/pull/29774#pullrequestreview-2025809867)
utACK 18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd

📝 mzumsande opened a pull request: "blockstorage: Separate reindexing from saving new blocks"
(https://github.com/bitcoin/bitcoin/pull/29975)
`SaveBlockToDisk` / `FindBlockPos` are used for two purposes, depending on whether they are called during reindexing (`dbp` set,  `fKnown = true`) or in the "normal" case when adding new blocks (`dbp == nullptr`,  `fKnown = false`).
The actual tasks are quite different
- In normal mode, preparations for saving a new block are made, which is then saved: find the correct position on disk (maybe skipping to a new blk file), check for available disk space, update the blockfile info db, save the bl
...

💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2080165498)
Okay, i implemented a script to download the upstream tarballs and extract the headers from there\*..

So everything except what is in `scripts` is generated--this makes it traightforward to change the required interface versions in [collector.py](https://github.com/laanwj/qtsowrap/blob/main/scripts/collector.py) by pointing it to a different tarball and re-running the process, and committing the changes to git.

The entire process is deterministic so can also be used to verify that the hea
...

📝 hebasto opened a pull request: "build, msvc: Drop duplicated `common\url.cpp` source file"
(https://github.com/bitcoin/bitcoin/pull/29976)
After https://github.com/bitcoin/bitcoin/pull/29904, the `common\url.cpp` source file is included into the `SOURCE_FILES` by the `msvc-autogen.py` script.

Removes a compiler [warning](https://github.com/bitcoin/bitcoin/actions/runs/8853698173/job/24315127236#step:20:1776):
```
url.obj : warning LNK4006: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl UrlDecode(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UrlDecode@@YA
...

💬 TheCharlatan commented on pull request "blockstorage: Separate reindexing from saving new blocks":
(https://github.com/bitcoin/bitcoin/pull/29975#issuecomment-2080168836)
Concept ACK

💬 laanwj commented on pull request "test: switch from curl to requests for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#issuecomment-2080191475)
Yes, that's usually how it'd be done.

But gah, `requests` is an external dependency? That's unfortunate, i don't think we should be adding dependencies unless absolutely necessary. Probably better to do this with python's built in urllib or http client functionality, or keep it like this.

🤔 ryanofsky reviewed a pull request: "Disable util::Result copying and assignment"
(https://github.com/bitcoin/bitcoin/pull/29906#pullrequestreview-2025935950)
Updated e1be443315be6ba6c80267e0e6be59deee77de50 -> 9552619961049d7673f84c40917b0385be70b782 ([`pr/saferesult.7`](https://github.com/ryanofsky/bitcoin/commits/pr/saferesult.7) -> [`pr/saferesult.8`](https://github.com/ryanofsky/bitcoin/commits/pr/saferesult.8), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/saferesult.7..pr/saferesult.8)) with small suggested cleanups

💬 ryanofsky commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1581579143)
re: https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1580997920

> nit: unnecessary extra newline

Thanks, removed

💬 ryanofsky commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1581580768)
re: https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1581039091

> nit: Is this line needed?

Nope, dropped this