💬 instagibbs commented on pull request "Cluster size 2 package rbf":
(https://github.com/bitcoin/bitcoin/pull/28984#issuecomment-2079739934)
all feedback should be addressed now

💬 vasild commented on issue "Require thread_local":
(https://github.com/bitcoin/bitcoin/issues/29952#issuecomment-2079776241)
https://github.com/bitcoin/bitcoin/blob/7973a670915632b75a6aa16f24f98b936865c48f/configure.ac#L1054-L1057

The file https://github.com/freebsd/freebsd-src/blob/master/lib/libc/stdlib/cxa_thread_atexit_impl.c has not been changed since 2017.

Running the unit tests on FreeBSD with thread_local enabled (had to edit `configure.ac`) prints a bunch of those:
```
__cxa_thread_call_dtors: dtr 0x375164b2d70 from unloaded dso, skipping
```
which is at least annoying and scary.

We only use `thr
...

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1581333124)
That was not on purpose, I just missed the second half of you suggestion. Changed it now, slightly stricter checks can only be helpful.

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#discussion_r1581333328)
done as suggested.

💬 mzumsande commented on pull request "validation: improve performance of CheckBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/28339#issuecomment-2079810727)
[3c3895c ](https://github.com/bitcoin/bitcoin/commit/3c3895ccfa108e10f4a0b1a78f64ffedade1fd11)to [5bc2077](https://github.com/bitcoin/bitcoin/commit/5bc2077e8f592442b089affdf0b5795fbc053bb8):
Addressed review feedback

💬 iw4p commented on pull request "test: switch from curl to requests for HTTP requests":
(https://github.com/bitcoin/bitcoin/pull/29970#issuecomment-2079822326)
@laanwj I investigated and found that you modified `import requests` here [here](https://github.com/bitcoin/bitcoin/pull/23162). Is there any shell script that I can provide `pip install requests` to pass the `previous release, depends DEBUG`?

💬 achow101 commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#issuecomment-2079935291)
ACK e1be443315be6ba6c80267e0e6be59deee77de50

📝 sr-gi opened a pull request: "fuzz: txorphan tests fixups"
(https://github.com/bitcoin/bitcoin/pull/29974)
Motivated by https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1576401327

Adds the following fixups in txorphan fuzz tests:

- Don't bond the output count of the created orphans based on the number of available coins
- Allow duplicate inputs, when applicable, but don't store duplicate outpoints

## Rationale

The way the test is currently written, duplicate inputs are allowed based on a random flag (`duplicate_input`). If the flag is unset, upon selecting an outpoint as input f
...

💬 achow101 commented on pull request "Disable util::Result copying and assignment":
(https://github.com/bitcoin/bitcoin/pull/29906#discussion_r1581409638)
Can you briefly explain why these `operator=` are made private as opposed to deleting them?

💬 sr-gi commented on pull request "cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-2080011427)
What is the state of this @stratospher? Are you still looking for feedback on https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1548215577?

💬 instagibbs commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1581471581)
to make the link locally explicit?
```Suggestion
while (!selected_outpoints.empty()) {
assert(!duplicate_input);
```

💬 sr-gi commented on pull request "fuzz: txorphan tests fixups":
(https://github.com/bitcoin/bitcoin/pull/29974#discussion_r1581476471)
Good point

💬 achow101 commented on pull request "test: Run framework unit tests in parallel":
(https://github.com/bitcoin/bitcoin/pull/29771#issuecomment-2080042323)
ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d

🚀 achow101 merged a pull request: "test: Run framework unit tests in parallel"
(https://github.com/bitcoin/bitcoin/pull/29771)

💬 sipsorcery commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080056823)
tACK 09f5a74198c328c80539c17d951a70558e6b361e.

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080063019)
@sipsorcery
> tACK [09f5a74](https://github.com/bitcoin/bitcoin/commit/09f5a74198c328c80539c17d951a70558e6b361e).

Wrong commit hash?

:)

💬 sipsorcery commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2080067678)
> @sipsorcery
>
> > tACK [09f5a74](https://github.com/bitcoin/bitcoin/commit/09f5a74198c328c80539c17d951a70558e6b361e).
>
> Wrong commit hash?
>
> :)

Every time :( I wish there were timestamps on the Github list. If only my old brain could remember to use git log next time.

tACK #18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd

🤔 sipa reviewed a pull request: "build: Enable fuzz binary in MSVC"
(https://github.com/bitcoin/bitcoin/pull/29774#pullrequestreview-2025809867)
utACK 18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd

📝 mzumsande opened a pull request: "blockstorage: Separate reindexing from saving new blocks"
(https://github.com/bitcoin/bitcoin/pull/29975)
`SaveBlockToDisk` / `FindBlockPos` are used for two purposes, depending on whether they are called during reindexing (`dbp` set,  `fKnown = true`) or in the "normal" case when adding new blocks (`dbp == nullptr`,  `fKnown = false`).
The actual tasks are quite different
- In normal mode, preparations for saving a new block are made, which is then saved: find the correct position on disk (maybe skipping to a new blk file), check for available disk space, update the blockfile info db, save the bl
...

💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2080165498)
Okay, i implemented a script to download the upstream tarballs and extract the headers from there\*..

So everything except what is in `scripts` is generated--this makes it traightforward to change the required interface versions in [collector.py](https://github.com/laanwj/qtsowrap/blob/main/scripts/collector.py) by pointing it to a different tarball and re-running the process, and committing the changes to git.

The entire process is deterministic so can also be used to verify that the hea
...