⚠️ mouhand-a opened an issue: "### Summary"
(https://github.com/bitcoin/bitcoin/issues/29956)
### Summary
Currently, projects can only support 1200 active items and 10,000 archived items but we've heard from many larger teams that these limits are too low for the work they need to track such as long-running backlogs. While we can't completely remove the limit for projects, we will raise the limit to approximately 50k active items to better support this scenario.
### Intended Outcome
For long running projects or all-encompassing backlogs for companies, the current limit for proje
...
(https://github.com/bitcoin/bitcoin/issues/29956)
### Summary
Currently, projects can only support 1200 active items and 10,000 archived items but we've heard from many larger teams that these limits are too low for the work they need to track such as long-running backlogs. While we can't completely remove the limit for projects, we will raise the limit to approximately 50k active items to better support this scenario.
### Intended Outcome
For long running projects or all-encompassing backlogs for companies, the current limit for proje
...
⚠️ mouhand-a opened an issue: "Because"
(https://github.com/bitcoin/bitcoin/issues/29957)
_Originally posted by @mouhand-a in https://github.com/bitcoin/bitcoin/issues/29950_
(https://github.com/bitcoin/bitcoin/issues/29957)
_Originally posted by @mouhand-a in https://github.com/bitcoin/bitcoin/issues/29950_
✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)
(https://github.com/bitcoin/bitcoin/issues/29955)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)
(https://github.com/bitcoin/bitcoin/issues/29955)
✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)
(https://github.com/bitcoin/bitcoin/issues/29956)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)
(https://github.com/bitcoin/bitcoin/issues/29956)
✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)
(https://github.com/bitcoin/bitcoin/issues/29957)
:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)
(https://github.com/bitcoin/bitcoin/issues/29957)
✅ MarnixCroes closed a pull request: "guiconstants: update ORG_DOMAIN to bitcoincore.org"
(https://github.com/bitcoin-core/gui/pull/818)
(https://github.com/bitcoin-core/gui/pull/818)
💬 MarnixCroes commented on pull request "guiconstants: update ORG_DOMAIN to bitcoincore.org":
(https://github.com/bitcoin-core/gui/pull/818#issuecomment-2076070570)
ok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated.
nvm
(https://github.com/bitcoin-core/gui/pull/818#issuecomment-2076070570)
ok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated.
nvm
🤔 tdb3 reviewed a pull request: "test: Validate oversized transactions or without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862#pullrequestreview-2021206191)
re-ACK for e2e8b21240da8d567a37d35ae29a6100fde65d2b
(https://github.com/bitcoin/bitcoin/pull/29862#pullrequestreview-2021206191)
re-ACK for e2e8b21240da8d567a37d35ae29a6100fde65d2b
💬 tdb3 commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682730)
Re-ran this sanity check on e2e8b21240da8d567a37d35ae29a6100fde65d2b
Unit test failed as expected.
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682730)
Re-ran this sanity check on e2e8b21240da8d567a37d35ae29a6100fde65d2b
Unit test failed as expected.
💬 tdb3 commented on pull request "test: Validate oversized transactions or without inputs":
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682415)
To check see that the test would fail without "bad-txns-oversize", modified `tx_oversized` case temporarily with the following:
```c++
auto largeOutput = CScript() << OP_RETURN << std::vector<unsigned char>(60, 0x00);
```
Unit test failed (as expected).
(https://github.com/bitcoin/bitcoin/pull/29862#discussion_r1578682415)
To check see that the test would fail without "bad-txns-oversize", modified `tx_oversized` case temporarily with the following:
```c++
auto largeOutput = CScript() << OP_RETURN << std::vector<unsigned char>(60, 0x00);
```
Unit test failed (as expected).
🤔 tdb3 reviewed a pull request: "rpc: return warnings as an array instead of just a single one"
(https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-2021354156)
Approach ACK.
Re-ran the sanity checks in https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-1999801519
All were successful.
Tried testing out the `-deprecatedrpc=warnings` functionality. I'm guessing I'm missing something simple/trivial (or improperly using `-deprecatedrpc`). When running `src/bitcoind -deprecatedrpc=warnings`, both curl and bitcoin-cli returned an error:
curl:
```
$ curl --user __cookie__ --data-binary '{"id": "curltest", "method": "getblockchaininfo
...
(https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-2021354156)
Approach ACK.
Re-ran the sanity checks in https://github.com/bitcoin/bitcoin/pull/29845#pullrequestreview-1999801519
All were successful.
Tried testing out the `-deprecatedrpc=warnings` functionality. I'm guessing I'm missing something simple/trivial (or improperly using `-deprecatedrpc`). When running `src/bitcoind -deprecatedrpc=warnings`, both curl and bitcoin-cli returned an error:
curl:
```
$ curl --user __cookie__ --data-binary '{"id": "curltest", "method": "getblockchaininfo
...
💬 fanquake commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578771999)
Another MSVC bug for us to report upstream I guess. @hebasto.
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578771999)
Another MSVC bug for us to report upstream I guess. @hebasto.
💬 KonradStaniec commented on issue "Calling `walletprocesspsbt` to sign multisig containing `OP_GREATERTHANOREQUAL` op_code":
(https://github.com/bitcoin/bitcoin/issues/29949#issuecomment-2076276040)
Thanks for the quick responses! I think this issue can be closed then.
Two follow up questions, I would have:
1. Is there some other way to sign transaction, through bitcoind, which tries to spend from script which is not compatible with miniscript ?
2. Is the some problem with `OP_GREATERTHANOREQUAL` which makes it non compatible with Miniscript ?
(https://github.com/bitcoin/bitcoin/issues/29949#issuecomment-2076276040)
Thanks for the quick responses! I think this issue can be closed then.
Two follow up questions, I would have:
1. Is there some other way to sign transaction, through bitcoind, which tries to spend from script which is not compatible with miniscript ?
2. Is the some problem with `OP_GREATERTHANOREQUAL` which makes it non compatible with Miniscript ?
💬 maflcko commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578868096)
No, it is not a msvc bug. from_chars actually accepts a raw pointer, not an iterator, so my draft diff was wrong (type-wise)
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578868096)
No, it is not a msvc bug. from_chars actually accepts a raw pointer, not an iterator, so my draft diff was wrong (type-wise)
💬 maflcko commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578875254)
As the function body is new code, I'd say the `url_encoded` can be done correctly when the code is added, but no big deal
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578875254)
As the function body is new code, I'd say the `url_encoded` can be done correctly when the code is added, but no big deal
💬 maflcko commented on pull request "lint: scripted-diff verification also requires GNU grep":
(https://github.com/bitcoin/bitcoin/pull/29689#issuecomment-2076396476)
utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
(https://github.com/bitcoin/bitcoin/pull/29689#issuecomment-2076396476)
utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
📝 laanwj opened a pull request: "[PoC] qt, depends: Add wayland support without build-time nor fixed run-time deps"
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...
(https://github.com/bitcoin/bitcoin/pull/29959)
Built on PR #29923.
Loosely based on PR #22708.
This is a proof-of-concept of using the same methodology as in #29923 to support both Wayland and X11 windowing backends, for the Linux release binary, without any extra build-time nor fixed run-time dependencies. It results in a `bitcoin-qt` binary that "just works" on systems that have only one of them installed, or both.
Everything (including libEGL) is loaded dynamically at run time if needed.
```
$ readelf -a src/qt/bitcoin-qt |grep
...