💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578496251)
The snake case is already applied in the scripted diff but I applied the clang format suggestions

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578496354)
neat, I applied this change

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578496508)
Changed and added a test for this case as well

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2075804791)
> `unsigned` may be better

No idea what this means ;) but I addressed the feedback, thanks a lot!

👍 kristapsk approved a pull request: "doc: Bash is needed in gen_id and is not installed on FreeBSD by default"
(https://github.com/bitcoin/bitcoin/pull/29953#pullrequestreview-2020936557)
ACK 9381052194a78024b3994cc6ad906858c477b88f

💬 TheCharlatan commented on pull request "kernel: De-globalize fReindex":
(https://github.com/bitcoin/bitcoin/pull/29817#discussion_r1578521404)
Good catch! To be clear from my comments before, it is not that big of an issue if the indexes are wiped again. AFAICT the operations executed while the `reindexing` atomic is true do not issue any validation signals, so they don't have an effect on the indexes. However recreating them is redundant and I don't think it is particularly useful. I think it would also be good to make the behavior between the coins and the other indexes consistent, so I'll take your suggestion here.

💬 brunoerg commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1578530492)
Done.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1578533717)
Ugh, looks like MSVC has a problem with this, I am reverting it for now (see https://github.com/bitcoin/bitcoin/actions/runs/8823024109/job/24222527982?pr=29904)

👍 alfonsoromanz approved a pull request: "lint: scripted-diff verification also requires GNU grep"
(https://github.com/bitcoin/bitcoin/pull/29689#pullrequestreview-2021071819)
Tested ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b

I was using incompatible versions for both sed and grep, so I was able to verify both error messages. After installing the GNU versions I don't get any of the error messages.

⚠️ mouhand-a opened an issue: "Use custom elements on TestPanelContainerItemElement"
(https://github.com/bitcoin/bitcoin/issues/29955)
Use custom elements on TestPanelContainerItemElement

_Originally posted by @sadick254 in https://github.com/atom/atom/pull/22769_

💬 mouhand-a commented on issue "Use custom elements on TestPanelContainerItemElement":
(https://github.com/bitcoin/bitcoin/issues/29955#issuecomment-2076010481)
[‎⁨تصدير سِجِل الطلب-2024-04-20 09_25_30⁩ 2.xlsx](https://github.com/bitcoin/bitcoin/files/15101794/-2024-04-20.09_25_30.2.xlsx)
@
```c++
```

⚠️ mouhand-a opened an issue: "### Summary"
(https://github.com/bitcoin/bitcoin/issues/29956)
### Summary

Currently, projects can only support 1200 active items and 10,000 archived items but we've heard from many larger teams that these limits are too low for the work they need to track such as long-running backlogs. While we can't completely remove the limit for projects, we will raise the limit to approximately 50k active items to better support this scenario.

### Intended Outcome

For long running projects or all-encompassing backlogs for companies, the current limit for proje
...

⚠️ mouhand-a opened an issue: "Because"
(https://github.com/bitcoin/bitcoin/issues/29957)
_Originally posted by @mouhand-a in https://github.com/bitcoin/bitcoin/issues/29950_

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29955)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29956)

✅ achow101 closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)

:lock: achow101 locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29957)

✅ MarnixCroes closed a pull request: "guiconstants: update ORG_DOMAIN to bitcoincore.org"
(https://github.com/bitcoin-core/gui/pull/818)