💬 hebasto commented on pull request "ci: Workaround Microsoft mirror issue for GitHub Action":
(https://github.com/bitcoin/bitcoin/pull/29951#issuecomment-2074782310)
> So not sure we need to commit something just to semi-immediately revert it.

A revert commit won't be actually required. This change improves robustness of the CI script.

💬 vasild commented on pull request "doc: Suggest only necessary Qt packages for installation on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/29947#issuecomment-2074791093)
Concept ACK

I have no (easy) way to verify that exactly those packages suffice, thus not full ACK.

👍 theStack approved a pull request: "doc: Suggest only necessary Qt packages for installation on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/29947#pullrequestreview-2019682576)
re-ACK 970cbc3172b73e1faf6bdb429400d3497cbb9d33

💬 vasild commented on pull request "doc: suggest only necessary Qt packages for installation on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/29932#issuecomment-2074800945)
`f4362367d7...d457d8b20a`:

> Please update to the corresponding version of the OS in line 3 of the file

Done, even though in FreeBSD the packaging system is agnostic to the OS version (mostly).

💬 maflcko commented on pull request "doc: Fix gen-manpages to check build options":
(https://github.com/bitcoin/bitcoin/pull/29457#discussion_r1577779114)
> changes here can wait until after CMake, as this script will likely need to be (partially) rewritten after that change in any case.

Can you explain this? config ini should be unrelated to the build system and shouldn't be affected by it.

👍 hebasto approved a pull request: "doc: suggest only necessary Qt packages for installation on FreeBSD"
(https://github.com/bitcoin/bitcoin/pull/29932#pullrequestreview-2019686831)
ACK d457d8b20aa2fd09df319bd087ad0a69925be158.

💬 vasild commented on pull request "doc: suggest only necessary Qt packages for installation on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/29932#issuecomment-2074812682)
`d457d8b20a...dace02f99d`: update the commit message with the numbers from the latest run, sorry for the noise. I think this should be settled now.

💬 fanquake commented on pull request "doc: Fix gen-manpages to check build options":
(https://github.com/bitcoin/bitcoin/pull/29457#discussion_r1577785469)
This is hardcoding component names / variables, and they are likely to change during the switchover.

👍 hebasto approved a pull request: "doc: suggest only necessary Qt packages for installation on FreeBSD"
(https://github.com/bitcoin/bitcoin/pull/29932#pullrequestreview-2019705702)
re-ACK dace02f99d4a8785567732c0d687517175765bfd.

I've got the following diff for the change since my recent [review](https://github.com/bitcoin/bitcoin/pull/29932#pullrequestreview-2019686831):
```
$ git range-diff master d457d8b20aa2fd09df319bd087ad0a69925be158 dace02f99d4a8785567732c0d687517175765bfd
1: d457d8b20a ! 1: dace02f99d doc: suggest only necessary Qt packages for installation on FreeBSD
@@ Commit message

The previously suggested `qt5` package is a meta p
...

👍 BrandonOdiwuor approved a pull request: "Bugfix - don't allow multiple dialogs for same tx in TransactionView"
(https://github.com/bitcoin-core/gui/pull/817#pullrequestreview-2019747892)
Tested ACK b26d2e81ec6ac4b5bd97bc7f7ec0c44e502b6a18

Tested successfully on Ubuntu 22.04.4 LTS. Only one dialogue is created per transaction and the clicked transaction is brought to the foreground

[Screencast from 24-04-2024 03:35:10 ALASIRI.webm](https://github.com/bitcoin-core/gui/assets/15610188/396507fc-bb8c-4773-8e74-68ac51c6b582)

🚀 fanquake merged a pull request: "rpc: Reword SighashFromStr error message"
(https://github.com/bitcoin/bitcoin/pull/29870)

💬 fanquake commented on pull request "rpc: Reword SighashFromStr error message":
(https://github.com/bitcoin/bitcoin/pull/29870#issuecomment-2074891924)
Backported in #29888.

🚀 fanquake merged a pull request: "doc: Suggest only necessary Qt packages for installation on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/29947)

🚀 fanquake merged a pull request: "doc: suggest only necessary Qt packages for installation on FreeBSD"
(https://github.com/bitcoin/bitcoin/pull/29932)

✅ fanquake closed an issue: "fuzz, rpc: Internal bug in `finalizepsbt` "CHECK_NONFATAL(last - first == 32)" "
(https://github.com/bitcoin/bitcoin/issues/29851)

🚀 fanquake merged a pull request: "sign: don't assume we are parsing a sane TapMiniscript"
(https://github.com/bitcoin/bitcoin/pull/29853)

✅ hebasto closed a pull request: "ci: Workaround Microsoft mirror issue for GitHub Action"
(https://github.com/bitcoin/bitcoin/pull/29951)

💬 hebasto commented on pull request "ci: Workaround Microsoft mirror issue for GitHub Action":
(https://github.com/bitcoin/bitcoin/pull/29951#issuecomment-2074923286)
https://github.com/microsoft/linux-package-repositories/issues/130

Closing.

💬 fanquake commented on pull request "sign: don't assume we are parsing a sane TapMiniscript":
(https://github.com/bitcoin/bitcoin/pull/29853#issuecomment-2074931006)
Backported to 27.x in #29888.

⚠️ maflcko opened an issue: "Require thread_local"
(https://github.com/bitcoin/bitcoin/issues/29952)
After dbfca4a815d2dbef69f3b634c24b875bc1d22afc from the 23.x release (and fe1b3256888bd0e70d0c9655f565e139ec87b606 from 25.x), I think the `--disable-threadlocal` can now be dropped, as those commits removed the need for it?

cc @hebasto @fanquake