💬 hernanmarino commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2073294649)
Updated to remove a (no lonnger valid) TODO comment as requested in https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-1952480346. Also updated the PR title and description.

💬 achow101 commented on pull request "rpc: return warnings as an array instead of just a single one":
(https://github.com/bitcoin/bitcoin/pull/29845#issuecomment-2073294918)
ACK 7b64820da65d9b75b181693223a6aeb9c50b4613

🤔 ajtowns reviewed a pull request: "script: throw disabled err for op_ver and its variants"
(https://github.com/bitcoin/bitcoin/pull/28169#pullrequestreview-2018182424)
I'm still ~0 on whether this actually improves anything, but I don't believe it causes any potential problems.

💬 achow101 commented on pull request "test: remove duplicated ban test":
(https://github.com/bitcoin/bitcoin/pull/29688#issuecomment-2073339535)
ACK e30e8625bbc42045b8b757a8d7e80c20cc61cebf

🚀 achow101 merged a pull request: "test: remove duplicated ban test"
(https://github.com/bitcoin/bitcoin/pull/29688)

⚠️ HaSan1y opened an issue: "help i think my core is hacked"
(https://github.com/bitcoin/bitcoin/issues/29944)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

https://explorer.btc.com/btc/transaction/c5069dd52612dd07cfff6a2c587356497a2f8e7489923376a92420850fe27d09

i only did an 0.01 transfer to freebitco.in but somehow it puts an additional 0.027 btc transfer to an unintend address in there how can i cancel it pls help fast

### Expected behaviour

https://explorer.btc.com/btc/transaction/c5069dd52612dd07cfff6a2c587356497a2f8e7489923376a92420
...

🤔 furszy reviewed a pull request: "sign: don't assume we are parsing a sane TapMiniscript"
(https://github.com/bitcoin/bitcoin/pull/29853#pullrequestreview-2018286165)
ACK 4d8d21320eba54571ff63931509cd515c3e20339 with a small nuance that could be tackled in a follow-up by someone else (or never).

As this was found by the RPC fuzzer, it would be nice to re-use those inputs and craft a functional test, rather than covering it on a unit test. This is because functional tests can be ported across releases with the bug fix, while unit tests might not be easy to port due to some internal changes. Plus, in the long term, unit tests require more maintenance work.

💬 achow101 commented on pull request "Improve display address handling for external signer":
(https://github.com/bitcoin/bitcoin/pull/24313#issuecomment-2073454165)
ACK 4357158c4712d479522d5cd441ad4dd1693fdd05

🚀 achow101 merged a pull request: "Improve display address handling for external signer"
(https://github.com/bitcoin/bitcoin/pull/24313)

💬 vostrnad commented on pull request "Remove redundant `-datacarrier` option":
(https://github.com/bitcoin/bitcoin/pull/29942#issuecomment-2073575320)
Another difference from `-chain` is that it is possible to set both `-datacarrier=0` and a positive `-datacarriersize` without so much as a warning (`-chain` immediately crashes when in conflict with another option).

Here are also a few examples of users confused about the two options:

https://twitter.com/FieldNas/status/1782498776671768807
https://twitter.com/betoche1984/status/1782452190063337681

📝 luke-jr opened a pull request: "Bugfix: JSON-RPC request Content-Type is application/json"
(https://github.com/bitcoin/bitcoin/pull/29946)
This goes all the way back to #3246, and it's not clear why text/plain has been used throughout.

There seems to be a lack of specification of what the correct content-type is, but application/json seems correct and popular, and text/plain definitely isn't.

📝 hebasto opened a pull request: "doc: Suggest only necessary Qt packages for installation on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/29947)
The currently suggested `qt5` installs many unneeded dependencies, for example, `qtsensors`, `qtspeech` etc.

Similar to https://github.com/bitcoin/bitcoin/pull/29932.

💬 hebasto commented on pull request "doc: Suggest only necessary Qt packages for installation on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/29947#issuecomment-2073613812)
cc @theStack

👍 theStack approved a pull request: "doc: Suggest only necessary Qt packages for installation on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/29947#pullrequestreview-2018507569)
Tested ACK b175ca9cc8bad4e106149260c3b592b1e0f2cb2f

Verified on a fresh install of OpenBSD 7.5 that these two packages are the minimum requirement to build the GUI:

* Without `qtbase`, the configure script invoked via `./configure --with-gui=qt5 MAKE=gmake` fails with `configure: error: Qt5Core >= 5.11.3 not found`.
* Without `qttools`, the configure script fails with `configure: error: LRELEASE not found`.
* With both installed, the configure passes and the build succeeds.

💬 pinheadmz commented on issue "help i think my core is hacked":
(https://github.com/bitcoin/bitcoin/issues/29944#issuecomment-2073702422)
This is your change output. Look for more information on https://bitcoin.stackexchange.com

✅ pinheadmz closed an issue: "help i think my core is hacked"
(https://github.com/bitcoin/bitcoin/issues/29944)

💬 laanwj commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1577057922)
Even this can go? It's fascinating to see how this little function was such a wedge issue and now we can drop half the build system 😄

👍 laanwj approved a pull request: "refactor: Use our own implementation of urlDecode"
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2018558155)
Code review ACK 477c03b42825084ac344050d97ea206a82ba0eb6

💬 luke-jr commented on pull request "Add used balance to overview page":
(https://github.com/bitcoin-core/gui/pull/775#issuecomment-2073729945)
What is the use case here? (And the avoid_reuse flag in general...)

💬 laanwj commented on pull request "doc: Suggest only necessary Qt packages for installation on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/29947#issuecomment-2073755514)
Concept ACK. It's nice that OpenBSD provides separate modules for Qt nowadays.