💬 hebasto commented on pull request "Reintroduce external signer support for Windows":
(https://github.com/bitcoin/bitcoin/pull/29868#issuecomment-2073002343)
Rebased.

🤔 mzumsande reviewed a pull request: "net: update comment for service bit support info for seed.bitcoin.sipa.be"
(https://github.com/bitcoin/bitcoin/pull/29809#pullrequestreview-2017881075)
I also think it would be good to get this out of chainparams, bitcoind only ever uses "x9" anyway as far as I can see, so I'm not sure why the status of other combinations needs to be tracked here.
Maybe adding the info in the first place was meant as a service to other software that would actually use those other combinations?

💬 theStack commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2073028810)
Concept ACK

👍 stickies-v approved a pull request: "refactor: Use our own implementation of urlDecode"
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2017977113)
ACK 477c03b42825084ac344050d97ea206a82ba0eb6

Apologies for my UB string_view code suggestion, I didn't realize `operator[pos]` behaves differently for string_view vs string when `pos==size()`. What you pushed looks like an elegant fix while keeping the copying minimal, nice.

💬 kosuodhmwa commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2073172477)
Now i've set it up without that "txindex" parameter = enabled... still the same issue...


💬 kosuodhmwa commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2073175791)

-> Screenshot #2 is the VirtualBox Host System location for the virtual drive that shows the space problem in VM

💬 kosuodhmwa commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2073179924)
So a ~1TB disk is not enough for the .bitcoin data directory wtf!?

💬 Sjors commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#issuecomment-2073191753)
I spun up a VM with macOS 11 Big Sur and installed the command line tools (I had to download them from Apple, because `xcode-select --install` got stuck, but that might be a VirtualBox issue).

I then installed Homebrew and did `brew install llvm`, which should install llvm 18. The openssl@3 install failed due to one broken test.

I'll continue to test, but the VM is excruciatingly slow...

Will update to drop the `@14` if that works.

💬 kosuodhmwa commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2073247868)
-> I also use Tor since yesterday. Before i was running it without tor for a few days (sync blockchain etc). After set up and configure tor, i runt into that problem.

Maybe it's a issue with tor and, e.g., log files!?

💬 achow101 commented on pull request "doc: explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/28974#issuecomment-2073279258)
ACK 55b13ecd2e00ad2dbfd44c34d7de6f616590adf8

✅ achow101 closed an issue: "doc: Explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/issues/18085)

🚀 achow101 merged a pull request: "doc: explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/pull/28974)

💬 achow101 commented on pull request "script: throw disabled err for op_ver and its variants":
(https://github.com/bitcoin/bitcoin/pull/28169#issuecomment-2073287948)
ACK 2d6530b4c5300a29d87fb7042c6cec0b08cc9a0f

💬 achow101 commented on pull request "sign: don't assume we are parsing a sane TapMiniscript":
(https://github.com/bitcoin/bitcoin/pull/29853#issuecomment-2073289512)
ACK 4d8d21320eba54571ff63931509cd515c3e20339

💬 hernanmarino commented on pull request "test: Assumeutxo: snapshots with less work should not be loaded":
(https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-2073294649)
Updated to remove a (no lonnger valid) TODO comment as requested in https://github.com/bitcoin/bitcoin/pull/29428#issuecomment-1952480346. Also updated the PR title and description.

💬 achow101 commented on pull request "rpc: return warnings as an array instead of just a single one":
(https://github.com/bitcoin/bitcoin/pull/29845#issuecomment-2073294918)
ACK 7b64820da65d9b75b181693223a6aeb9c50b4613

🤔 ajtowns reviewed a pull request: "script: throw disabled err for op_ver and its variants"
(https://github.com/bitcoin/bitcoin/pull/28169#pullrequestreview-2018182424)
I'm still ~0 on whether this actually improves anything, but I don't believe it causes any potential problems.

💬 achow101 commented on pull request "test: remove duplicated ban test":
(https://github.com/bitcoin/bitcoin/pull/29688#issuecomment-2073339535)
ACK e30e8625bbc42045b8b757a8d7e80c20cc61cebf

🚀 achow101 merged a pull request: "test: remove duplicated ban test"
(https://github.com/bitcoin/bitcoin/pull/29688)

⚠️ HaSan1y opened an issue: "help i think my core is hacked"
(https://github.com/bitcoin/bitcoin/issues/29944)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

https://explorer.btc.com/btc/transaction/c5069dd52612dd07cfff6a2c587356497a2f8e7489923376a92420850fe27d09

i only did an 0.01 transfer to freebitco.in but somehow it puts an additional 0.027 btc transfer to an unintend address in there how can i cancel it pls help fast

### Expected behaviour

https://explorer.btc.com/btc/transaction/c5069dd52612dd07cfff6a2c587356497a2f8e7489923376a92420
...