💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071673231)
I wiped the disk and reinstalled macOS 13.6.6. Still getting the permission denied error.

I narrowed it down further: this only happens when I clone the repo on my external SSD drive, not when it's on the built in disk.

```
Preprocessing bdb...
patching file 'dbinc/atomic.h'
Can't create '/var/folders/6c/n_bj8h8s0212j2tdtk_c_93m0000gn/T/patchogFOtRafNrn', output is in '/var/folders/6c/n_bj8h8s0212j2tdtk_c_93m0000gn/T/patchogFOtRafNrn': Permission denied
patch: **** can't create '/var/f
...

💬 maflcko commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071685458)
Does macOS, or patch respect `TMPDIR, TMP, TEMP,` or `TEMPDIR`? If yes, it could be used as a temporary workaround.

💬 maflcko commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1575878130)
Maybe move this to util.cpp as well? In theory it is the wrong place, because it depends on `FuzzedDataProvider`, but I think this isn't too important in tests.

👍 maflcko approved a pull request: "fuzz: wallet: add target for `CreateTransaction`"
(https://github.com/bitcoin/bitcoin/pull/29936#pullrequestreview-2016623784)
lgtm, nice!

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071750271)
It seems to:

```
mkdir /tmp/test

% TMPDIR=/tmp/test make NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_UPNP=1 NO_NATPMP=1 NO_USDT=1
Preprocessing bdb...
patching file 'dbinc/atomic.h'
Can't create '/tmp/test/patchoSHQPQFIlmq', output is in '/tmp/test/patchoSHQPQFIlmq': Permission denied
patch: **** can't create '/tmp/test/patchoSHQPQFIlmq': Permission denied
make: *** [/Volumes/SSD/test/bitcoin/depends/work/build/x86_64-apple-darwin22.6.0/bdb/4.8.30-0de9a3a86cb/.stamp_preprocessed
...

💬 maflcko commented on issue "ci: failure in `rpc_scanblocks.py`":
(https://github.com/bitcoin/bitcoin/issues/29831#issuecomment-2071791387)
https://cirrus-ci.com/task/4813688014635008?logs=ci#L3947


```
node1 2024-04-22T20:51:07.549912Z [scheduler] [index/base.cpp:293] [BlockConnected] BlockConnected: WARNING: Block 20c19368f5c214888708d959d40752a61a0c5e2fb5b331876693773c113e5da1 does not connect to an ancestor of known best chain (tip=39455d83324a3dbbb15712ab63dd2f96b45a30f271617aa16c12483a561f721c); not updating index
...
node0 2024-04-22T20:51:08.867727Z [httpworker.2] [rpc/request.cpp:187] [parse] [rpc] ThreadRPCServer
...

📝 9167674641 opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)
Mmmmm

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

✅ willcl-ark closed a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)

📝 fanquake locked a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)
Mmmmm

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

📝 hanmz opened a pull request: "Fix typos in description.md"
(https://github.com/bitcoin/bitcoin/pull/29938)
Fix typos in description.md.
`digestable` => `digestible`

💬 brunoerg commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1575956670)
Sgtm, will address it.

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1575987644)
Done. Also refactored orphanage_tests to be more readable.

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1575989359)
Edited the comment to say this is a probably uncommon case

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1575996002)
I definitely it's awkward and doesn't have much benefit. I'll leave the assume/handling here, and maybe in a followup we can change it to non-optional.

💬 maflcko commented on pull request "Fix typos in description.md":
(https://github.com/bitcoin/bitcoin/pull/29938#issuecomment-2071925121)
Also:

```
test/functional/test_framework/wallet_util.py:168: lenghts ==> lengths

💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2071948004)
i've added some review notes for the Qt patch here: https://github.com/laanwj/qtsowrap?tab=readme-ov-file#patching-qt

🤔 hebasto reviewed a pull request: "refactor: Use our own implementation of urlDecode"
(https://github.com/bitcoin/bitcoin/pull/29904#pullrequestreview-2016884640)
Approach ACK b7a3f8e375b87e4f3ccfa7994905dfbf46a23bf2.

💬 hebasto commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1576040769)
nit: For new source files we can use a copyright header with HTTPS link and future-proof dating:
```suggestion
// Copyright (c) 2024-present The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or https://opensource.org/license/mit/.
```

💬 hebasto commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1576041988)
nit: It seems no symbols from that header are used in the source file.

💬 tdb3 commented on pull request "test: Run framework unit tests in parallel":
(https://github.com/bitcoin/bitcoin/pull/29771#issuecomment-2071989207)
> The rebase is wrong.

Thank you. Looks like I had overlooked the addition of `wallet_util` (`TEST_FRAMEWORK_MODULES` being moved to feature_framework_unit_tests.py made it less obvious). Will rebase/push soon.