💬 Sjors commented on pull request "doc: add LLVM instruction for macOS < 13":
(https://github.com/bitcoin/bitcoin/pull/29934#discussion_r1575740996)
> Why would LLVM not work?

I have no way to test it. Since Homebrew itself does not support macOS 11 it's reasonable to expect that their newer formulas break, while the old ones might be fine.

This instruction is specifically for old versions of macOS. For newer versions we still have them use the latest thing.

💬 maflcko commented on pull request "test: Run framework unit tests in parallel":
(https://github.com/bitcoin/bitcoin/pull/29771#issuecomment-2071572818)
> Rebased to address conflict

The rebase is wrong. Please pay attention to correctly address any merge conflicts, as they arise. One way to avoid mistakes, is to review your own code changes and to check rebases, as other reviewers will do later. For example, using the range-diff, as explained in the docs.

💬 asctime commented on issue "ReadAnchor throws exception on second run":
(https://github.com/bitcoin/bitcoin/issues/29931#issuecomment-2071603173)
> That should not be the case. The point of standard C++ library `std::filesystem::remove` is to provide the same interface behavior, regardless of compiler or operating system.
>
> The specification says that `false` should be returned when the file does not exist, not an exception be thrown.

Ah good point ><. I'll try it once with my clang install, it's a fair bit newer than my gcc which is due to be updated anyway. Ok to close from my side. Thanks.

💬 laanwj commented on issue "RFC: In guix compile the GUI sequentially from everything else?":
(https://github.com/bitcoin/bitcoin/issues/29914#issuecomment-2071614437)
Sure, and there may still be other reasons to have seperate build step; the idea of fully static binaries for the non-GUI utilities was raised again at CoreDev. This is not possible with the GUI as it necessarily needs access to the dynamic linker. And as this might require different compile and linker flags, this would also effectively need two seperate builds.

💬 glozow commented on pull request "test: Fix intermittent timeout in p2p_tx_download.py":
(https://github.com/bitcoin/bitcoin/pull/29933#issuecomment-2071619983)
Thank you @maflcko!

💬 maflcko commented on pull request "test: Validate UTXO snapshot with coin height > base height & amount > MAX_MONEY supply":
(https://github.com/bitcoin/bitcoin/pull/29617#issuecomment-2071624163)
ACK ec1f1abfefa281e62bb876aa1c4738d576ef9a4 👑

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK ec1f1abfefa281e62bb876aa1c4
...

✅ maflcko closed an issue: "ReadAnchor throws exception on second run"
(https://github.com/bitcoin/bitcoin/issues/29931)

💬 maflcko commented on issue "ReadAnchor throws exception on second run":
(https://github.com/bitcoin/bitcoin/issues/29931#issuecomment-2071645719)
Closing for now, but please leave a comment if there are more details to debug this issue.

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071673231)
I wiped the disk and reinstalled macOS 13.6.6. Still getting the permission denied error.

I narrowed it down further: this only happens when I clone the repo on my external SSD drive, not when it's on the built in disk.

```
Preprocessing bdb...
patching file 'dbinc/atomic.h'
Can't create '/var/folders/6c/n_bj8h8s0212j2tdtk_c_93m0000gn/T/patchogFOtRafNrn', output is in '/var/folders/6c/n_bj8h8s0212j2tdtk_c_93m0000gn/T/patchogFOtRafNrn': Permission denied
patch: **** can't create '/var/f
...

💬 maflcko commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071685458)
Does macOS, or patch respect `TMPDIR, TMP, TEMP,` or `TEMPDIR`? If yes, it could be used as a temporary workaround.

💬 maflcko commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1575878130)
Maybe move this to util.cpp as well? In theory it is the wrong place, because it depends on `FuzzedDataProvider`, but I think this isn't too important in tests.

👍 maflcko approved a pull request: "fuzz: wallet: add target for `CreateTransaction`"
(https://github.com/bitcoin/bitcoin/pull/29936#pullrequestreview-2016623784)
lgtm, nice!

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2071750271)
It seems to:

```
mkdir /tmp/test

% TMPDIR=/tmp/test make NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_UPNP=1 NO_NATPMP=1 NO_USDT=1
Preprocessing bdb...
patching file 'dbinc/atomic.h'
Can't create '/tmp/test/patchoSHQPQFIlmq', output is in '/tmp/test/patchoSHQPQFIlmq': Permission denied
patch: **** can't create '/tmp/test/patchoSHQPQFIlmq': Permission denied
make: *** [/Volumes/SSD/test/bitcoin/depends/work/build/x86_64-apple-darwin22.6.0/bdb/4.8.30-0de9a3a86cb/.stamp_preprocessed
...

💬 maflcko commented on issue "ci: failure in `rpc_scanblocks.py`":
(https://github.com/bitcoin/bitcoin/issues/29831#issuecomment-2071791387)
https://cirrus-ci.com/task/4813688014635008?logs=ci#L3947


```
node1 2024-04-22T20:51:07.549912Z [scheduler] [index/base.cpp:293] [BlockConnected] BlockConnected: WARNING: Block 20c19368f5c214888708d959d40752a61a0c5e2fb5b331876693773c113e5da1 does not connect to an ancestor of known best chain (tip=39455d83324a3dbbb15712ab63dd2f96b45a30f271617aa16c12483a561f721c); not updating index
...
node0 2024-04-22T20:51:08.867727Z [httpworker.2] [rpc/request.cpp:187] [parse] [rpc] ThreadRPCServer
...

📝 9167674641 opened a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)
Mmmmm

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

✅ willcl-ark closed a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)

📝 fanquake locked a pull request: "Update README.md"
(https://github.com/bitcoin/bitcoin/pull/29937)
Mmmmm

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

📝 hanmz opened a pull request: "Fix typos in description.md"
(https://github.com/bitcoin/bitcoin/pull/29938)
Fix typos in description.md.
`digestable` => `digestible`

💬 brunoerg commented on pull request "fuzz: wallet: add target for `CreateTransaction`":
(https://github.com/bitcoin/bitcoin/pull/29936#discussion_r1575956670)
Sgtm, will address it.

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1575987644)
Done. Also refactored orphanage_tests to be more readable.