💬 luke-jr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067871490)
Concept NACK. Embedding copies of shared code just makes things more fragile, not safer. It's far more likely there's a bugfix that we miss picking up on, than that there's malicious code inserted later.
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067871490)
Concept NACK. Embedding copies of shared code just makes things more fragile, not safer. It's far more likely there's a bugfix that we miss picking up on, than that there's malicious code inserted later.
💬 luke-jr commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067873707)
Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067873707)
Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?
💬 Eunovo commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#issuecomment-2067879382)
Putting in draft while I fix falling test
(https://github.com/bitcoin/bitcoin/pull/29680#issuecomment-2067879382)
Putting in draft while I fix falling test
📝 Eunovo converted_to_draft a pull request: "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict"
(https://github.com/bitcoin/bitcoin/pull/29680)
This PR implements a fix for the issue described in https://github.com/bitcoin/bitcoin/issues/29435.
The problem is that the wallet is unable to abandon transactions that have unrelated parent conflicts. The solution implemented here, augments the mempool transaction `REPLACED` signal with the double-spending transaction which the wallet stores and watches for in Block notifications. A map is added to the wallet to track conflicting tx ids and their child transactions. The entry is erased wh
...
(https://github.com/bitcoin/bitcoin/pull/29680)
This PR implements a fix for the issue described in https://github.com/bitcoin/bitcoin/issues/29435.
The problem is that the wallet is unable to abandon transactions that have unrelated parent conflicts. The solution implemented here, augments the mempool transaction `REPLACED` signal with the double-spending transaction which the wallet stores and watches for in Block notifications. A map is added to the wallet to track conflicting tx ids and their child transactions. The entry is erased wh
...
✅ 1440000bytes closed an issue: "Add warnings or discontinue zip files for Windows and maOS "
(https://github.com/bitcoin/bitcoin/issues/29925)
(https://github.com/bitcoin/bitcoin/issues/29925)
💬 1440000bytes commented on issue "Add warnings or discontinue zip files for Windows and maOS ":
(https://github.com/bitcoin/bitcoin/issues/29925#issuecomment-2067893745)
I don't have a good solution for this. Maybe warnings or not using zip would have helped.
(https://github.com/bitcoin/bitcoin/issues/29925#issuecomment-2067893745)
I don't have a good solution for this. Maybe warnings or not using zip would have helped.
⚠️ tuttheking81 opened an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)
Pull request Name: Jodie Gerber
BSB: 633123
Acc #: 201579216 pay into this account please
_Originally posted by @Jodes77 in https://github.com/Jodes77/stripe-ios/issues/9#issuecomment-1890784985_
_Originally posted by @tuttheking81 in https://github.com/tuttheking81/cro1r7j5zaezn0s66vmglu4e2c5tstkydez67ryty8-tag-3816626514/issues/30_
(https://github.com/bitcoin/bitcoin/issues/29927)
Pull request Name: Jodie Gerber
BSB: 633123
Acc #: 201579216 pay into this account please
_Originally posted by @Jodes77 in https://github.com/Jodes77/stripe-ios/issues/9#issuecomment-1890784985_
_Originally posted by @tuttheking81 in https://github.com/tuttheking81/cro1r7j5zaezn0s66vmglu4e2c5tstkydez67ryty8-tag-3816626514/issues/30_
💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067931086)
> Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?
This is basically not possible with a C++ library. It is thanks to C's lack of name mangling and its straightforward linking model that makes this possible. Also Qt has a ton of symbols compared to these libraries.
Conceptually, a few low-level X (or in the future, Wayland) and font libraries are much likely to be on the user's system than a compatible version of Qt. That will
...
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067931086)
> Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?
This is basically not possible with a C++ library. It is thanks to C's lack of name mangling and its straightforward linking model that makes this possible. Also Qt has a ton of symbols compared to these libraries.
Conceptually, a few low-level X (or in the future, Wayland) and font libraries are much likely to be on the user's system than a compatible version of Qt. That will
...
✅ hebasto closed an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)
(https://github.com/bitcoin/bitcoin/issues/29927)
:lock: hebasto locked an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)
(https://github.com/bitcoin/bitcoin/issues/29927)
⚠️ Kino1994 opened an issue: "Signed Integer Overflow in GetBlockSubsidy at block height 2,147,483,647 (During Epoch 10,227, halving 10,226) could Increase Block Subsidy"
(https://github.com/bitcoin/bitcoin/issues/29928)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
The GetBlockSubsidy function could potentially encounter a signed integer overflow if nHeight reaches 2,147,483,648, causing it to wrap to -2,147,483,648. This overflow can disrupt the halving mechanism implemented in the function, particularly around the calculated 10,226th halving interval derived from INT_MAX / nSubsidyHalvingInterval.
Implications:
Such an overflow could lead to
...
(https://github.com/bitcoin/bitcoin/issues/29928)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
The GetBlockSubsidy function could potentially encounter a signed integer overflow if nHeight reaches 2,147,483,648, causing it to wrap to -2,147,483,648. This overflow can disrupt the halving mechanism implemented in the function, particularly around the calculated 10,226th halving interval derived from INT_MAX / nSubsidyHalvingInterval.
Implications:
Such an overflow could lead to
...
💬 laanwj commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-2067951956)
See #29923, it is a first step to Wayland support in the release binaries without the earlier noted drawbacks of requiring extra build-time or run-time dependencies.
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-2067951956)
See #29923, it is a first step to Wayland support in the release binaries without the earlier noted drawbacks of requiring extra build-time or run-time dependencies.
💬 laanwj commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067954555)
> It's far more likely there's a bugfix that we miss picking up on, than that there's malicious code inserted later.
Sometimes i'd agree with that reasoning. But let's face it, `urlDecode` is not more complex than say, `leftpad`, it's unlikely to need maintainance or bug fixes, and thus seems unnecessary to carry a dependency for.
(Also this isn't a direct copy of the C code! It's a C++ reimplementation that does `std::string` to `std::string`, so should handle embedded NULL bytes withou
...
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067954555)
> It's far more likely there's a bugfix that we miss picking up on, than that there's malicious code inserted later.
Sometimes i'd agree with that reasoning. But let's face it, `urlDecode` is not more complex than say, `leftpad`, it's unlikely to need maintainance or bug fixes, and thus seems unnecessary to carry a dependency for.
(Also this isn't a direct copy of the C code! It's a C++ reimplementation that does `std::string` to `std::string`, so should handle embedded NULL bytes withou
...
💬 maflcko commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067959418)
> supported platforms
My understanding is that you can run Bitcoin Core on those platforms. However, compiling Bitcoin Core from source may not work out of the box.
If macOS does not offer an upgrade path for the system compiler, can you try to use a compiler provided by `brew`?
Another alternative would be to compile the compiler you need yourself.
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067959418)
> supported platforms
My understanding is that you can run Bitcoin Core on those platforms. However, compiling Bitcoin Core from source may not work out of the box.
If macOS does not offer an upgrade path for the system compiler, can you try to use a compiler provided by `brew`?
Another alternative would be to compile the compiler you need yourself.
💬 laanwj commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1573675369)
The check currently always fails for other-endian wallets, needs something like:
```diff
diff --git a/src/wallet/migrate.cpp b/src/wallet/migrate.cpp
index 15478e8bc5bfe39e04b400fa475215e25eef6452..0a41ae199e1950bf372bae90b8a88fccca2b88f0 100644
--- a/src/wallet/migrate.cpp
+++ b/src/wallet/migrate.cpp
@@ -566,6 +566,10 @@ void BerkeleyRODatabase::Open()
uint32_t offset;
SeekToPage(db_file, i, page_size);
db_file >> file >> offset;
+ if (outer_meta.oth
...
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1573675369)
The check currently always fails for other-endian wallets, needs something like:
```diff
diff --git a/src/wallet/migrate.cpp b/src/wallet/migrate.cpp
index 15478e8bc5bfe39e04b400fa475215e25eef6452..0a41ae199e1950bf372bae90b8a88fccca2b88f0 100644
--- a/src/wallet/migrate.cpp
+++ b/src/wallet/migrate.cpp
@@ -566,6 +566,10 @@ void BerkeleyRODatabase::Open()
uint32_t offset;
SeekToPage(db_file, i, page_size);
db_file >> file >> offset;
+ if (outer_meta.oth
...
💬 maflcko commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067964609)
> Faced this too. Updating to 14.0.3 fixes the problem.
Just to clarify the confusing versioning here, this corresponds to Xcode 14.3, llvm 15, and Apple Clang 14.0.3
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067964609)
> Faced this too. Updating to 14.0.3 fixes the problem.
Just to clarify the confusing versioning here, this corresponds to Xcode 14.3, llvm 15, and Apple Clang 14.0.3
💬 maflcko commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1573680139)
nit in a0b4c1b7a3bfeaeae0277fe151cd5ef9b31ccf15: Is this used in this pull request? I wonder if it could make sense to return the error string to the caller, assuming this is called by RPC eventually?
(https://github.com/bitcoin/bitcoin/pull/26606#discussion_r1573680139)
nit in a0b4c1b7a3bfeaeae0277fe151cd5ef9b31ccf15: Is this used in this pull request? I wonder if it could make sense to return the error string to the caller, assuming this is called by RPC eventually?
💬 TheCharlatan commented on pull request "[refactor] Check CTxMemPool options in ctor":
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2067972727)
Reworked 364456f6598b135fcc0acab8a660658b4407f837 -> 30a1024b63105a97d04149e83ae2d8cf0830cf69 ([mempoolArgs_4](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_4) -> [mempoolArgs_5](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_5), [compare](https://github.com/TheCharlatan/bitcoin/compare/mempoolArgs_4..mempoolArgs_5))
* Reworked this after @ryanofsky's [comment](https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2059591077). I agree that the better option here is t
...
(https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2067972727)
Reworked 364456f6598b135fcc0acab8a660658b4407f837 -> 30a1024b63105a97d04149e83ae2d8cf0830cf69 ([mempoolArgs_4](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_4) -> [mempoolArgs_5](https://github.com/TheCharlatan/bitcoin/tree/mempoolArgs_5), [compare](https://github.com/TheCharlatan/bitcoin/compare/mempoolArgs_4..mempoolArgs_5))
* Reworked this after @ryanofsky's [comment](https://github.com/bitcoin/bitcoin/pull/28830#issuecomment-2059591077). I agree that the better option here is t
...
💬 levantah commented on issue "Release schedule for 27.0":
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2067979559)
Excuse me,
the bitcoincore.org/bin was quite slow for me so here is a hopefully-faster mirror with no data limits: https://ln.anyone.eu.org/bin/bitcoin-core-27.0/
See https://cfpages-cache.pages.dev/ ( or full -log=(https://cfpages-cache.pages.dev/log.txt)) for the latest cache-fill.
HTH
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2067979559)
Excuse me,
the bitcoincore.org/bin was quite slow for me so here is a hopefully-faster mirror with no data limits: https://ln.anyone.eu.org/bin/bitcoin-core-27.0/
See https://cfpages-cache.pages.dev/ ( or full -log=(https://cfpages-cache.pages.dev/log.txt)) for the latest cache-fill.
HTH
💬 fanquake commented on issue "Release schedule for 27.0":
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2068002408)
@levantah thanks, however we'll refrain from linking to sources other than our own website.
(https://github.com/bitcoin/bitcoin/issues/29028#issuecomment-2068002408)
@levantah thanks, however we'll refrain from linking to sources other than our own website.