💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1573465667)
Nice. Done!

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-2067822211)
Updates:
- Addressed [feedback](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) provided by @jonatack regarding first commit 6898219043f42ae42e4703c549e656f56d276d13.
- Updated second commit cf7dd3564a3ace4153a32930f36bd78432b59097 following some directions [given](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1483546926) by @jonatack and [discussed](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1573464319) with @andrewtoth.
- Fixed incorr
...

💬 fjahr commented on pull request "test: Fix multiprocess CI timeout in p2p_tx_download":
(https://github.com/bitcoin/bitcoin/pull/29926#issuecomment-2067826359)
#28313 / #28321 may be related

💬 luke-jr commented on pull request "[WIP] libevent @ master + use CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2067837088)
This doesn't seem like a good enough reason to use untested/unreleased code... :/

💬 luke-jr commented on pull request "policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only)":
(https://github.com/bitcoin/bitcoin/pull/29843#issuecomment-2067841261)
Seems like this goes beyond the expected behaviour. Maybe make it `=2` at least?

👍 luke-jr approved a pull request: "net: Decrease nMaxIPs when learning from DNS seeds"
(https://github.com/bitcoin/bitcoin/pull/29850#pullrequestreview-2013209083)
utACK

💬 luke-jr commented on pull request "util: remove unused cpp-subprocess options":
(https://github.com/bitcoin/bitcoin/pull/29865#issuecomment-2067857920)
This seems likely to have a high maintenance cost. What's the benefit?

💬 luke-jr commented on pull request "tracing: cast block_connected duration to µs":
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2067867597)
So 23.x and 24.x used microseconds, while 25.x, 26.x, and 27.x currently use nanoseconds?

Seems like changing this back will disrupt more than it will fix...? Any reason not to just stick to nanoseconds and harden it against future accidents?

💬 showtime73 commented on pull request "tracing: cast block_connected duration to µs":
(https://github.com/bitcoin/bitcoin/pull/29877#issuecomment-2067870839)
Oh geez

💬 luke-jr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067871490)
Concept NACK. Embedding copies of shared code just makes things more fragile, not safer. It's far more likely there's a bugfix that we miss picking up on, than that there's malicious code inserted later.

💬 luke-jr commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067873707)
Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?

💬 Eunovo commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#issuecomment-2067879382)
Putting in draft while I fix falling test

📝 Eunovo converted_to_draft a pull request: "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict"
(https://github.com/bitcoin/bitcoin/pull/29680)
This PR implements a fix for the issue described in https://github.com/bitcoin/bitcoin/issues/29435.

The problem is that the wallet is unable to abandon transactions that have unrelated parent conflicts. The solution implemented here, augments the mempool transaction `REPLACED` signal with the double-spending transaction which the wallet stores and watches for in Block notifications. A map is added to the wallet to track conflicting tx ids and their child transactions. The entry is erased wh
...

✅ 1440000bytes closed an issue: "Add warnings or discontinue zip files for Windows and maOS "
(https://github.com/bitcoin/bitcoin/issues/29925)

💬 1440000bytes commented on issue "Add warnings or discontinue zip files for Windows and maOS ":
(https://github.com/bitcoin/bitcoin/issues/29925#issuecomment-2067893745)
I don't have a good solution for this. Maybe warnings or not using zip would have helped.

⚠️ tuttheking81 opened an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)
Pull request Name: Jodie Gerber
BSB: 633123
Acc #: 201579216 pay into this account please

_Originally posted by @Jodes77 in https://github.com/Jodes77/stripe-ios/issues/9#issuecomment-1890784985_

_Originally posted by @tuttheking81 in https://github.com/tuttheking81/cro1r7j5zaezn0s66vmglu4e2c5tstkydez67ryty8-tag-3816626514/issues/30_

💬 laanwj commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067931086)
> Instead of Qt's dependencies, maybe we should wrap Qt itself this way? Or do C++ templates break that too much?

This is basically not possible with a C++ library. It is thanks to C's lack of name mangling and its straightforward linking model that makes this possible. Also Qt has a ton of symbols compared to these libraries.

Conceptually, a few low-level X (or in the future, Wayland) and font libraries are much likely to be on the user's system than a compatible version of Qt. That will
...

✅ hebasto closed an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)

:lock: hebasto locked an issue: "Pull request Name: Jodie Gerber"
(https://github.com/bitcoin/bitcoin/issues/29927)

⚠️ Kino1994 opened an issue: "Signed Integer Overflow in GetBlockSubsidy at block height 2,147,483,647 (During Epoch 10,227, halving 10,226) could Increase Block Subsidy"
(https://github.com/bitcoin/bitcoin/issues/29928)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

The GetBlockSubsidy function could potentially encounter a signed integer overflow if nHeight reaches 2,147,483,648, causing it to wrap to -2,147,483,648. This overflow can disrupt the halving mechanism implemented in the function, particularly around the calculated 10,226th halving interval derived from INT_MAX / nSubsidyHalvingInterval.

Implications:

Such an overflow could lead to
...