💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067666130)
Test e79c54456f3e299a619a46451a4ce5a017b8da44 continued.

Compiler flags for `HOST=x86_64-w64-mingw32` are OK, including correct `-D_WIN32_WINNT=0x0601`.

However, the commit e5a114ac762fb6ce331998e6d2730386b9dbc905 is broken, which is not good for the commit history:
```
$ make -C depends miniupnpc HOST=x86_64-w64-mingw32
make: Entering directory '/home/hebasto/git/bitcoin/depends'
Extracting miniupnpc...
/home/hebasto/git/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessi
...

💬 furszy commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067670190)
Faced this too. Updating to 14.0.3 fixes the problem.

💬 Sapo07 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2067670663)
Pago de servicios

💬 Sapo07 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2067671011)
Calendario de lanzamiento para 28.0 #29891 aceptable estable aplica

👍 TheCharlatan approved a pull request: "deploy: remove some tools when cross-compiling for macOS"
(https://github.com/bitcoin/bitcoin/pull/29890#pullrequestreview-2013093146)
ACK 1a9aa8d4eedff3788c792799328ad599132e0da1

Guix builds (x86_64):

```751ede1b4f680d44c97a9aab396e0a485e3a47c88ecc30ec8b83e53784fc3f50 guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/SHA256SUMS.part
871cf387d5d60efc0ec9e50f975a9f44b2e2f9b7d92d1f2744affc3c8a5e1655 guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/bitcoin-1a9aa8d4eedf-arm64-apple-darwin-unsigned.tar.gz
6a8de4ac9647549d146a53a9167b00f72ac09168939284b76fa9b6cf81595fea guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/bi
...

📝 laanwj opened a pull request: "depends: Remove Qt build-time dependencies"
(https://github.com/bitcoin/bitcoin/pull/29923)
In the spirit of the halving, let's (approximately) halve the number of packages in depends. Remove the following packages:
```diff
bdb.mk
boost.mk
capnp.mk
- expat.mk
- fontconfig.mk
- freetype.mk
libevent.mk
libmultiprocess.mk
libnatpmp.mk
- libXau.mk
- libxcb.mk
- libxcb_util.mk
- libxcb_util_image.mk
- libxcb_util_keysyms.mk
- libxcb_util_render.mk
- libxcb_util_wm.mk
- libxkbcommon.mk
miniupnpc.mk
native_capnp.mk
native_cctools.mk
native_libmultipro
...

💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067713157)
FWIW, I found another Windows-specific bug in the upstream: https://github.com/miniupnp/miniupnp/pull/727.

💬 hebasto commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067717721)
> Faced this too. Updating to 14.0.3 fixes the problem.

Well, that's actually means switching to the toolchain based on LLVM 15.

💬 Gary19751957 commented on pull request "depends: Remove Qt build-time dependencies":
(https://github.com/bitcoin/bitcoin/pull/29923#issuecomment-2067721400)
Why am I receiving these emails?This person is using my email to hack my
Bitcoin account,please help, Gary Rollins my phone number is 8593467976
please help!!

Gary Rollins

On Sat, Apr 20, 2024, 11:46 AM DrahtBot ***@***.***> wrote:

> The following sections might be updated with supplementary metadata
> relevant to reviewers and maintainers.
> Code Coverage
>
> For detailed information about the code coverage, see the test coverage
> report <https://corecheck.dev/bitcoin/bitcoin/p
...

👋 fanquake's pull request is ready for review: "guix: remove bzip2 from deps"
(https://github.com/bitcoin/bitcoin/pull/29895)

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345116)
done

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345292)
Not sure I understand your question, do you mean this line in particular or the whole hooking thing? This line was added the with the rest of hooking code in #18504 and I don't anything was changed about that until now, so I don't know where we might have forgotten to remove it.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345315)
Thanks, added.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345459)
I think this is less readable so I will keep it as is but I did take @Sjors 's suggestion to change it to change `ptr` to `_`.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345552)
I think this is less readable so I will keep it as is but I did take @Sjors 's suggestion to change it to change `ptr` to `_`.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345672)
Like above, I think this is a bit less readable so I will keep it as is.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573345724)
Either way, someone might get confused, but I think it's better to keep it as is.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1573347809)
You're right, good catch! I was focussing too much on the behavior inside of libevent and didn't take into account that the result was cast to `std::string` afterwards, which lead to the behavior that a null character terminated the string. I have changed this to keep behavior consistent with the libevent version.

💬 fjahr commented on pull request "refactor: Use our own implementation of urlDecode":
(https://github.com/bitcoin/bitcoin/pull/29904#issuecomment-2067736339)
Addressed feedback by @paplorinc and @Sjors , thanks a lot!

I also reorganized the commits a bit because they were doing more than one thing and it was hard to address feedback cleanly. The tests are now split from the implementation, which makes it easier to cherry-pick the unit test commit and run it against master. And I split off the renaming into a scripted diff.

🤔 sr-gi reviewed a pull request: "p2p: opportunistically accept 1-parent-1-child packages"
(https://github.com/bitcoin/bitcoin/pull/28970#pullrequestreview-2013113076)
Second pass (up to the same height: 42859548ab5aebf40da6089b85065f7c204b992a)

Left some additional comments on the updated approach.