Bitcoin Core Github
43 subscribers
122K links
Download Telegram
📝 achow101 locked a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
achow101 closed an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
:lock: achow101 locked an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
achow101 closed a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
📝 achow101 locked a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are a
...
💬 fanquake commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067565383)
We'll be dropping support for this compiler as soon as oss-fuzz rolls their Clang, and we bump our minimum.
⚠️ Spire83 opened an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
<!-- Edit the body of your new issue then click the ✓ "Create Issue" button in the top right of the editor. The first line will be the issue title. Assignees and Labels follow after a blank line. Leave an empty line before beginning the body of the issue. -->
willcl-ark closed an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
💬 Lastat22 commented on issue "Proposal for a new mempool design":
(https://github.com/bitcoin/bitcoin/issues/27677#issuecomment-2067606886)
Change is always good find new horizons develops character builds new path ways to be newly enlighten is the key in life new knowledge means growth growth means productivity proverb lastat 22 aka Mnt man
💬 1440000bytes commented on issue "DNS seed "seed.bitcoinstats.com" doesn't support filtering while the comments says it does":
(https://github.com/bitcoin/bitcoin/issues/29911#issuecomment-2067609951)
> I guess I should add that I don't think the nodes returned by "seed.bitcoinstats.com" are good.
>
> My assumptions is that it's just caching all the nodes it's previously seen and not checking if they're still providing all the services it previously has.

I have stopped using these DNS seeds. I found only 2 useful when I last tested:

seed.bitcoin.sipa.be
seed.bitcoin.wiz.biz
:lock: fanquake locked an issue: "Issue Title"
(https://github.com/bitcoin/bitcoin/issues/29922)
💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067656695)
Tested e79c54456f3e299a619a46451a4ce5a017b8da44.

I've verified compiler flags for CMake vs Autotools without providing the `HOST` variable:
1. A new `-DMINIUPNP_STATICLIB` macro, which basically is Windows-specific and has no affect on non-Windows targets.
2. The `-fno-common` flag is being missed, however, it the default for both [GCC](https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fcommon) and [Clang](https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-cla
...
💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067666130)
Test e79c54456f3e299a619a46451a4ce5a017b8da44 continued.

Compiler flags for `HOST=x86_64-w64-mingw32` are OK, including correct `-D_WIN32_WINNT=0x0601`.

However, the commit e5a114ac762fb6ce331998e6d2730386b9dbc905 is broken, which is not good for the commit history:
```
$ make -C depends miniupnpc HOST=x86_64-w64-mingw32
make: Entering directory '/home/hebasto/git/bitcoin/depends'
Extracting miniupnpc...
/home/hebasto/git/bitcoin/depends/sources/miniupnpc-2.2.7.tar.gz: OK
Preprocessi
...
💬 furszy commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067670190)
Faced this too. Updating to 14.0.3 fixes the problem.
💬 Sapo07 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2067670663)
Pago de servicios
💬 Sapo07 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2067671011)
Calendario de lanzamiento para 28.0 #29891 aceptable estable aplica
👍 TheCharlatan approved a pull request: "deploy: remove some tools when cross-compiling for macOS"
(https://github.com/bitcoin/bitcoin/pull/29890#pullrequestreview-2013093146)
ACK 1a9aa8d4eedff3788c792799328ad599132e0da1

Guix builds (x86_64):

```751ede1b4f680d44c97a9aab396e0a485e3a47c88ecc30ec8b83e53784fc3f50 guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/SHA256SUMS.part
871cf387d5d60efc0ec9e50f975a9f44b2e2f9b7d92d1f2744affc3c8a5e1655 guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/bitcoin-1a9aa8d4eedf-arm64-apple-darwin-unsigned.tar.gz
6a8de4ac9647549d146a53a9167b00f72ac09168939284b76fa9b6cf81595fea guix-build-1a9aa8d4eedf/output/arm64-apple-darwin/bi
...
📝 laanwj opened a pull request: "depends: Remove Qt build-time dependencies"
(https://github.com/bitcoin/bitcoin/pull/29923)
In the spirit of the halving, let's (approximately) halve the number of packages in depends. Remove the following packages:
```diff
bdb.mk
boost.mk
capnp.mk
- expat.mk
- fontconfig.mk
- freetype.mk
libevent.mk
libmultiprocess.mk
libnatpmp.mk
- libXau.mk
- libxcb.mk
- libxcb_util.mk
- libxcb_util_image.mk
- libxcb_util_keysyms.mk
- libxcb_util_render.mk
- libxcb_util_wm.mk
- libxkbcommon.mk
miniupnpc.mk
native_capnp.mk
native_cctools.mk
native_libmultipro
...
💬 hebasto commented on pull request "depends: build miniupnpc with CMake":
(https://github.com/bitcoin/bitcoin/pull/29707#issuecomment-2067713157)
FWIW, I found another Windows-specific bug in the upstream: https://github.com/miniupnp/miniupnp/pull/727.
💬 hebasto commented on issue "Apple Clang 14.0 lacks support for `std::is_eq`":
(https://github.com/bitcoin/bitcoin/issues/29918#issuecomment-2067717721)
> Faced this too. Updating to 14.0.3 fixes the problem.

Well, that's actually means switching to the toolchain based on LLVM 15.