⚠️ IAmAdamRest opened an issue: "Windows 11 Blocks Install Due to "Virus Found""
(https://github.com/bitcoin/bitcoin/issues/29917)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Windows 11 Microsoft Defender blocks the installation of Bitcoin-Core version 27.0.0 due to a virus being found. Smartscreen also blocks the installer. I was able to get it installed by telling Microsoft Defender to ignore the "virus" but since this is the default behavior of Windows 11 now this could be an issue for new users who don't know anything.

### Expected behaviour

That the inst
...

💬 iotamega commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067281777)
I had the same error. Be sure to not just disable Defender temporarily to get around the issue and start Bitcoin Core, it will later turn back on and kill the process again. To fully fix the issue you will need to go inside Defender and ALWAYS IGNORE the threat notification for the time being.

Otherwise things will start up just fine and run for a few hours before Defender freaks out and closes it down.

I believe the source is clean from a ten thousand foot review and this is a false posit
...

💬 hebasto commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067281851)
@iotamega

Your log shows a non-default number of connections:
> 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)

However, it does not mention the `-maxconnections` option. Can you clarify this point please?

💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067284813)
> @iotamega
>
> Your log shows a non-default number of connections:
>
> > 2024-04-19T18:42:06Z Using at most 422 automatic connections (2048 file descriptors available)
>
> However, it does not mention the `-maxconnections` option. Can you clarify this point please?

I am passing a higher maxconnections option because I operate a large number of nodes. I can likely lower that if we believe it is having an impact as I just selected an arbitrary high number because usually I just let th
...

💬 hebasto commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067287149)
This is false positive.

For example, https://github.com/bitcoin/bitcoin/issues?q=is%3Aissue+windows+virus.

✅ IAmAdamRest closed an issue: "Windows 11 Blocks Install Due to "Virus Found""
(https://github.com/bitcoin/bitcoin/issues/29917)

💬 IAmAdamRest commented on issue "Windows 11 Blocks Install Due to "Virus Found"":
(https://github.com/bitcoin/bitcoin/issues/29917#issuecomment-2067290867)
Thanks for the clarification, I added to always ignore and it started without issue.

💬 hebasto commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067300160)
@iotamega

> ### Expected behaviour
>
> To be able to right click and ban known bad acting peers without a crash.

Is the issue reproducible when you're using `setban` RPC, for example in the Console tab?

> I am passing a higher maxconnections option...

How?

💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067307693)
> @iotamega
>
> > ### Expected behaviour
> > To be able to right click and ban known bad acting peers without a crash.
>
> Is the issue reproducible when you're using `setban` RPC, for example, in the Console tab?
>
> > I am passing a higher maxconnections option...
>
> How?

I haven't tried from the console but will next time I come across one of these fake clients trying to overwhelm my node which seemingly happens every few hours.

After I had issues with the binary I downloa
...

💬 pinheadmz commented on pull request "doc: update release-process.md":
(https://github.com/bitcoin/bitcoin/pull/29645#discussion_r1573048851)
Mine as well also include the parent directories, there are two `detached-sig-create.sh` between`macdeploy/` and `windeploy/`

💬 iotamega commented on issue "Crashes in v27 on Windows 10 and 11":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2067390572)
Just updating to add that using the RPC method does not cause a crash further making me think this is QT related somehow.

⚠️ hebasto opened an issue: "Apple Clang 14.0 lacks support for `std::is_eq`"
(https://github.com/bitcoin/bitcoin/issues/29918)
```
% cat test.cpp
#include <compare>

int main()
{
double foo = -0.0;
double bar = 0.0;
return std::is_eq(foo <=> bar);
}
% clang++ -std=c++20 test.cpp
test.cpp:7:15: error: no member named 'is_eq' in namespace 'std'
return std::is_eq(foo <=> bar);
~~~~~^
1 error generated.
% clang -v
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Libra
...

📝 JonathanTylerCombs opened a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

⚠️ khnt2x3 opened an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)
### Please describe the feature you'd like to see added.

I'd like to see gen=0|1 added back into Bitcoin Core aka Satoshi Clients.

### Is your feature related to a problem, if so please describe it.

I learned about gen=0|1 growing up.

So, when I was working with the random person on mIRC #Math Channel. I specifically knew I want gen=0|1 added to the system, one, for the Adult Gaming Industry, two, because it just made sense to have this contrary to not.

Today the default mining mo
...

✅ achow101 closed a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)

📝 JonathanTylerCombs opened a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improve coverage are a
...

📝 achow101 locked a pull request: "Codespace laughing carnival g44xqwpj7jj9367w"
(https://github.com/bitcoin/bitcoin/pull/29919)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)

:lock: achow101 locked an issue: "gen=0|1 "
(https://github.com/bitcoin/bitcoin/issues/29920)

✅ achow101 closed a pull request: "Check this out"
(https://github.com/bitcoin/bitcoin/pull/29921)