⚠️ Alfgb opened an issue: "Afoito.com"
(https://github.com/bitcoin/bitcoin/issues/29902)

💬 Sjors commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2063151580)
I use both the default signet and at least one custom one, so having separate directories would be quite useful. Shorter would be nice.

Ideally we would also support different config file sections and startup flags, using the same convention:

```
src/bitcoind -chain=signet_xxxx
```

```ini
[signet]
prune=1000

[signet_xxx]
signetchallenge=51
signetseednode=...
```

💬 maflcko commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#issuecomment-2063158835)
ACK 60ca5d55081275a011ccfc9546e0c4a8c4030493 🍳

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK 60ca5d55081275a011ccfc9546
...

✅ maflcko closed an issue: "Afoito.com"
(https://github.com/bitcoin/bitcoin/issues/29902)

💬 maflcko commented on pull request "refactor: Misc int sign change fixes":
(https://github.com/bitcoin-core/gui/pull/806#issuecomment-2063201720)
rfm, or is anything left to be done here?

💬 Sjors commented on pull request "net: Decrease nMaxIPs when learning from DNS seeds":
(https://github.com/bitcoin/bitcoin/pull/29850#issuecomment-2063203156)
utACK f2e3662e57eca1330962faf38ff428a564d50a11

💬 maflcko commented on pull request "Change example address from legacy (P2PKH) to bech32m (P2TR)":
(https://github.com/bitcoin-core/gui/pull/808#issuecomment-2063203191)
rfm or is anything left to be done here?

💬 maflcko commented on pull request "Fix create unsigned transaction fee bump":
(https://github.com/bitcoin-core/gui/pull/812#issuecomment-2063214931)
rfm?

💬 theStack commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1570150713)
nit, feel free to ignore: strictly speaking those 3 lines are not needed, as sending in the tx unsolicitedly (without prior inv/getdata) works as well, though not adhering to the typical protocol flow.

💬 stickies-v commented on pull request "rpc: return warnings as an array instead of just a single one":
(https://github.com/bitcoin/bitcoin/pull/29845#discussion_r1570187240)
Agreed, that looks like a nice follow-up. Happy to have a go after this gets merged.

💬 stickies-v commented on pull request "rpc: return warnings as an array instead of just a single one":
(https://github.com/bitcoin/bitcoin/pull/29845#issuecomment-2063243023)
Thanks for the reviews everyone. Force-pushed to address maflcko's style nits. Otherwise no changes so should be a quick re-review.

💬 maflcko commented on pull request "rpc: Reword SighashFromStr error message":
(https://github.com/bitcoin/bitcoin/pull/29870#issuecomment-2063296042)
Anything left to be done here?

👍 maflcko approved a pull request: "build: Enable fuzz binary in MSVC"
(https://github.com/bitcoin/bitcoin/pull/29774#pullrequestreview-2008182858)
Haven't reviewed anything in build_msvc

lgtm ACK 37cda55b3923fa8c18059c8dfd8c61a537d6b8b5 🚗

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
...

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1570242855)
Nit in the first commit:

An alternative, smaller diff, not using the `eof` and `fail` methods would be:

```diff
diff --git a/src/test/fuzz/fuzz.cpp b/src/test/fuzz/fuzz.cpp
index a8e490b459..f9915187bd 100644
--- a/src/test/fuzz/fuzz.cpp
+++ b/src/test/fuzz/fuzz.cpp
@@ -25,7 +25,6 @@
#include <memory>
#include <string>
#include <tuple>
-#include <unistd.h>
#include <utility>
#include <vector>

@@ -135,9 +134,9 @@ void initialize()
#if defined(PROVIDE_FUZZ_MAIN_FUNCTION
...

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1570248297)
c7993ce1cdab89171292b1c3a422480845d4dc19: Would be nice to say why this is done?

👍 hebasto approved a pull request: "refactor: Misc int sign change fixes"
(https://github.com/bitcoin-core/gui/pull/806#pullrequestreview-2008211321)
ACK 05416422d354b29d59558ce227e076028338b442, I have reviewed the code and it looks OK.

💬 maflcko commented on pull request "rpc: return warnings as an array instead of just a single one":
(https://github.com/bitcoin/bitcoin/pull/29845#issuecomment-2063331301)
scanblocks CI failure is known, unrelated, and can be ignored.


re-ACK 7cad21a8bbd1e0b64a5e586b405c8619b9e701a5 🛵

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A
...

💬 laanwj commented on pull request "wallet: Implement independent BDB parser":
(https://github.com/bitcoin/bitcoin/pull/26606#issuecomment-2063345481)
ACK f4f7eda0bf0e798d305df331c1d94443b81dff22

i've extensively reviewed the code and tested `bitcoin-wallet -withinternalbdb dump ...` on a fair number of historical wallet database backups, getting the exact same dump as BerkeleyDB, or in one case the "LSNs are not reset" error (because it wasn't cleanly closed at the time).

There are a lot of checks and i'm reasonably confident that this won't silently drop or corrupt any data (in one way safer than BDB: it truly opens read-only), instea
...

✅ hebasto closed an issue: "implicit-integer-sign-change wallet/interfaces.cpp:289:57"
(https://github.com/bitcoin-core/gui/issues/805)

🚀 hebasto merged a pull request: "refactor: Misc int sign change fixes"
(https://github.com/bitcoin-core/gui/pull/806)