👍 maflcko approved a pull request: "test: refactor: introduce and use `calculate_input_weight` helper"
(https://github.com/bitcoin/bitcoin/pull/29777#pullrequestreview-1995987988)
lgtm

💬 paplorinc commented on pull request "refactor/test: add a few more base32/64 calculation corner cases":
(https://github.com/bitcoin/bitcoin/pull/29847#discussion_r1562143566)
Reverted.
I've changed it originally to be in alignment with the `EncodeBase64`

📝 hebasto opened a pull request: "build: Fix false positive `CHECK_ATOMIC` test for clang-15"
(https://github.com/bitcoin/bitcoin/pull/29859)
On the master branch @ 0de63b8b46eff5cda85b4950062703324ba65a80, a building `bitcoind` with clang-15 for `i686-pc-linux-gnu` fails to link:
```
CXXLD bitcoind
/usr/bin/ld: libbitcoin_wallet.a(libbitcoin_wallet_a-wallet.o): in function `std::remove_volatile<double>::type std::__atomic_impl::load<double>(double const*, std::memory_order)':
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:948: undefined reference to `__atomic_load'
/usr/bin/ld: libbitc
...

💬 Thales-de-Milet commented on pull request ".":
(https://github.com/bitcoin-core/gui/pull/816#issuecomment-2051321028)
> The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
>
> ### Reviews
> See [the guideline](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review) for information on the review process. A summary of reviews will appear here.

#816

👍 dergoegge approved a pull request: "sign: don't assume we are parsing a sane TapMiniscript"
(https://github.com/bitcoin/bitcoin/pull/29853#pullrequestreview-1996279397)
utACK bdf2ef2c94cae2b0e2cdac1866322b4f9f7c7a7b

💬 maflcko commented on pull request "build: Fix false positive `CHECK_ATOMIC` test for clang-15":
(https://github.com/bitcoin/bitcoin/pull/29859#issuecomment-2051374764)
The same happens with clang-18 locally, but why does CI pass?

fad23a06469607689c4f637bb407c96af4902a27

💬 brunoerg commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#issuecomment-2051379737)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/29833#discussion_r1560532624. Thanks, @laanwj.

💬 laanwj commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#issuecomment-2051395460)
Thanks!
Code review ACK 9fa50338c115f0286637142fd887b212fddfb27d

💬 sipa commented on pull request "minisketch: pull subtree + #81":
(https://github.com/bitcoin/bitcoin/pull/29823#issuecomment-2051424104)
https://github.com/sipa/minisketch/pull/81 is now merged upstream.

⚠️ maflcko opened an issue: "test: Intermittent issue in p2p_compactblocks_hb.py" in relay_block_through assert_equal(status_to, status_from) AssertionError: not([True, False, True, True] == [True, True, True, True])"
(https://github.com/bitcoin/bitcoin/issues/29860)
Logs: https://drahtbot.space/temp_scratch/p2p_compactblocks_hb_170.tar.zstd

```
test 2024-04-10T02:55:04.098000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()

...

⚠️ case456 opened an issue: "Errors in block header at FlatFilePos"
(https://github.com/bitcoin/bitcoin/issues/29861)
ReadBlockFromDisk: Errors in block header at FlatFilePos(nFile=12, nPos=684188)
2024-04-12T09:45:50Z *** Failed to read block
2024-04-12T09:45:50Z Error: A fatal internal error occurred, see debug.log for details

💬 case456 commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051539334)
How do I go about fixing this?

💬 maflcko commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051547235)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206

💬 flack commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051671919)
would be nice if a click on a row where the dialog is already open would bring that dialog to the foreground

👋 fanquake's pull request is ready for review: "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492"
(https://github.com/bitcoin/bitcoin/pull/29823)

💬 fanquake commented on pull request "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492":
(https://github.com/bitcoin/bitcoin/pull/29823#issuecomment-2051675911)
> https://github.com/sipa/minisketch/pull/81 is now merged upstream.

This is now ready for review.

👍 dergoegge approved a pull request: "minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492"
(https://github.com/bitcoin/bitcoin/pull/29823#pullrequestreview-1996775007)
utACK 4722b7c7154e6130d4de66f7aed0fffe3c7c19a4

📝 paplorinc opened a pull request: "test: Validate transaction without inputs"
(https://github.com/bitcoin/bitcoin/pull/29862)
Based on https://maflcko.github.io/b-c-cov/test_bitcoin.coverage/src/consensus/tx_check.cpp.gcov.html empty inputs weren't covered by unit tests.
<img src="https://github.com/bitcoin/bitcoin/assets/1841944/5ba01c65-e4f3-4231-91f2-8793b903f8b5">

I have tried including the empty transaction into https://github.com/bitcoin/bitcoin/blob/master/src/test/data/tx_invalid.json#L34-L36, but it failed for another reason, so I added a separate test case for it in the end.
If this is a welcome change,
...

💬 case456 commented on issue "Errors in block header at FlatFilePos":
(https://github.com/bitcoin/bitcoin/issues/29861#issuecomment-2051742350)
Thank you

🤔 BrandonOdiwuor reviewed a pull request: "Add new "address type" column to the "receiving tab" address book page"
(https://github.com/bitcoin-core/gui/pull/753#pullrequestreview-1996981996)
Concept ACK

Nice solution adding the AddressType `column` and the `filter` by AddressType