💬 willcl-ark commented on issue "The BlockIndex/BlockMap should not live in memory *all the time*":
(https://github.com/bitcoin/bitcoin/issues/24760#issuecomment-2047817782)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.

Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554563937)
I think it is for [`if (m_offsets.size() < 5) return 0s;`](https://github.com/bitcoin/bitcoin/pull/29623/files#diff-a3d241f8a9033c5a4b88c7323f31c4b147800aae7479f38f127400461ff09a91R40)?

🤔 stickies-v reviewed a pull request: "Simplify network-adjusted time warning logic"
(https://github.com/bitcoin/bitcoin/pull/29623#pullrequestreview-1984476214)
Thank you very much @sr-gi @maflcko @vasild @glozow @mzumsande for your extensive review.

Force pushed to address all review comments:

in GUI: display the warning along with other warnings, instead of in a messagebox. This prevents the warning from https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252 (and is a nicer approach in general)
various nits around improved documentation, variable naming, references, help messages, ...
I probably won't be addressing nits in this P
...

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554567992)
It's wrapped in a `std::atomic` here which requires the chrono literal, doesn't compile otherwise:

```
net_processing.cpp:395:52: error: no matching constructor for initialization of 'std::atomic<std::chrono::seconds>' (aka 'atomic<duration<long long>>')
std::atomic<std::chrono::seconds> m_time_offset{0};
```

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554563217)
Thanks, I've updated the doc to `to make it harder for others to create false warnings about our clock being out of sync.`

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559370716)
Thanks, no longer relevant since the variable has been removed in latest push

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554629471)
I think I'd prefer to leave this as is, it's a well scoped mutex, performance impact should be negligible so keeping it concise makes sense I think.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559370971)
Thanks, no longer relevant since the variable has been removed in latest push

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554569003)
updated to `Don't use time offset samples`, thanks.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554568797)
Thanks, fixed.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559400091)
I've moved this change to `[net processing] Introduce PeerManagerInfo`

💬 willcl-ark commented on issue "Slow memory leak in v22.0?":
(https://github.com/bitcoin/bitcoin/issues/24542#issuecomment-2047825796)
Is this still a problem with v26.0 (or later)?

✅ willcl-ark closed an issue: "Adding a blocksonly option to addnode"
(https://github.com/bitcoin/bitcoin/issues/23763)

💬 willcl-ark commented on issue "Adding a blocksonly option to addnode":
(https://github.com/bitcoin/bitcoin/issues/23763#issuecomment-2047834198)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

If someone is interested in this feature they could pick up https://github.com/bitcoin/bitcoin/issues/24170

💬 0xB10C commented on pull request "security: restrict abis in bitcoind.service":
(https://github.com/bitcoin/bitcoin/pull/28340#issuecomment-2047834466)
ACK 0244416aacbad03e4ebe8f2c95c7861a318916ea

✅ willcl-ark closed an issue: "RPC: gettxoutsetinfo correctly flushes transactions to the coindb, but then does not return any RPC reply, and keeps running"
(https://github.com/bitcoin/bitcoin/issues/25912)

💬 willcl-ark commented on issue "RPC: gettxoutsetinfo correctly flushes transactions to the coindb, but then does not return any RPC reply, and keeps running":
(https://github.com/bitcoin/bitcoin/issues/25912#issuecomment-2047836598)
The problem does not seem to be easily reproducible.

Please open a new issue (or leave a comment in here if you want this re-opened) if you experience the problem again.

💬 willcl-ark commented on issue "importdescriptors hanging on importing/updating descriptor with large range":
(https://github.com/bitcoin/bitcoin/issues/25895#issuecomment-2047840620)
@furszy is this fixed in master?

💬 willcl-ark commented on issue "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist":
(https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-2047844159)
@ryanofsky are you working on this?

💬 fanquake commented on pull request "refactor: Simplify base32/64 padding calculations":
(https://github.com/bitcoin/bitcoin/pull/29847#issuecomment-2047855386)
```bash
Run base_encode_decode with args ['/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_seed_corpus/base_encode_decode')]INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 1375269970
INFO: Loaded 1 modules (578208 inline 8-bit counters): 578208 [0x55e843d75228, 0x55e843e024c8),
INFO: Loaded 1 PC tables (578208 PCs): 578208 [0x55e843e024c8,0x55e8446d4ec8),
INFO:
...