✅ willcl-ark closed an issue: "[RFC] Dealing with RPCs that have a lot of positional options"
(https://github.com/bitcoin/bitcoin/issues/22575)

✅ willcl-ark closed an issue: "ignored getblocktxn takes longer to detect than is possible"
(https://github.com/bitcoin/bitcoin/issues/22295)

💬 willcl-ark commented on issue "ignored getblocktxn takes longer to detect than is possible":
(https://github.com/bitcoin/bitcoin/issues/22295#issuecomment-2047804953)
We think this issue is now resolved, please feel free to comment here or open another issue if you disagree.

✅ willcl-ark closed an issue: "make keeps redoing some of the earlier done work."
(https://github.com/bitcoin/bitcoin/issues/22134)

💬 willcl-ark commented on issue "make keeps redoing some of the earlier done work.":
(https://github.com/bitcoin/bitcoin/issues/22134#issuecomment-2047808171)
There doesn't seem to be much interest in implementing this feature.

Please feel free to submit a pull request if this is something that you still want.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#issuecomment-2047810807)
Thank you very much @sr-gi @maflcko @vasild @glozow @mzumsande for your extensive review.

Force pushed to address all review comments:
- in GUI: display the warning along with other warnings, instead of in a messagebox. This prevents the warning from [blocking the `msghand` thread](https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252) (and is a nicer approach in general)
- various nits around improved documentation, variable naming, references, help messages, ...

I probab
...

✅ willcl-ark closed an issue: "The BlockIndex/BlockMap should not live in memory *all the time*"
(https://github.com/bitcoin/bitcoin/issues/24760)

💬 willcl-ark commented on issue "The BlockIndex/BlockMap should not live in memory *all the time*":
(https://github.com/bitcoin/bitcoin/issues/24760#issuecomment-2047817782)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.

Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554563937)
I think it is for [`if (m_offsets.size() < 5) return 0s;`](https://github.com/bitcoin/bitcoin/pull/29623/files#diff-a3d241f8a9033c5a4b88c7323f31c4b147800aae7479f38f127400461ff09a91R40)?

🤔 stickies-v reviewed a pull request: "Simplify network-adjusted time warning logic"
(https://github.com/bitcoin/bitcoin/pull/29623#pullrequestreview-1984476214)
Thank you very much @sr-gi @maflcko @vasild @glozow @mzumsande for your extensive review.

Force pushed to address all review comments:

in GUI: display the warning along with other warnings, instead of in a messagebox. This prevents the warning from https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252 (and is a nicer approach in general)
various nits around improved documentation, variable naming, references, help messages, ...
I probably won't be addressing nits in this P
...

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554567992)
It's wrapped in a `std::atomic` here which requires the chrono literal, doesn't compile otherwise:

```
net_processing.cpp:395:52: error: no matching constructor for initialization of 'std::atomic<std::chrono::seconds>' (aka 'atomic<duration<long long>>')
std::atomic<std::chrono::seconds> m_time_offset{0};
```

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554563217)
Thanks, I've updated the doc to `to make it harder for others to create false warnings about our clock being out of sync.`

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559370716)
Thanks, no longer relevant since the variable has been removed in latest push

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554629471)
I think I'd prefer to leave this as is, it's a well scoped mutex, performance impact should be negligible so keeping it concise makes sense I think.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559370971)
Thanks, no longer relevant since the variable has been removed in latest push

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554569003)
updated to `Don't use time offset samples`, thanks.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1554568797)
Thanks, fixed.

💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1559400091)
I've moved this change to `[net processing] Introduce PeerManagerInfo`

💬 willcl-ark commented on issue "Slow memory leak in v22.0?":
(https://github.com/bitcoin/bitcoin/issues/24542#issuecomment-2047825796)
Is this still a problem with v26.0 (or later)?

✅ willcl-ark closed an issue: "Adding a blocksonly option to addnode"
(https://github.com/bitcoin/bitcoin/issues/23763)