💬 0xB10C commented on issue "Discussion: Potential USDTs (User Static Defined Traces) for Core ":
(https://github.com/bitcoin/bitcoin/issues/20981#issuecomment-2047756417)
Can probably close this as there hasn't been much activity. Many of the tracepoints proposed here have been implemented in some form - other's haven't sparked enough interest.
(https://github.com/bitcoin/bitcoin/issues/20981#issuecomment-2047756417)
Can probably close this as there hasn't been much activity. Many of the tracepoints proposed here have been implemented in some form - other's haven't sparked enough interest.
💬 maflcko commented on issue "rpc: Wrong `gettransaction` info for a coinjoin":
(https://github.com/bitcoin/bitcoin/issues/14136#issuecomment-2047757278)
Yes, see https://github.com/bitcoin/bitcoin/pull/18919
(https://github.com/bitcoin/bitcoin/issues/14136#issuecomment-2047757278)
Yes, see https://github.com/bitcoin/bitcoin/pull/18919
✅ willcl-ark closed an issue: "Add RPC to set transaction comment"
(https://github.com/bitcoin/bitcoin/issues/12594)
(https://github.com/bitcoin/bitcoin/issues/12594)
💬 willcl-ark commented on issue "Add RPC to set transaction comment":
(https://github.com/bitcoin/bitcoin/issues/12594#issuecomment-2047760392)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.
Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.
(https://github.com/bitcoin/bitcoin/issues/12594#issuecomment-2047760392)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.
Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.
✅ willcl-ark closed an issue: "Misleading error/reject message: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)"
(https://github.com/bitcoin/bitcoin/issues/11891)
(https://github.com/bitcoin/bitcoin/issues/11891)
💬 willcl-ark commented on issue "Misleading error/reject message: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)":
(https://github.com/bitcoin/bitcoin/issues/11891#issuecomment-2047764658)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/issues/11891#issuecomment-2047764658)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
💬 willcl-ark commented on issue "Could the wallet count unconfirmed non-mempool change?":
(https://github.com/bitcoin/bitcoin/issues/11887#issuecomment-2047770240)
Related to private broadcast @vasild ?
(https://github.com/bitcoin/bitcoin/issues/11887#issuecomment-2047770240)
Related to private broadcast @vasild ?
💬 glozow commented on issue "policy: allow RBF descendant carveout whenever conflicts exist, not just when number of conflicts == 1":
(https://github.com/bitcoin/bitcoin/issues/16819#issuecomment-2047781108)
AFAIK, #27677 gets rid of RBF carveout / fixes this, as it instead calculates what the mempool would look like after removing the replacees and adding the new transaction(s)?
(https://github.com/bitcoin/bitcoin/issues/16819#issuecomment-2047781108)
AFAIK, #27677 gets rid of RBF carveout / fixes this, as it instead calculates what the mempool would look like after removing the replacees and adding the new transaction(s)?
✅ willcl-ark closed an issue: "depends: Evaluate potential improvements"
(https://github.com/bitcoin/bitcoin/issues/18821)
(https://github.com/bitcoin/bitcoin/issues/18821)
💬 willcl-ark commented on issue "depends: Evaluate potential improvements":
(https://github.com/bitcoin/bitcoin/issues/18821#issuecomment-2047798129)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/issues/18821#issuecomment-2047798129)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
✅ willcl-ark closed an issue: "Allow JSON RPC "batches" for multiwallet"
(https://github.com/bitcoin/bitcoin/issues/18715)
(https://github.com/bitcoin/bitcoin/issues/18715)
💬 willcl-ark commented on issue "Allow JSON RPC "batches" for multiwallet":
(https://github.com/bitcoin/bitcoin/issues/18715#issuecomment-2047800194)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
(https://github.com/bitcoin/bitcoin/issues/18715#issuecomment-2047800194)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.
Pull requests with improvements are always welcome.
✅ willcl-ark closed an issue: "[RFC] Dealing with RPCs that have a lot of positional options"
(https://github.com/bitcoin/bitcoin/issues/22575)
(https://github.com/bitcoin/bitcoin/issues/22575)
✅ willcl-ark closed an issue: "ignored getblocktxn takes longer to detect than is possible"
(https://github.com/bitcoin/bitcoin/issues/22295)
(https://github.com/bitcoin/bitcoin/issues/22295)
💬 willcl-ark commented on issue "ignored getblocktxn takes longer to detect than is possible":
(https://github.com/bitcoin/bitcoin/issues/22295#issuecomment-2047804953)
We think this issue is now resolved, please feel free to comment here or open another issue if you disagree.
(https://github.com/bitcoin/bitcoin/issues/22295#issuecomment-2047804953)
We think this issue is now resolved, please feel free to comment here or open another issue if you disagree.
✅ willcl-ark closed an issue: "make keeps redoing some of the earlier done work."
(https://github.com/bitcoin/bitcoin/issues/22134)
(https://github.com/bitcoin/bitcoin/issues/22134)
💬 willcl-ark commented on issue "make keeps redoing some of the earlier done work.":
(https://github.com/bitcoin/bitcoin/issues/22134#issuecomment-2047808171)
There doesn't seem to be much interest in implementing this feature.
Please feel free to submit a pull request if this is something that you still want.
(https://github.com/bitcoin/bitcoin/issues/22134#issuecomment-2047808171)
There doesn't seem to be much interest in implementing this feature.
Please feel free to submit a pull request if this is something that you still want.
💬 stickies-v commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#issuecomment-2047810807)
Thank you very much @sr-gi @maflcko @vasild @glozow @mzumsande for your extensive review.
Force pushed to address all review comments:
- in GUI: display the warning along with other warnings, instead of in a messagebox. This prevents the warning from [blocking the `msghand` thread](https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252) (and is a nicer approach in general)
- various nits around improved documentation, variable naming, references, help messages, ...
I probab
...
(https://github.com/bitcoin/bitcoin/pull/29623#issuecomment-2047810807)
Thank you very much @sr-gi @maflcko @vasild @glozow @mzumsande for your extensive review.
Force pushed to address all review comments:
- in GUI: display the warning along with other warnings, instead of in a messagebox. This prevents the warning from [blocking the `msghand` thread](https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252) (and is a nicer approach in general)
- various nits around improved documentation, variable naming, references, help messages, ...
I probab
...
✅ willcl-ark closed an issue: "The BlockIndex/BlockMap should not live in memory *all the time*"
(https://github.com/bitcoin/bitcoin/issues/24760)
(https://github.com/bitcoin/bitcoin/issues/24760)
💬 willcl-ark commented on issue "The BlockIndex/BlockMap should not live in memory *all the time*":
(https://github.com/bitcoin/bitcoin/issues/24760#issuecomment-2047817782)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.
Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.
(https://github.com/bitcoin/bitcoin/issues/24760#issuecomment-2047817782)
This issue hasn't had activity in a while and appears to have gone stale so I'm going to close it for now.
Feel free to open a new issue or comment here if you are still experiencing this problem so we can investigate further.