📝 stickies-v opened a pull request: "rpc: return warnings as an array instead of just a single one"
(https://github.com/bitcoin/bitcoin/pull/29845)
The RPC documentation for `getblockchaininfo`, `getmininginfo` and `getnetworkinfo` states that "warnings" returns "any network and blockchain warnings". In practice, only a single warning is returned.

Fix that by returning all warnings as an array.

As a side benefit, clean up the GetWarnings() logic.

Since this PR changes the RPC result schema, I've added release notes. Adding a `-deprecatedrpc` option for a change this simple seems overkill in my view and I'd rather not do, but I'm ha
...

🚀 fanquake merged a pull request: "depends: remove no longer needed patch for Boost::Process"
(https://github.com/bitcoin/bitcoin/pull/29844)

💬 maflcko commented on pull request "refactor, bench, fuzz: Drop unneeded `UCharCast` calls":
(https://github.com/bitcoin/bitcoin/pull/29820#issuecomment-2047172096)
Just for reference, the reason this is safe, is not because of the line linked to in the pull request description, but due to the existing `UCharCast` in the function. Error when trying to pass the wrong type:


```
./key.h:103:26: error: no matching function for call to 'UCharCast'
103 | } else if (Check(UCharCast(&pbegin[0]))) {
| ^~~~~~~~~
note: in instantiation of function template specialization 'CKey::Set<__gnu_cxx::__normal_iterator<int *, s
...

💬 0xB10C commented on pull request "tracing: Only prepare tracepoint arguments when actually tracing":
(https://github.com/bitcoin/bitcoin/pull/26593#discussion_r1559223172)
I remember trying a few combinations of this and in all cases the compiler/liker failed to find the semaphore. I just retried with the following patch which I think is similar to what you describe.

```patch
diff --git a/src/util/trace.h b/src/util/trace.h
index a4f0ea1ca4..8d7f6bdb74 100644
--- a/src/util/trace.h
+++ b/src/util/trace.h
@@ -27,8 +27,8 @@
// automatically incremented by tracing frameworks (bpftrace, bcc, libbpf, ...)
// upon attaching to the tracepoint and decremented
...

🤔 BrandonOdiwuor reviewed a pull request: "rpc: method removeprunedfunds should take an array of txids"
(https://github.com/bitcoin/bitcoin/pull/29468#pullrequestreview-1991364802)
Concept ACK

💬 fanquake commented on pull request "util/system: Close non-std fds when execing slave processes":
(https://github.com/bitcoin/bitcoin/pull/22417#issuecomment-2047265597)
What is the status of this now that Boost Process is removed (given that this currently adds Boost Process code)?

💬 maflcko commented on pull request "tracing: Only prepare tracepoint arguments when actually tracing":
(https://github.com/bitcoin/bitcoin/pull/26593#discussion_r1559292092)
Thanks for the explanation. I don't see another solution right now.

💬 ajtowns commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#discussion_r1557976175)
I guess the hash160 will better guarantee uniqueness, but a 40 character string is kind-of long? Would it make sense to use the 8 character `HexStr(Params().MessageStart())` value instead, special-casing for when the message start magic number matches the default signet's `0a03cf40`?

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1559309031)
nit in 0737f4ea62dd85fe7e8914bb82086a2628ae8204: Would be nice to add the error message to the commit message

📝 fanquake opened a pull request: "guix: replace GCC unaligned VMOV patch with binutils patch"
(https://github.com/bitcoin/bitcoin/pull/29846)
Rather than invasively patching GCC, given we have binutils 2.38 available, we can patch it to flip the default for
`-muse-unaligned-vector-move`.

A 1 line binutils patch, is much more maintainable than the ~300 line patch into GCC. It's also a slight inprovement in regards to patching out ualigned instructions in the release binaries. For comparison:
Master:
```bash
objdump -D bin/*.exe | rg "vmova|vmovdqa|vmovaps|vmovapd|vmovdqa64|vmovdqa32"
141b8be20: c5 f8 28 1a vmo
...

💬 glozow commented on pull request "p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#discussion_r1559354990)
Woops yes will fix

💬 torkelrogstad commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#issuecomment-2047432612)
It's a fair point to not want to introduce new instances of undesirable behavior. But I **definitely** don't think we should change existing behavior. That would break ALL users that use Go for interfacing with Bitcoin Core, and maybe other languages as well

📝 paplorinc opened a pull request: "refactor: Simplify base32/64 padding calculations"
(https://github.com/bitcoin/bitcoin/pull/29847)
Instead of modifying the string view by removing the suffixes manually, we trim the `ConvertBits` iteration instead by counting the trailing "=" chars.

Also added roundtrip tests for safety.

💬 willcl-ark commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#issuecomment-2047459040)
Will this close #28413 ?

📝 paplorinc converted_to_draft a pull request: "refactor: Simplify base32/64 padding calculations"
(https://github.com/bitcoin/bitcoin/pull/29847)
Instead of modifying the string view by removing the suffixes manually, we trim the `ConvertBits` iteration instead by counting the trailing "=" chars.

Also added roundtrip tests for safety.

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2047502844)
Concept ACK

💬 earonesty commented on pull request "Implement OP_CHECKTEMPLATEVERIFY":
(https://github.com/bitcoin/bitcoin/pull/29280#issuecomment-2047506633)
Lgtm. It's the simplest and least controversial and has an extremely broad use case set (not perfect for anything but useful for everything). No need to bikeshed if it's the best. It's useful and we need more useful things.

💬 RandyMcMillan commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2047513627)
Make sure this PR is based on a passing (CI) commit.

💬 epompeii commented on issue "Continuous benchmark tracking":
(https://github.com/bitcoin/bitcoin/issues/27284#issuecomment-2047551283)
> A sample dashboard is [here](https://bencher.dev/console/projects/0xb10c-s-bitcoin-core/perf?key=true&reports_per_page=4&branches_per_page=8&testbeds_per_page=8&benchmarks_per_page=8&reports_page=1&branches_page=1&testbeds_page=1&benchmarks_page=1&report=915c1007-33dd-4d30-b9c1-531b60af8a06&branches=0ab6caf7-716b-4a6e-8101-f2b9c891a9a2&testbeds=3c0c4d9d-b40e-4d9a-a462-2379355b0785&benchmarks=993b5444-b391-43dd-a4c1-c157cb1d7209%2Cb5ce5b17-6755-449b-b205-b843a0252344%2Cd1b7da67-b22c-4d30-b946-b
...

✅ achow101 closed an issue: "Can't version 26.1 export Bech32 address private key?"
(https://github.com/bitcoin/bitcoin/issues/29836)