💬 achow101 commented on pull request "test: Add algo assert to bnb_search_test":
(https://github.com/bitcoin/bitcoin/pull/29206#issuecomment-2045470105)
This PR does not seem to have conceptual support.

💬 maflcko commented on pull request "ci: run test_bitcoin with DEBUG_LOG_OUT in RUN_UNIT_TESTS_SEQUENTIAL":
(https://github.com/bitcoin/bitcoin/pull/28736#issuecomment-2045476738)
To add some context. I think it would be nice to print the seed. However, the changes here had to be pushed five times, because the bash code was wrong, and the current version passes CI, but it is unclear if the bash code is correct.

For example, it seems better to fail CI on a test failure and not print the seed, than to print the seed and not fail the CI on a test failure.

✅ achow101 closed a pull request: "Make (Read/Write)BinaryFile work with char vector, use AutoFile"
(https://github.com/bitcoin/bitcoin/pull/29229)

💬 achow101 commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#issuecomment-2045487138)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

💬 maflcko commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#issuecomment-2045506214)
Does it make sense to treat it case insensitive?

It hasn't been treated that way, so it would be better to fix the docs?

Also, it seems better to be strict when parsing input, as opposed to loosely accepting different values?

💬 laanwj commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#issuecomment-2045515081)
Concept NACK. i think the solution here is to update the documentation. AFAIK, none of our RPC APIs have historically been case insensitive, and i don't think there's a good reason to start here. Ideally, imo, commands and field names should be considered "just blobs", not subject to unicode casing rules.

💬 achow101 commented on pull request "util: check for errors after close and read in AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29307#issuecomment-2045516340)
Seems like there is some discussion in the description that is a better fit for a brainstorming issue.

✅ achow101 closed a pull request: "rpc: Add script verification flags to getdeploymentinfo"
(https://github.com/bitcoin/bitcoin/pull/28806)

💬 achow101 commented on pull request "rpc: Add script verification flags to getdeploymentinfo":
(https://github.com/bitcoin/bitcoin/pull/28806#issuecomment-2045521331)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

💬 achow101 commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#issuecomment-2045528359)
> This is very closely based on [test/functional/wallet_multisig_descriptor_psbt.py](https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_multisig_descriptor_psbt.py) both in code and concept.

Can you articulate what meaningful difference there is?

✅ achow101 closed a pull request: "Enable HW-accelerated implementations of SHA256 for MSVC builds"
(https://github.com/bitcoin/bitcoin/pull/24773)

💬 achow101 commented on pull request "Enable HW-accelerated implementations of SHA256 for MSVC builds":
(https://github.com/bitcoin/bitcoin/pull/24773#issuecomment-2045541193)
Deferring to after cmake

💬 Zhouziheng3188 commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045543159)
> 参考号[#26046（评论）](https://github.com/bitcoin/bitcoin/issues/26046#issuecomment-1293842474)

谢谢，看了下解决方案，好像只有换版本，不过不知道卸载现在的版本，换一个旧版本的bitcoin core，是不是又要重新同步区块，实在太费事了。之前也是有现成的区块数据，但还是同步了1天多的时间。

✅ achow101 closed a pull request: "refactor: Remove excess reserve() call for SecureString"
(https://github.com/bitcoin/bitcoin/pull/29364)

💬 achow101 commented on pull request "refactor: Remove excess reserve() call for SecureString":
(https://github.com/bitcoin/bitcoin/pull/29364#issuecomment-2045543741)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

💬 maflcko commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045550220)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

💬 laanwj commented on pull request "refactor, bench, fuzz: Drop unneeded `UCharCast` calls":
(https://github.com/bitcoin/bitcoin/pull/29820#issuecomment-2045550809)
Seems fine, code review ACK 56e1e5dd10cbe51d3abc3fbf532b6b41bf62a889

💬 achow101 commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2045554895)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed a pull request: "Add Signet launch shortcut for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334)

✅ achow101 closed a pull request: "ParseHDKeypath: support h as hardened marker"
(https://github.com/bitcoin/bitcoin/pull/28192)