💬 achow101 commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2045401277)
Will split this up

💬 theStack commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#issuecomment-2045403274)
This PR is based on https://github.com/bitcoin/bitcoin/pull/29735 now in order to take use of the `fill_mempool` (see https://github.com/bitcoin/bitcoin/pull/29827#discussion_r1555420823). Note that I had issues with this helper due to `tx_to_be_evicted` not being evicted (failed assertion `assert tx_to_be_evicted_id not in node.getrawmempool()`), as the mempool filling txs spent that newly created coin again; fixed by the first commit.

💬 ismaelsadeeq commented on issue "Wallet: Nondescript error message for 502nd unconfirmed transaction":
(https://github.com/bitcoin/bitcoin/issues/29711#issuecomment-2045403310)
Currently, if you have more than 500 independent unconfirmed transactions, the wallet prevent users from creating a transaction with an unconfirmed input to prevent some DOS vector.

The limit is set by the `CTxMempool::GatherClusters` method, which was added with the introduction of the mini miner and package-aware funding to prevent the calculation of clusters containing 500 or more unconfirmed transactions in #27021.


I’ve bisected, and this issue does not occur on ab42b2ebdbf61225e636e
...

💬 laanwj commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045406134)
> One possibility is just taking the asm generated by clang 14 and including that as asm blocks in the C++ code?

In general i really dislike the idea of copy/pasting assembly output from a compiler into the source code. It's already hard enough to review human-generated asm code but at least you can ask the author about the reasoning how and why. In the case of compiler output, well, it'd be a matter of waiting for gcc to improve :slightly_smiling_face:

💬 darosior commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#issuecomment-2045410857)
This has not seen any activity for a while. It's depending on https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-1860221553, which i unfortunately do not plan on implementing right now. If you do i'm happy to review, but in the meantime i think this PR can be closed and potentially re-opened once the performance of the satisfier is reasonable.

✅ achow101 closed a pull request: "test: verify spend from 999-of-999 taproot multisig wallet"
(https://github.com/bitcoin/bitcoin/pull/28212)

💬 maflcko commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045416111)
Removing "up for grabs" for now. I don't think anyone will review asm, regardless of where it came from? If there are reviewers who would review it, they should speak up first, no?

💬 0xB10C commented on pull request "include verbose debug messages in testmempoolaccept reject-reason":
(https://github.com/bitcoin/bitcoin/pull/28121#issuecomment-2045421741)
I have a slight preference to keep the `reject-reason` string as is, but like the idea of having more information on rejections. In https://github.com/0xB10C/find-non-standard-tx and for https://bitcoin-data.github.io/non-standard-transactions/ I use the short `reject-reason`.

🚀 fanquake merged a pull request: "build: Change MAC_OSX macro to __APPLE__ in crypto"
(https://github.com/bitcoin/bitcoin/pull/29834)

💬 paplorinc commented on pull request "build: replace custom `MAC_OSX` macro with standard `__APPLE__` for consistent macOS detection":
(https://github.com/bitcoin/bitcoin/pull/29450#issuecomment-2045432305)
Rebased after the https://github.com/bitcoin/bitcoin/pull/29834 merge, please let me know what to change or verify here.

💬 laanwj commented on pull request "doc: i2p: improve `-i2pacceptincoming` mention":
(https://github.com/bitcoin/bitcoin/pull/29813#issuecomment-2045437330)
This documentation change is correct and makes the documentation slightly shorter, thus easier to read. ACK 2179e2c3209a41c1419f1f5ed6270a0dad68b50d

✅ darosior closed a pull request: "Detect and ignore transactions that were CPFP'd in the fee estimator"
(https://github.com/bitcoin/bitcoin/pull/25380)

💬 darosior commented on pull request "Detect and ignore transactions that were CPFP'd in the fee estimator":
(https://github.com/bitcoin/bitcoin/pull/25380#issuecomment-2045438531)
Let's face it: looks like i'm not getting back to this. I think it's still a bit concerning, but hey i'm focused on other things right now and other people are looking at fee estimation. Let's mark this as up for brags.

> Let not the weight of past deeds anchor your steps; the investments of yesterday should not dictate the journey of today. For wisdom lies in moving forward, guided by the present's light, not shackled by the shadows of sunk costs.

Inspired by @willcl-ark

💬 darosior commented on pull request "Detect and ignore transactions that were CPFP'd in the fee estimator":
(https://github.com/bitcoin/bitcoin/pull/25380#issuecomment-2045439490)
@ismaelsadeeq you may be interested in picking this up.

💬 Zhouziheng3188 commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045442571)
> 此命令仅支持旧版钱包。`listdescriptors`对你有用吗？
这个命令不是列出描述符的吗？ 此命令有用，但是返回的结果，并没有包含私钥的字段嘛。

🤔 maflcko reviewed a pull request: "sync: introduce a thread-safe generic container and use it to remove a bunch of "GlobalMutex"es"
(https://github.com/bitcoin/bitcoin/pull/25390#pullrequestreview-1989367912)
Are there any examples from the last couple of years where this would have helped to prevent a bug or other issue?

💬 laanwj commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045454153)
To be clear, I'm happy to review asm if there's 1) a very clear performance win in an important part of the code 2) it's human-written and well commented 3) it's only small and relatively straightforward, self-contained operations.
With how good compilers are nowadays it should be rare, though. With new instruction sets it's generally better to use intrinsics instead of direct inline assembly.

💬 achow101 commented on pull request "RPC/Wallet: Convert walletprocesspsbt to use options parameter":
(https://github.com/bitcoin/bitcoin/pull/24963#issuecomment-2045457878)
Are you still working on this?

🤔 glozow reviewed a pull request: "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure"
(https://github.com/bitcoin/bitcoin/pull/29735#pullrequestreview-1989374685)
reACK 4ba1d0b55339c3ea90e2bcd64662a06f0f90dd46

💬 maflcko commented on issue "Can't version 26.1 export Bech32 address private key?":
(https://github.com/bitcoin/bitcoin/issues/29836#issuecomment-2045468085)
Ref https://github.com/bitcoin/bitcoin/issues/26046#issuecomment-1293842474