💬 maflcko commented on pull request "build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29494#issuecomment-2045134493)
rebased

💬 maflcko commented on issue "valgrind: Conditional jump or move depends on uninitialised value(s)":
(https://github.com/bitcoin/bitcoin/issues/29635#issuecomment-2045231903)
https://bugs.kde.org/show_bug.cgi?id=485276

💬 real-or-random commented on issue "Fuzzer enhancement: Explicitly check output for uninitialized memory":
(https://github.com/bitcoin/bitcoin/issues/22064#issuecomment-2045244702)
> Alternative solution that also works with Valgrind: write the data to `/dev/null`:

There's also `VALGRIND_CHECK_MEM_IS_DEFINED`, see also https://github.com/bitcoin-core/secp256k1/blob/master/src/checkmem.h for an abstraction layer that works with both MSan and Valgrind.


---

What's suggested in this issue, i.e., reporting every read of an uninitialized value, may just be too much. The [Valgrind FAQ](https://valgrind.org/docs/manual/faq.html#faq.undeferrors) says this:
> As for eage
...

💬 theuni commented on pull request "[WIP] libevent @ master + use CMake":
(https://github.com/bitcoin/bitcoin/pull/29835#issuecomment-2045257973)
I'm confused about this error. sigaddset should come from `<signal.h>`, which is included from `"evsignal-internal.h"`.

💬 stratospher commented on pull request "test: Extends wait_for_getheaders so a specific block hash can be checked":
(https://github.com/bitcoin/bitcoin/pull/29736#discussion_r1557701025)
inserting an `assert "getheaders" not in p.last_message` fails here because it received a new header after those checks. and the block hash doesn't change here.

💬 stratospher commented on pull request "test: Extends wait_for_getheaders so a specific block hash can be checked":
(https://github.com/bitcoin/bitcoin/pull/29736#discussion_r1557701131)
oh good point.

✅ achow101 closed a pull request: "Bugfix: configure: Correct check for fuzz binary needing a main function"
(https://github.com/bitcoin/bitcoin/pull/28564)

✅ achow101 closed a pull request: "Bugfix: Package relay / bytespersigop checks"
(https://github.com/bitcoin/bitcoin/pull/28345)

💬 achow101 commented on pull request "Bugfix: Package relay / bytespersigop checks":
(https://github.com/bitcoin/bitcoin/pull/28345#issuecomment-2045293951)
Closing as up for grabs due to lack of activity.

✅ achow101 closed a pull request: "net: Add new permission `forceinbound` to evict a random unprotected connection if all slots are otherwise full"
(https://github.com/bitcoin/bitcoin/pull/27600)

💬 pinheadmz commented on issue "whiteconnections should be re-added":
(https://github.com/bitcoin/bitcoin/issues/8798#issuecomment-2045309981)
Proposed alternative to #27600 is a setting such that bitcoind listens for inbound connections but does not advertise itself

💬 achow101 commented on pull request "Safegcd-based modular inverses in MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/21590#issuecomment-2045311564)
Are you still working on this?

💬 achow101 commented on pull request "RPC: add new `listmempooltransactions`":
(https://github.com/bitcoin/bitcoin/pull/29016#issuecomment-2045315768)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes"
(https://github.com/bitcoin/bitcoin/pull/29050)
Implementation of OP_TXHASH and OP_CHECKTXHASHVERIFY, as per the [draft BIP](https://github.com/bitcoin/bips/pull/1500).

This MR includes a test using the test vectors generated from the reference implementation in the BIP.
The implementation utilizes a caching strategy that hopefully alleviates concerns around resource usage like quadratic hashing.

This MR on purpose does not make any consensus changes yet. Activation of the proposed opcodes will be coordinated in an independent MR, prob
...

💬 achow101 commented on pull request "Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes":
(https://github.com/bitcoin/bitcoin/pull/29050#issuecomment-2045322740)
Seems like this should be a draft

📝 achow101 converted_to_draft a pull request: "indexes: Stop using node internal types and locking cs_main, improve sync logic"
(https://github.com/bitcoin/bitcoin/pull/24230)
This PR lets indexing code mostly run outside of the node process. It also improves indexing sync logic, which is moved out of indexing code to a new [`node::SyncChain()`](https://github.com/ryanofsky/bitcoin/blob/8d8cdcb37005030f646ba3c45f7f54f556efb8bf/src/node/chain.h#L24-L39) function.

Almost all the commits in this PR are small refactoring changes that move code from `src/index/` to `src/node/`, or replace references to node types like `CBlockIndex`, `CChain`, `CChainState` in index code
...

✅ achow101 closed a pull request: "contrib/init: (OpenRC) use -daemonwait to wait for startup completion"
(https://github.com/bitcoin/bitcoin/pull/24066)

💬 achow101 commented on pull request "contrib/init: (OpenRC) use -daemonwait to wait for startup completion":
(https://github.com/bitcoin/bitcoin/pull/24066#issuecomment-2045334717)
> Are we just going to concede that the problem is unsolvable?

This PR does not seem to have conceptual support.

✅ achow101 closed a pull request: "net: call getaddrinfo() in detachable thread to prevent stalling"
(https://github.com/bitcoin/bitcoin/pull/27557)

✅ achow101 closed a pull request: "wallet: add `seeds` argument to `importdescriptors`"
(https://github.com/bitcoin/bitcoin/pull/27351)