💬 fjahr commented on pull request "[DO NOT MERGE] testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2041139129)
Pushed some improvements and addressed some feedback. I am experimenting with some of the proposals from the mailing list and so I added Andres Poelstra's suggested difficulty adjustment with 6h/1M from here: https://groups.google.com/g/bitcoindev/c/9bL00vRj7OU/m/kFPaQCzmBwAJ

> Probably we should support tracking both testnet3 and the new testnet4 for some time. Making the new code conditional on a different chain param that's only set for testnet4 would probably be the easiest way of accompl
...

💬 itornaza commented on pull request "test: Bump timeouts in feature_index_prune and wallet_importdescriptors":
(https://github.com/bitcoin/bitcoin/pull/29791#issuecomment-2041145104)
@cbergqvist I re-run today the `test/functional/test_runner.py --jobs=16 --extended` two times on the **PR branch** after cleaning up everything and building the branch again. I include the log files for each of the errors. I will happily assist you witht this since my current goal is to build up confidence in running the test with confidence!

## First run

```
wallet_importdescriptors.py --descriptors | ✖ Failed | 139 s
wallet_transactiontime_rescan.py --legacy-wallet
...

📝 fanquake opened a pull request: "minisketch: pull subtree + #81"
(https://github.com/bitcoin/bitcoin/pull/29823)
Will fix #29799.

💬 hebasto commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2041149616)
Tested 8d2622f96f7bd25a4ab9c667bd00f374cfcc15a6.

The CI script `ci/test/00_setup_env_native_valgrind.sh` fail locally:
```
wallet/walletdb.cpp:1431:15: error: code will never be executed [-Werror,-Wunreachable-code]
error = Untranslated(strprintf("Failed to open database path '%s'. Build does not support Berkeley DB database format.", fs::PathToString(path)));
^
wallet/walletdb.cpp:1426:19: note: silence by adding parentheses to mark code as explicitly dead
if
...

🤔 mzumsande reviewed a pull request: "Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us"
(https://github.com/bitcoin/bitcoin/pull/29691#pullrequestreview-1984593465)
ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

I did a quick check that it returns valid addresses under the new domain.

💬 fanquake commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2041151668)
> The CI script ci/test/00_setup_env_native_valgrind.sh fail locally:

That is a bug in Clang 14. Fixed in 15.

💬 itornaza commented on pull request "test: Bump timeouts in feature_index_prune and wallet_importdescriptors":
(https://github.com/bitcoin/bitcoin/pull/29791#issuecomment-2041159007)
Out of frustration I took slightly different approach and run the functional tests with the support of a big enough ramdisk of 12 GiB inspired by the PR #29335 that was meant for a completely different use case.

Not only all the extended tests pass with 16 jobs and even 64 jobs but a 2x speed up is achieved down to 572 seconds.

My box has 96 GiB of unified memory so there is clearly some operating systems specifics that make the discussed tests to fail. Under the much smaller but more co
...

👍 fanquake approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984597766)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

💬 AngusP commented on pull request "refactor: Use typesafe Wtxid in compact block encodings":
(https://github.com/bitcoin/bitcoin/pull/29752#discussion_r1554652371)
Addressed in a8203e94123b6ea6e4f4a6320e3ad20457f44a28

👍 TheCharlatan approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984602991)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

👍 theStack approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984605046)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

As a historical side-note, it seems like this function was first introduced for OpenSSH (managed in the OpenBSD tree) in 2010, with the name `timing_safe_cmp` back then: https://github.com/openbsd/src/commit/8488487f0974f365bb51defabda91a3e5dcdfaa6#diff-1baa12ad01bad68b45e89594ef3309ad070f9848f764f976e08c435ade846ae5R833

👍 fanquake approved a pull request: "Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us"
(https://github.com/bitcoin/bitcoin/pull/29691#pullrequestreview-1984605052)
ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

> Someone, possibly you, should also make a PR to update it here:

I don't see why the person making the PR there matters; it's only copying what is in `kernel/chainparams`. Opened one for recent changes: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/160

🚀 fanquake merged a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815)

💬 willcl-ark commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#issuecomment-2041180725)
Concept ACK.

IIUC this would not quite be enough to close down #9530 as it would not permit a header building on top of an invalid block with a valid header, as proposed there. Perhaps what is proposed here is superior though and ce238dd79bd3a1190a2229fac4502fa5742fc6e3 is enough to close that issue out if this goes in?

✅ willcl-ark closed an issue: "p2p sends local-scope addresses when IPv4 is behind NAT"
(https://github.com/bitcoin/bitcoin/issues/8616)

💬 willcl-ark commented on issue "p2p sends local-scope addresses when IPv4 is behind NAT":
(https://github.com/bitcoin/bitcoin/issues/8616#issuecomment-2041181753)
Closing as fixed based on prior comments from vasild.

💬 naiyoma commented on pull request "test: refactor: introduce and use `calculate_input_weight` helper":
(https://github.com/bitcoin/bitcoin/pull/29777#issuecomment-2041202409)
tACK https://github.com/bitcoin/bitcoin/pull/29777/commits/f81fad5e0f3be1f7aed59f9da00396c75c2a6406
I have tested both call sites for the helper function locally (`test/functional/wallet_send.py` and `test/functional/rpc_psbt.py`) — tests run ok.

👍 brunoerg approved a pull request: "test: remove immediate tx relay workaround in wallet_groups.py"
(https://github.com/bitcoin/bitcoin/pull/29822#pullrequestreview-1984702902)
utACK 93fae5ae7c31fa1b1095770f00adeac1cfeda4b9

🤔 glozow reviewed a pull request: "refactor: Use typesafe Wtxid in compact block encodings"
(https://github.com/bitcoin/bitcoin/pull/29752#pullrequestreview-1984703578)
ACK a8203e94123b6ea6e4f4a6320e3ad20457f44a28

⚠️ tadhaQ-nerfed-5misbu opened an issue: "Gate.io"
(https://github.com/bitcoin/bitcoin/issues/29826)