👍 BrandonOdiwuor approved a pull request: "assumeutxo: Fix -reindex before snapshot was validated"
(https://github.com/bitcoin/bitcoin/pull/29726#pullrequestreview-1984575158)
re-ACK b7ba60f81a33db876f88b5f9af1e5025d679b5be

🤔 BrandonOdiwuor reviewed a pull request: "test: Refactor fee calculation to remove satoshi_round function"
(https://github.com/bitcoin/bitcoin/pull/29566#pullrequestreview-1984578430)
Concept ACK moving from `float` to `Decimal`

📝 theStack opened a pull request: "test: remove immediate tx relay workaround in wallet_groups.py"
(https://github.com/bitcoin/bitcoin/pull/29822)
Reverts commit ab4efad51b9ba276ffeb6871931e13772493f7cc (PR #26970). This workaround is not needed anymore, as since #27114 the test sets the noban permission for both in- and outbound connections via the `noban_tx_relay` setting, and we don't have to rely on this topology hack anymore. See commit c985eb854cc86deb747caea5283c17cf51b6a983 (kudos to brunoerg!).

Can be tested by executing `$ time ./test/functional/wallet_groups.py` both on master and PR and verifying that the execution time is r
...

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1554638887)
Thanks! Removed.

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2041136905)
The branch has been reworked to address @maflcko's comments.

> ... but bool return value + exceptions doesn't make sense, does it?

Whether [`std::istream::read()`](https://en.cppreference.com/w/cpp/io/basic_istream/read) throw or not depends on how [`exceptions()`](https://en.cppreference.com/w/cpp/io/basic_ios/exceptions) is set. The suggested code does not use exceptions.

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1554639703)
Thanks! [Reworked](https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2041136905).

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1554639779)
[Reworked](https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2041136905).

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1554639810)
[Reworked](https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2041136905).

💬 fanquake commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1554640585)
I don't really think we want a reversion here (or in addition), and if we were reverting shouldn't the `__GNUC__` case go away?

In any case, I'd rather we just not define this for MSVC.

💬 fjahr commented on pull request "[DO NOT MERGE] testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2041139129)
Pushed some improvements and addressed some feedback. I am experimenting with some of the proposals from the mailing list and so I added Andres Poelstra's suggested difficulty adjustment with 6h/1M from here: https://groups.google.com/g/bitcoindev/c/9bL00vRj7OU/m/kFPaQCzmBwAJ

> Probably we should support tracking both testnet3 and the new testnet4 for some time. Making the new code conditional on a different chain param that's only set for testnet4 would probably be the easiest way of accompl
...

💬 itornaza commented on pull request "test: Bump timeouts in feature_index_prune and wallet_importdescriptors":
(https://github.com/bitcoin/bitcoin/pull/29791#issuecomment-2041145104)
@cbergqvist I re-run today the `test/functional/test_runner.py --jobs=16 --extended` two times on the **PR branch** after cleaning up everything and building the branch again. I include the log files for each of the errors. I will happily assist you witht this since my current goal is to build up confidence in running the test with confidence!

## First run

```
wallet_importdescriptors.py --descriptors | ✖ Failed | 139 s
wallet_transactiontime_rescan.py --legacy-wallet
...

📝 fanquake opened a pull request: "minisketch: pull subtree + #81"
(https://github.com/bitcoin/bitcoin/pull/29823)
Will fix #29799.

💬 hebasto commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2041149616)
Tested 8d2622f96f7bd25a4ab9c667bd00f374cfcc15a6.

The CI script `ci/test/00_setup_env_native_valgrind.sh` fail locally:
```
wallet/walletdb.cpp:1431:15: error: code will never be executed [-Werror,-Wunreachable-code]
error = Untranslated(strprintf("Failed to open database path '%s'. Build does not support Berkeley DB database format.", fs::PathToString(path)));
^
wallet/walletdb.cpp:1426:19: note: silence by adding parentheses to mark code as explicitly dead
if
...

🤔 mzumsande reviewed a pull request: "Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us"
(https://github.com/bitcoin/bitcoin/pull/29691#pullrequestreview-1984593465)
ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

I did a quick check that it returns valid addresses under the new domain.

💬 fanquake commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2041151668)
> The CI script ci/test/00_setup_env_native_valgrind.sh fail locally:

That is a bug in Clang 14. Fixed in 15.

💬 itornaza commented on pull request "test: Bump timeouts in feature_index_prune and wallet_importdescriptors":
(https://github.com/bitcoin/bitcoin/pull/29791#issuecomment-2041159007)
Out of frustration I took slightly different approach and run the functional tests with the support of a big enough ramdisk of 12 GiB inspired by the PR #29335 that was meant for a completely different use case.

Not only all the extended tests pass with 16 jobs and even 64 jobs but a 2x speed up is achieved down to 572 seconds.

My box has 96 GiB of unified memory so there is clearly some operating systems specifics that make the discussed tests to fail. Under the much smaller but more co
...

👍 fanquake approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984597766)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

💬 AngusP commented on pull request "refactor: Use typesafe Wtxid in compact block encodings":
(https://github.com/bitcoin/bitcoin/pull/29752#discussion_r1554652371)
Addressed in a8203e94123b6ea6e4f4a6320e3ad20457f44a28

👍 TheCharlatan approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984602991)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

👍 theStack approved a pull request: "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's"
(https://github.com/bitcoin/bitcoin/pull/29815#pullrequestreview-1984605046)
ACK 2d1819455cb4c516f6cdf81c11e869a23dee3e6b

As a historical side-note, it seems like this function was first introduced for OpenSSH (managed in the OpenBSD tree) in 2010, with the name `timing_safe_cmp` back then: https://github.com/openbsd/src/commit/8488487f0974f365bb51defabda91a3e5dcdfaa6#diff-1baa12ad01bad68b45e89594ef3309ad070f9848f764f976e08c435ade846ae5R833