👍 TheCharlatan approved a pull request: "clang-tidy: Enable misc-no-recursion"
(https://github.com/bitcoin/bitcoin/pull/29690#pullrequestreview-1984165501)
ACK d9536e6e423ef7384a1869f3ac8a9cf7f503ed6f

👋 TheCharlatan's pull request is ready for review: "kernel: De-globalize fReindex"
(https://github.com/bitcoin/bitcoin/pull/29817)

💬 sipsorcery commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2040660307)
> I believe this is unrelated to this PR, see #29051. `make clean` and rebuilding should fix it.

I'm on Windows and using msvc but I did do a clean build but it didn't help.

I suspect it's down to msvc being less forgiving than gcc, probably due to a recent msvc change although I couldn't find anything in the release notes.

Apolgies for dumping a screenshot but it does show a succinct summary of the issue. This is from an attempt to compile (no linking involved) the single blockfilter_t
...

💬 sipsorcery commented on pull request "build, bench, msvc: Add missing benchmarks":
(https://github.com/bitcoin/bitcoin/pull/29773#issuecomment-2040668052)
@hebasto only guessing but I've always found Windows fairly average at releasing file and socket handles. Maybe that's the cause of the test failure rather than anything code related.

In my other life I work with SIP (telecoms protocol) with lots of socket handles flying around. If it's only for testing then I generally just add a 5 second wait and try again for handle in use errors.

💬 EthanHeilman commented on pull request "Several randomness improvements":
(https://github.com/bitcoin/bitcoin/pull/29625#issuecomment-2040694615)
@sipa I plan to do a review of this next week

💬 theStack commented on pull request "crypto: chacha20: always use our fallback timingsafe_bcmp rather than libc's":
(https://github.com/bitcoin/bitcoin/pull/29815#issuecomment-2040826135)
Concept ACK

💬 fanquake commented on pull request "Update libsecp256k1 subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/29803#issuecomment-2041018396)
Guix Build (x86_64):
```bash
6fc6f674442384b91a0cf4468b6f8d956c3afdf59aaf83209f3d40a679a9e1d1 guix-build-4654cc32248d/output/aarch64-linux-gnu/SHA256SUMS.part
61138eb29efab5cc44045c2e9d5eae2fda2fc6f476239a667e592b8495fcd912 guix-build-4654cc32248d/output/aarch64-linux-gnu/bitcoin-4654cc32248d-aarch64-linux-gnu-debug.tar.gz
b7c534363dbf7d2e9984a17f66d5535a884ced3d94cb93d63aa59dd2f15e3874 guix-build-4654cc32248d/output/aarch64-linux-gnu/bitcoin-4654cc32248d-aarch64-linux-gnu.tar.gz
8a8a81f
...

🚀 fanquake merged a pull request: "Update libsecp256k1 subtree to latest master"
(https://github.com/bitcoin/bitcoin/pull/29803)

👋 fanquake's pull request is ready for review: "ci: remove --with-asm=no (secp256k1) from MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/29742)

💬 fanquake commented on pull request "ci: remove --with-asm=no (secp256k1) from MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/29742#issuecomment-2041020150)
Opened https://github.com/google/oss-fuzz/pull/11785 for oss-fuzz.

Also cc @jonasnick.

📝 fanquake converted_to_draft a pull request: "depends: swap some cctools tools for LLVM tools"
(https://github.com/bitcoin/bitcoin/pull/29739)
These tools are used in GUI packaging on macOS, and also somewhat of a blocker for #21778. The main issue is that some distros don't really ship these tools in a standard ways, i.e Ubuntu only ships `llvm-otool` with a version suffix, i.e `llvm-otool-17`, which makes it hard to find and use. Rather than trying to deal with that mess, switch to using the equivalent LLVM counterparts:
`otool` ->`llvm-objdump`
`install_name_tool` ->` llvm-install-name-tool`

`install-name-tool` might still be a
...

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1554559178)
removed the parenthesis

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1554559185)
taken

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1554559188)
replaced with an assert

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1554559201)
felt like I had a reason for this, but apparently not. At end of test I empty mempool on node restart, so removed

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1554559207)
changed where it's non-empty, so added `persistmempool=0` and left a new comment

👍 hebasto approved a pull request: "ci: remove --with-asm=no (secp256k1) from MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/29742#pullrequestreview-1984485835)
ACK 61641e2466768e128fef995e9fcb24cad90e527d.

💬 hebasto commented on issue "`WalletCreate{Encrypted/Plain}` benchmark crash on Windows":
(https://github.com/bitcoin/bitcoin/issues/29816#issuecomment-2041062049)
It seems the same issue as I [noticed](https://github.com/bitcoin/bitcoin/pull/29773#issuecomment-2028619063) in https://github.com/bitcoin/bitcoin/pull/29773.

From @sipsorcery's [comment](https://github.com/bitcoin/bitcoin/pull/29773#issuecomment-2040668052):
> only guessing but I've always found Windows fairly average at releasing file and socket handles. Maybe that's the cause of the test failure rather than anything code related.
>
> In my other life I work with SIP (telecoms protocol)
...

💬 hebasto commented on issue "`WalletCreate{Encrypted/Plain}` benchmark crash on Windows":
(https://github.com/bitcoin/bitcoin/issues/29816#issuecomment-2041066607)
I wonder if SQLite bothers to call [`CloseHandle()`](https://learn.microsoft.com/en-us/windows/win32/api/handleapi/nf-handleapi-closehandle) on Windows?

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#issuecomment-2041067714)
@sipsorcery
> I'm on Windows and using msvc but I did do a clean build but it didn't help.

What VS / MSVC versions do you use?