⚠️ achow101 unpinned an issue: "Gathering Priorities of 28.0"
(https://github.com/bitcoin/bitcoin/issues/29439)
Please nominate projects that you are the champion of that could become priorities for the next ~6 months (until the 28.0 release). We (frequent contributors) will vote on which projects will be priorities next week in a separate issue.
There were concerns in the voting of previous priority projects that some projects nominated did not have champions who were willing to have their project be a priority project. To ensure that all nominated projects have champions who want their project to be
...
(https://github.com/bitcoin/bitcoin/issues/29439)
Please nominate projects that you are the champion of that could become priorities for the next ~6 months (until the 28.0 release). We (frequent contributors) will vote on which projects will be priorities next week in a separate issue.
There were concerns in the voting of previous priority projects that some projects nominated did not have champions who were willing to have their project be a priority project. To ensure that all nominated projects have champions who want their project to be
...
⚠️ achow101 pinned an issue: "Voting on Priority Projects for 28.0"
(https://github.com/bitcoin/bitcoin/issues/29465)
Please leave your votes for project priorities for the next ~6 months (until the 28.0 feature freeze).
Project priorities are those which the frequent contributors to this project have voted on to have more focused review on until the next feature freeze (or until they are completed). They will become permanent topics in our weekly IRC meetings so that we can get updates on the progress of each project and determine the next step to move them forward.
Voting will close at the start of the
...
(https://github.com/bitcoin/bitcoin/issues/29465)
Please leave your votes for project priorities for the next ~6 months (until the 28.0 feature freeze).
Project priorities are those which the frequent contributors to this project have voted on to have more focused review on until the next feature freeze (or until they are completed). They will become permanent topics in our weekly IRC meetings so that we can get updates on the progress of each project and determine the next step to move them forward.
Voting will close at the start of the
...
💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959532000)
OpenSSL is still a subdependency of packages used in Guix. It's hard to debug anything here without more output. i.e the output you've posted above looks like configure output, which cannot find libcrypto. Which part of your Guix build is that coming from? Can you post you're full looks.
> Do I need to pass this variable to the build command?
No.
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959532000)
OpenSSL is still a subdependency of packages used in Guix. It's hard to debug anything here without more output. i.e the output you've posted above looks like configure output, which cannot find libcrypto. Which part of your Guix build is that coming from? Can you post you're full looks.
> Do I need to pass this variable to the build command?
No.
💬 josibake commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959533592)
* Silent payments
* Package Relay
* libbitcoinkernel
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959533592)
* Silent payments
* Package Relay
* libbitcoinkernel
💬 achow101 commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959534345)
* legacy wallet removal
* silent payments
* package relay
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959534345)
* legacy wallet removal
* silent payments
* package relay
👋 Riahiamirreza's pull request is ready for review: "rpc: show P2(W)SH redeemScript in getrawtransaction #27637"
(https://github.com/bitcoin/bitcoin/pull/27638)
(https://github.com/bitcoin/bitcoin/pull/27638)
💬 glozow commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959579543)
- cluster mempool
- package relay
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959579543)
- cluster mempool
- package relay
💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959584098)
The part it comes from is indeed at the configure stage.
Depends build complete successfully, then ./autogen.sh excuted, after which ./configure is called, then the error occurs:
This is the command I ran:
env HOSTS="x86_64-linux-gnu x86_64-w64-mingw32" SOURCES_PATH="$HOME/depends-SOURCES_PATH" BASE_CACHE="$HOME/depends-BASE_CACHE" SDK_PATH="$HOME/SDKs" FORCE_DIRTY_WORKTREE=1 V=1 ./contrib/guix/guix-build
here's the last several lines leading to the error
--------
checking whether to b
...
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959584098)
The part it comes from is indeed at the configure stage.
Depends build complete successfully, then ./autogen.sh excuted, after which ./configure is called, then the error occurs:
This is the command I ran:
env HOSTS="x86_64-linux-gnu x86_64-w64-mingw32" SOURCES_PATH="$HOME/depends-SOURCES_PATH" BASE_CACHE="$HOME/depends-BASE_CACHE" SDK_PATH="$HOME/SDKs" FORCE_DIRTY_WORKTREE=1 V=1 ./contrib/guix/guix-build
here's the last several lines leading to the error
--------
checking whether to b
...
💬 Sjors commented on pull request "Double -dbache maximum to 64GB":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-1959590198)
We could expose whether the program is compiled for 32 or 64 bit in the test framework... but I just added a regex for the error message instead.
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-1959590198)
We could expose whether the program is compiled for 32 or 64 bit in the test framework... but I just added a regex for the error message instead.
💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959592450)
> Building main branch.
> checking for openssl/crypto.h... no
configure: error: libcrypto headers missing
This is impossible given the output you are showing here. Where did you get the source from. What is the commit hash? etc.
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959592450)
> Building main branch.
> checking for openssl/crypto.h... no
configure: error: libcrypto headers missing
This is impossible given the output you are showing here. Where did you get the source from. What is the commit hash? etc.
💬 instagibbs commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499355541)
have you thought about having this function return an optional error string so unit tests can check expected failure reason?
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499355541)
have you thought about having this function return an optional error string so unit tests can check expected failure reason?
💬 instagibbs commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499351311)
Asserting the stripped serialized size right after is nice for self-documentation/correctness of test, and maybe another case of a witness tx which witness size is not 64?
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499351311)
Asserting the stripped serialized size right after is nice for self-documentation/correctness of test, and maybe another case of a witness tx which witness size is not 64?
💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959597424)
fyi: I've also tried doing a gitian build, and though the build was not successful( expected that because I have not taken the time to properly configure gitian descriptors) , this particular error did not occur.
Will revisit gitian build at some point.
Now my main goal is to achieve a successful guix build.
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959597424)
fyi: I've also tried doing a gitian build, and though the build was not successful( expected that because I have not taken the time to properly configure gitian descriptors) , this particular error did not occur.
Will revisit gitian build at some point.
Now my main goal is to achieve a successful guix build.
💬 instagibbs commented on pull request "[WIP] p2p: opportunistically accept 1-parent-1-child packages":
(https://github.com/bitcoin/bitcoin/pull/28970#issuecomment-1959598347)
ready for un-draft?
(https://github.com/bitcoin/bitcoin/pull/28970#issuecomment-1959598347)
ready for un-draft?
💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959618269)
Pulled the main branch, but I've experimented a lot with the code.
I can do a clean bitcoin pull and build it untouched to see what happens.
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959618269)
Pulled the main branch, but I've experimented a lot with the code.
I can do a clean bitcoin pull and build it untouched to see what happens.
💬 sdaftuar commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#issuecomment-1959678050)
ACK apart from @instagibbs' nit here: https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1498102589
(https://github.com/bitcoin/bitcoin/pull/29306#issuecomment-1959678050)
ACK apart from @instagibbs' nit here: https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1498102589
💬 luke-jr commented on pull request "rpc: getdescriptorinfo also returns normalized descriptor":
(https://github.com/bitcoin/bitcoin/pull/29396#issuecomment-1959724149)
>For the case of hardened derivation path...
...it's documented herein as working :\
(https://github.com/bitcoin/bitcoin/pull/29396#issuecomment-1959724149)
>For the case of hardened derivation path...
...it's documented herein as working :\
💬 sdaftuar commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1499465556)
I think the slope of AB can be negative, because a user could use the `prioritisetransaction` to give a transaction a negative fee?
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1499465556)
I think the slope of AB can be negative, because a user could use the `prioritisetransaction` to give a transaction a negative fee?
💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1499472337)
one weird trick! will remove the comment
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1499472337)
one weird trick! will remove the comment
🤔 sipa reviewed a pull request: "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2"
(https://github.com/bitcoin/bitcoin/pull/29242#pullrequestreview-1893687911)
Partial review.
(https://github.com/bitcoin/bitcoin/pull/29242#pullrequestreview-1893687911)
Partial review.