💬 achow101 commented on pull request "[fuzz] Avoid partial negative result":
(https://github.com/bitcoin/bitcoin/pull/29462#issuecomment-1959506846)
ACK 9dae3b970a7a82e8d9f3f755048d427da78c49da

💬 brunoerg commented on pull request "net: call `Select` with reachable networks in `ThreadOpenConnections`":
(https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1499286213)
Yes, sure! I'll address it.

🚀 achow101 merged a pull request: "[fuzz] Avoid partial negative result"
(https://github.com/bitcoin/bitcoin/pull/29462)

⚠️ achow101 opened an issue: "Voting on Priority Projects for 28.0"
(https://github.com/bitcoin/bitcoin/issues/29465)
Please leave your votes for project priorities for the next ~6 months (until the 28.0 feature freeze).

Project priorities are those which the frequent contributors to this project have voted on to have more focused review on until the next feature freeze (or until they are completed). They will become permanent topics in our weekly IRC meetings so that we can get updates on the progress of each project and determine the next step to move them forward.

Voting will close at the start of the
...

✅ achow101 closed an issue: "Gathering Priorities of 28.0"
(https://github.com/bitcoin/bitcoin/issues/29439)

💬 sr-gi commented on pull request "net: attempts to connect to all resolved addresses when connecting to a node":
(https://github.com/bitcoin/bitcoin/pull/28834#issuecomment-1959512593)
Addressesed suggestions by @naumenkogs

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959519391)
Building main branch.

Perhaps I've introduced a code during my experiments that have triggered it. Have now gone through configure.ac as well as src/Makefile.am, and I don't see any reference to either openssl or libcrypto.

But interestingly openssl appears in contrib/guix/manifest.com, and there is also a patch under contrib/guix/patches that seems to suggest a manual control of openssl integration through an environment variable.

This is the note within the content of the patch:

+p
...

💬 fjahr commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959520489)
Cluster mempool, Silent payments, Default ASMap

⚠️ achow101 unpinned an issue: "Gathering Priorities of 28.0"
(https://github.com/bitcoin/bitcoin/issues/29439)
Please nominate projects that you are the champion of that could become priorities for the next ~6 months (until the 28.0 release). We (frequent contributors) will vote on which projects will be priorities next week in a separate issue.

There were concerns in the voting of previous priority projects that some projects nominated did not have champions who were willing to have their project be a priority project. To ensure that all nominated projects have champions who want their project to be
...

⚠️ achow101 pinned an issue: "Voting on Priority Projects for 28.0"
(https://github.com/bitcoin/bitcoin/issues/29465)
Please leave your votes for project priorities for the next ~6 months (until the 28.0 feature freeze).

Project priorities are those which the frequent contributors to this project have voted on to have more focused review on until the next feature freeze (or until they are completed). They will become permanent topics in our weekly IRC meetings so that we can get updates on the progress of each project and determine the next step to move them forward.

Voting will close at the start of the
...

💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959532000)
OpenSSL is still a subdependency of packages used in Guix. It's hard to debug anything here without more output. i.e the output you've posted above looks like configure output, which cannot find libcrypto. Which part of your Guix build is that coming from? Can you post you're full looks.

> Do I need to pass this variable to the build command?

No.

💬 josibake commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959533592)
* Silent payments
* Package Relay
* libbitcoinkernel

💬 achow101 commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959534345)
* legacy wallet removal
* silent payments
* package relay

👋 Riahiamirreza's pull request is ready for review: "rpc: show P2(W)SH redeemScript in getrawtransaction #27637"
(https://github.com/bitcoin/bitcoin/pull/27638)

💬 glozow commented on issue "Voting on Priority Projects for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29465#issuecomment-1959579543)
- cluster mempool
- package relay

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959584098)
The part it comes from is indeed at the configure stage.
Depends build complete successfully, then ./autogen.sh excuted, after which ./configure is called, then the error occurs:

This is the command I ran:
env HOSTS="x86_64-linux-gnu x86_64-w64-mingw32" SOURCES_PATH="$HOME/depends-SOURCES_PATH" BASE_CACHE="$HOME/depends-BASE_CACHE" SDK_PATH="$HOME/SDKs" FORCE_DIRTY_WORKTREE=1 V=1 ./contrib/guix/guix-build

here's the last several lines leading to the error
--------
checking whether to b
...

💬 Sjors commented on pull request "Double -dbache maximum to 64GB":
(https://github.com/bitcoin/bitcoin/pull/28358#issuecomment-1959590198)
We could expose whether the program is compiled for 32 or 64 bit in the test framework... but I just added a regex for the error message instead.

💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1959592450)
> Building main branch.

> checking for openssl/crypto.h... no
configure: error: libcrypto headers missing

This is impossible given the output you are showing here. Where did you get the source from. What is the commit hash? etc.

💬 instagibbs commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499355541)
have you thought about having this function return an optional error string so unit tests can check expected failure reason?

💬 instagibbs commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1499351311)
Asserting the stripped serialized size right after is nice for self-documentation/correctness of test, and maybe another case of a witness tx which witness size is not 64?