💬 naumenkogs commented on pull request "consensus: Store transaction nVersion as uint32_t":
(https://github.com/bitcoin/bitcoin/pull/29325#discussion_r1495440147)
ca7090d43fab2013bd396d683f4cf03062666b14

Does this still look meaningful?
If you want to test a large number, then better check against `TX_MAX_STANDARD_VERSION + 1`?

💬 maflcko commented on pull request "ci: Avoid CI failures from temp env file reuse":
(https://github.com/bitcoin/bitcoin/pull/29441#issuecomment-1953753202)
rfm? :)

💬 naumenkogs commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#issuecomment-1953785668)
ACK c10f528350152ca9248e8c167b67993fc7321ca3

💬 Sjors commented on pull request "Silent Payments: Implement BIP352":
(https://github.com/bitcoin/bitcoin/pull/28122#discussion_r1495502646)
Assuming I still need this for the index #28241, I still prefer if this wasn't part of the wallet. Afaik nothing in this file has a dependency on the wallet, so the easiest change would to be move this to `src/common`.

💬 BrandonOdiwuor commented on issue "rfc: store PSBTs in wallet ":
(https://github.com/bitcoin/bitcoin/issues/17619#issuecomment-1953810858)
What's the progress with this?

💬 josibake commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#issuecomment-1953888046)
> Am I still supposed to use it

Yep, still the correct function. The return value has changed, and we've removed the `pubkey.TweakAdd` method in favor of a dedicated routine in `module/silentpayments`. I need to expose the routine for pubkey tweaking in `src/bip352.h` and then you should be good.

💬 josibake commented on pull request "Silent Payments: Implement BIP352":
(https://github.com/bitcoin/bitcoin/pull/28122#discussion_r1495568944)
Now that we have `src/bip352.h`, it might make more sense to get rid of `src/wallet/silentpayents.h` and put everything in `src/bip352.h`. In the future, anything that is wallet specific can go in `src/wallet/silentpayments.h` and you'd have everything you need for an index in `src/bip352.h`. Thoughts?

🚀 fanquake merged a pull request: "wallet: cache IsMine scriptPubKeys to improve performance of descriptor wallets"
(https://github.com/bitcoin/bitcoin/pull/26008)

🚀 fanquake merged a pull request: "ci: Avoid CI failures from temp env file reuse"
(https://github.com/bitcoin/bitcoin/pull/29441)

💬 hebasto commented on issue "When selecting a custom data directory on first launch of Bitcoin Core GUI on Mac, where is that setting stored?":
(https://github.com/bitcoin-core/gui/issues/798#issuecomment-1953943599)
> I believe I've located it:
>
> `~/Library/Preferences/org.bitcoin.Bitcoin-Qt.plist`

That's correct. Also see https://github.com/bitcoin-core/gui/blob/master/doc/files.md#gui-settings.

> I spoke too soon. When I delete that file, Bitcoin Core GUI still knows about the custom location I selected at first launch.

You have to invalidate the corresponding cache: https://stackoverflow.com/questions/19742452/qsettings-on-os-x-10-9-unable-to-locate-clear-it.

📝 m3dwards opened a pull request: "docs: ci multi-arch requires qemu"
(https://github.com/bitcoin/bitcoin/pull/29456)
On a fresh Debian system qemu isn't installed and therefore the multi-architecture CI system doesn't run.

This documentation notes that qemu is required and how to install it.

💬 maflcko commented on pull request "consensus: Store transaction nVersion as uint32_t":
(https://github.com/bitcoin/bitcoin/pull/29325#discussion_r1495633116)
> If you want to test a large number, then better check against TX_MAX_STANDARD_VERSION + 1?

This check already exists two lines below.

> Does this still look meaningful?

Yes, the goal is to check the edge cases (minimum and maximum possible number)

💬 sipa commented on pull request "consensus: Store transaction nVersion as uint32_t":
(https://github.com/bitcoin/bitcoin/pull/29325#discussion_r1495653173)
It'd look a bit more natural using `= 0xffffffff` or `= std::numeric_limits<uint32_t>::max()`.

💬 hebasto commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1954008330)
@maflcko

Does https://github.com/bitcoin-core/gui/pull/797 fix this issue for you?

💬 maflcko commented on pull request "test: Recognize dialog object by name":
(https://github.com/bitcoin-core/gui/pull/797#issuecomment-1954016527)
lgtm, Thanks!

💬 dergoegge commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#issuecomment-1954024203)
I would like to see this in v27, can we add it to the milestone?

💬 fanquake commented on pull request "refactor: bitcoin-config.h includes cleanup":
(https://github.com/bitcoin/bitcoin/pull/29404#issuecomment-1954026863)
Note there are at least two defines missing from the scriptied diff (`_TIME_BITS` & `__MINGW_USE_VC2005_COMPAT`), if using Autoconf 2.72 , however that should not make a difference here. Looks like `WORDS_BIGENDIAN` is also missing, but that should als be ok.

💬 sipa commented on pull request "Weaken serfloat tests":
(https://github.com/bitcoin/bitcoin/pull/29192#discussion_r1495673285)
Indeed, reverted (and also stuck closer to the former code).

✅ hebasto closed an issue: "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in"
(https://github.com/bitcoin-core/gui/issues/796)

🚀 hebasto merged a pull request: "test: Recognize dialog object by name"
(https://github.com/bitcoin-core/gui/pull/797)