💬 hebasto commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952250759)
cc @furszy

⚠️ gdiscord opened an issue: "Guix build script incorrectly reporting there is no Mac SDK"
(https://github.com/bitcoin/bitcoin/issues/29449)
Trying Guix build for the first time and hitting this seemingly unexplainable issue

macOS SDK does not exist at '/root/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers', please place the extracted, untarred SDK there to perform darwin builds, or define SDK_PATH environment variable. Exiting...

I've tried placing it in the depends folder, and the error is the same.

Makes me think I'm probably missing something that is undocumented

![Screenshot 2024-02-19 at 11 35 17](https://
...

💬 magks commented on issue "Assertion chainman().ActiveChain()[height] fails on startup on memory-constrained system":
(https://github.com/bitcoin/bitcoin/issues/29422#issuecomment-1952276380)
Just want to add that on a Raspberry PI 3B with 1 GB memory I also was running into a similiar issue during IBD however it was on testnet rather than mainnet that I got around by creating a swapfile. The PI was also running Unbound and had about 500MB free memory upon starting the IBD. The kernel would panic and upon rebooting dmesg revealed the OOM errors. So I created a swapfile and monitored with `free`. Indeed the memory filled and would occasionally dip into swap. I can't recall now what th
...

💬 fanquake commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952277332)
Looks like you've got the SDK in `~/BITCOIN/SDKs/`, but you're telling the build script it's at `~/SDKs/` ?

💬 gdiscord commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952290698)
The SDK is in ~/BITCOIN/SDKs/
I've tried various kinds of combinations also.


💬 hebasto commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952294989)
> Not sure if it is reproducible...

I can't to reproduce it.

💬 maflcko commented on issue "ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in":
(https://github.com/bitcoin-core/gui/issues/796#issuecomment-1952299486)
You can reproduce with:


```diff
diff --git a/src/qt/test/wallettests.cpp b/src/qt/test/wallettests.cpp
index f5b86f44a6..142ec821e2 100644
--- a/src/qt/test/wallettests.cpp
+++ b/src/qt/test/wallettests.cpp
@@ -429,6 +429,7 @@ void TestGUIWatchOnly(interfaces::Node& node, TestChain100Setup& test)
}
});
timer.start(500);
+ std::this_thread::sleep_for(500ms);

// Send tx and verify PSBT copied to the clipboard.
SendCoins(*wallet.get(), sendCoinsDia
...

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#issuecomment-1952306161)
> alternative log lines are a bit noisy, but understandable and I have no good suggestions that reduce that much
> I'm not sure how important it is to return the v3 error messages if sibling RBF fails.

I've changed it to just add "(including sibling eviction)" when that is what's happening. The diff is less invasive this way, but let me know if still too clunky. I just want to avoid confusing users ("wait, why am I getting an RBF error if I didn't try to replace anything?").

✅ maflcko closed an issue: "Guix build script incorrectly reporting there is no Mac SDK"
(https://github.com/bitcoin/bitcoin/issues/29449)

💬 maflcko commented on issue "Guix build script incorrectly reporting there is no Mac SDK":
(https://github.com/bitcoin/bitcoin/issues/29449#issuecomment-1952306497)
Please read the error message carefully. Not sure what your question is.

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494446464)
Changed this to be `parent_entry->GetCountWithDescendants() == 2` so no grandchildren and no other siblings.

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447054)
Added an `Assume`

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447437)
Kept this and added an `Assume`, also see https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1493792426

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447595)
Done

💬 glozow commented on pull request "policy: enable sibling eviction for v3 transactions":
(https://github.com/bitcoin/bitcoin/pull/29306#discussion_r1494447749)
Done

🤔 fjahr reviewed a pull request: "rpc: improve submitpackage documentation and other improvements"
(https://github.com/bitcoin/bitcoin/pull/29292#pullrequestreview-1888244890)
utACK 5a7a7208554d09bd0a0bb8de9d4d94ed4146e739

This is ok to merge as is but if you decide to address https://github.com/bitcoin/bitcoin/pull/29292/commits/9deb9104572b4543b7135c31fbf3a34cb1f371b6#r1476296848 I will quickly re-review.

💬 fjahr commented on pull request "rpc: improve submitpackage documentation and other improvements":
(https://github.com/bitcoin/bitcoin/pull/29292#discussion_r1494441180)
Don't we check for `MAX_PACKAGE_COUNT` later on as well (so twice)? Either way, I am leaning slightly towards what @glozow asks, simply because it's nicer for the users to give helpful feedback as early as we can.

💬 fjahr commented on pull request "rpc: improve submitpackage documentation and other improvements":
(https://github.com/bitcoin/bitcoin/pull/29292#discussion_r1494445730)
nit: Might be good to stick this somewhere into the framework so it can be reused in other test, similar to the constants on top of `test_framework/messages.py`.

✅ maflcko closed an issue: "[CI/CD]Release channels?"
(https://github.com/bitcoin/bitcoin/issues/29446)

💬 maflcko commented on issue "[CI/CD]Release channels?":
(https://github.com/bitcoin/bitcoin/issues/29446#issuecomment-1952319730)
Closing for now. Let us know if you have any other questions.