👍 willcl-ark approved a pull request: "net: make the list of known message types a compile time constant"
(https://github.com/bitcoin/bitcoin/pull/29421#pullrequestreview-1880064231)
ACK 2e312ea909ae6c466007acf791ea0e3356e954cb

This is a clean tidy-up, and as mentioned useful for #29418 but stands on it's own (as a smalle improvement) too.

Left one req for comment update if touched again.

💬 willcl-ark commented on pull request "net: make the list of known message types a compile time constant":
(https://github.com/bitcoin/bitcoin/pull/29421#discussion_r1489333827)
There is a comment in src/protocol.h#56 which could be updated to reflect the new constant too:

```cpp
/**
* Bitcoin protocol message types. When adding new message types, don't forget
* to update allNetMessageTypes in protocol.cpp.
*/
```

💬 Sjors commented on pull request "Stratum v2 Noise Protocol":
(https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-1943613979)
Updated and simplified the description to account for the new parent PR. I'm leaving this in draft status pending two merges on the SRI side; that way the whole thing is easier to test.

💬 maflcko commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#discussion_r1489365242)
```suggestion
auto filename{PathFromString(strprintf("legacy_%d", wallet_num));
```

I don't like the c_str below. Also, it doesn't compile on Windows.

Using `PathFromString` should be fine to "convert" ascii to a path segment, IIUC

Same above and https://github.com/bitcoin/bitcoin/pull/28894#discussion_r1420361508

💬 maflcko commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1489378056)
```suggestion

self.log.info('Testing abortrescan when no rescan is in progress')
```

No need to type the same thing twice

🤔 furszy reviewed a pull request: "rpc: Drop migratewallet experimental warning"
(https://github.com/bitcoin/bitcoin/pull/28037#pullrequestreview-1880133512)
> Not sure. I am using the spinning storage only to test migratewallet.

I'm asking because if other processes are equally slow, then this could be "ok" (and we could declare the hardware unsupported for core entirely...). But if only this process takes forever, then we are sure that there is an issue.

> It finished after 2 hours.

We are definitely not expecting this process to take that long. The wallet you shared is really small.

> Another problem is that (I presume) large single-ke
...

💬 BrandonOdiwuor commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/29387#discussion_r1489381387)
fixed

👍 BrandonOdiwuor approved a pull request: "wallet: Allow user to navigate options while encrypting at creation"
(https://github.com/bitcoin-core/gui/pull/722#pullrequestreview-1880142626)
re-Tested ACK cccddc03f0c625daeac7158eb20c1508aea5df39

📝 bstin opened a pull request: "Update rpcauth.py"
(https://github.com/bitcoin/bitcoin/pull/29433)
This is a simple change to rpcauth.py utility in order to output as json instead raw text.

This is beneficial because integrating json output is simpler with multiple different forms of automation and tooling

💬 furszy commented on pull request "wallet: optimize migration process, batch db transactions":
(https://github.com/bitcoin/bitcoin/pull/28574#discussion_r1489408285)
> I don't like the c_str below. Also, it doesn't compile on Windows.

yeah, me neither.. I just did this 5 months ago. Fixing..

💬 maflcko commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/29387#issuecomment-1943700391)
lgtm ACK fe5919d7cec62c31367be456a0dc5dcf094efbe2

💬 maflcko commented on pull request "Update rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/29433#issuecomment-1943705614)
Missing `contrib:` prefix in pull title?

💬 1440000bytes commented on issue "Move from Static Dust Limit [330 / 546 sats] to Variable Dust Limit [= to TxFee]":
(https://github.com/bitcoin/bitcoin/issues/29423#issuecomment-1943724704)
So this tx will be considered dust and won't get relayed if such solution is implemented: [bdc168f1d6c38c66c762ccb36655a118436347b074f4a1ff1c8cad4e7429ae0f](https://mempool.space/tx/bdc168f1d6c38c66c762ccb36655a118436347b074f4a1ff1c8cad4e7429ae0f)?

💬 BrandonOdiwuor commented on issue "gen-manpages output depends on build options, so needs to check them":
(https://github.com/bitcoin/bitcoin/issues/17506#issuecomment-1943751907)
any progress with this?

💬 BrandonOdiwuor commented on issue "psbt: set global_xpubs (at least for multisig descriptors)":
(https://github.com/bitcoin/bitcoin/issues/27583#issuecomment-1943762831)
What's the progress with this?

💬 BrandonOdiwuor commented on issue "psbt: set global_xpubs (at least for multisig descriptors)":
(https://github.com/bitcoin/bitcoin/issues/27583#issuecomment-1943763250)
@achow101 what do you think of this?

💬 fanquake commented on pull request "test: fix RPC coverage check":
(https://github.com/bitcoin/bitcoin/pull/29387#issuecomment-1943815753)
This still seems broken. i.e Running `--legacy-wallet` tests directly will no-longer work:
```bash
test/functional/test_runner.py wallet_createwallet.py --legacy-wallet
Temporary test directory at /tmp/test_runner_₿_🏃_20240214_135022
Running Unit Tests for Test Framework Modules
.....................
----------------------------------------------------------------------
Ran 21 tests in 25.689s

OK
usage: create_cache.py [options]
create_cache.py: error: argument --descriptors: not al
...

📝 jadijadi opened a pull request: "qt: prevent weird focus rect on inital sync"
(https://github.com/bitcoin-core/gui/pull/795)
During the initial sync, the Tab moves the focus to the widgets of the main window, even when the ModalOverlay is visible. This creates some weird rectangular *selections on the screen*.

This PR fixes this by keeping the focus on the "Hide" button while the ModalOverlay is visible.

Fixes #783

💬 jadijadi commented on pull request "qt: prevent weird focus rect on inital sync":
(https://github.com/bitcoin-core/gui/pull/795#issuecomment-1943826231)
To reproduce the issue (tested on Mac & KDE):
- open bitcoin gui with wallet
- Hide the sync modal
- Go to send tab
- Highlight the Label
- Click on the progress bar to open the sync modal
- press TAB and a misplaced rectangular highlight should appear

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#discussion_r1489543326)
The template provider tests are quite brittle because they use a real socket.