💬 brunoerg commented on pull request "test: merge banning test from p2p_disconnect_ban to rpc_setban":
(https://github.com/bitcoin/bitcoin/pull/26863#issuecomment-1942677223)
Rebased

💬 pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942681474)
@hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.

💬 pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488634834)
True, I'll re-phrase it, thank you!

💬 pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488635819)
Agreed.

🤔 furszy reviewed a pull request: "rpc: Drop migratewallet experimental warning"
(https://github.com/bitcoin/bitcoin/pull/28037#pullrequestreview-1879022384)
Is the chain sync, reindex or any indexing procedure taking that long as well?

🤔 hernanmarino reviewed a pull request: "cli: improve error message on multiwallet and add validation to cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1879030432)
re ACK fa48d460334beef43fa73455aa9e30971d33c1b2
Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.
Also, and although not invalidating for me , I think that @jonatack 's suggestions are worth following.

👍 hernanmarino approved a pull request: "assumeutxo, rpc: Improve EOF error when reading snapshot metadata in loadtxoutset"
(https://github.com/bitcoin/bitcoin/pull/28670#pullrequestreview-1879041794)
Approach ACK

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1942756439)
> re ACK [fa48d46](https://github.com/bitcoin/bitcoin/commit/fa48d460334beef43fa73455aa9e30971d33c1b2) Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.

Yeah, there was an unconscious typo somewhere since the beginning and I think it's what @jonatack meant on his [latest review](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) as well.

> Also, and although not invalidating for me , I think that @jo
...

💬 hernanmarino commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942759563)
> @hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md?rgh-link-date=2024-02-13T21%3A47%3A53Z) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.

I read the guide (and your PR) and it doesn´t mention what branches/commits/files to diff

I performed a diff on th PR branch after the make ins
...

💬 pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942782943)
I think you don't need to run [the python script](https://github.com/bitcoin/bitcoin/pull/29397#pullrequestreview-1868440624) cos that core PR I mentioned above was already merged on this `gui` repo before this PR and since this PR is now merged too, you would need to perform just the `make` command on `master` before this PR.

📝 xavier6 opened a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.

✅ fanquake closed a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)

📝 fanquake locked a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.

📝 xavier6 opened a pull request: "Add Opentimestamps Verity"
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".

💬 xavier6 commented on pull request "Add Opentimestamps Verity":
(https://github.com/bitcoin/bitcoin/pull/29430#issuecomment-1943080114)
Hopefully it works!

✅ achow101 closed a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)

📝 achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".

💬 kevkevinpal commented on pull request "mempool: Log added for dumping mempool transactions to disk":
(https://github.com/bitcoin/bitcoin/pull/29402#discussion_r1488897358)
updated in this commit [b9f449b](https://github.com/bitcoin/bitcoin/pull/29402/commits/b9f449b2d0637c09fd8dc3f44078355827af4a92)

💬 kevkevinpal commented on pull request "mempool: Log added for dumping mempool transactions to disk":
(https://github.com/bitcoin/bitcoin/pull/29402#discussion_r1488899166)
I think this is what you are talking about unless I'm getting confused [b9f449b](https://github.com/bitcoin/bitcoin/pull/29402/commits/b9f449b2d0637c09fd8dc3f44078355827af4a92)

the <util/fs.h> includes is already imported but I added `fs::` before `file_size`

💬 DoctorBuzz1 commented on issue "Move from Static Dust Limit [330 / 546 sats] to Variable Dust Limit [= to TxFee]":
(https://github.com/bitcoin/bitcoin/issues/29423#issuecomment-1943222606)
Rate limit the spam, which is overtaking the monetary use-case of Bitcoin, and the batch Txs like you suggest wouldn't be a real problem. It's only a problem when the spam continues to jack up fees for no legit reason. See here: https://twitter.com/DoctorBuzz1/status/1757659895426330648

Even in the current fee market, I think it would be tough to find a legit batch Tx that would be triggered by this change, considering the savings mentioned in your link. And even if you COULD find an exam
...