Bitcoin Core Github
43 subscribers
123K links
Download Telegram
βœ… brunoerg closed a pull request: "addrman: delete addresses that don't belong to the supported networks"
(https://github.com/bitcoin/bitcoin/pull/29330)
πŸ’¬ brunoerg commented on pull request "addrman: delete addresses that don't belong to the supported networks":
(https://github.com/bitcoin/bitcoin/pull/29330#issuecomment-1942641832)
I'll close this PR to work on a "less aggressive" approach (extending `Select` to support multiple networks). I will provide my benchmarks on that new PR.

Thanks, @vasild @mzumsande @naumenkogs @amitiuttarwar.
πŸ’¬ hernanmarino commented on pull request "wallet: Allow user to navigate options while encrypting at creation":
(https://github.com/bitcoin-core/gui/pull/722#issuecomment-1942673140)
Rebased for CI, no actual code changes in my code.
πŸ’¬ brunoerg commented on pull request "test: merge banning test from p2p_disconnect_ban to rpc_setban":
(https://github.com/bitcoin/bitcoin/pull/26863#issuecomment-1942677223)
Rebased
πŸ’¬ pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942681474)
@hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.
πŸ’¬ pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488634834)
True, I'll re-phrase it, thank you!
πŸ’¬ pablomartin4btc commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1488635819)
Agreed.
πŸ€” furszy reviewed a pull request: "rpc: Drop migratewallet experimental warning"
(https://github.com/bitcoin/bitcoin/pull/28037#pullrequestreview-1879022384)
Is the chain sync, reindex or any indexing procedure taking that long as well?
πŸ€” hernanmarino reviewed a pull request: "cli: improve error message on multiwallet and add validation to cli-side commands"
(https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1879030432)
re ACK fa48d460334beef43fa73455aa9e30971d33c1b2
Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.
Also, and although not invalidating for me , I think that @jonatack 's suggestions are worth following.
πŸ‘ hernanmarino approved a pull request: "assumeutxo, rpc: Improve EOF error when reading snapshot metadata in loadtxoutset"
(https://github.com/bitcoin/bitcoin/pull/28670#pullrequestreview-1879041794)
Approach ACK
πŸ’¬ pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1942756439)
> re ACK [fa48d46](https://github.com/bitcoin/bitcoin/commit/fa48d460334beef43fa73455aa9e30971d33c1b2) Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli.

Yeah, there was an unconscious typo somewhere since the beginning and I think it's what @jonatack meant on his [latest review](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) as well.

> Also, and although not invalidating for me , I think that @jo
...
πŸ’¬ hernanmarino commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942759563)
> @hernanmarino check this [guide](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md?rgh-link-date=2024-02-13T21%3A47%3A53Z) (there's an ongoing [small correction](https://github.com/bitcoin/bitcoin/pull/29414)) and see this [PR](https://github.com/bitcoin/bitcoin/pull/29397) was done on the core repo recently as an example.

I read the guide (and your PR) and it doesnΒ΄t mention what branches/commits/files to diff

I performed a diff on th PR branch after the make ins
...
πŸ’¬ pablomartin4btc commented on pull request "Update translation source file for v27.0 string freeze":
(https://github.com/bitcoin-core/gui/pull/793#issuecomment-1942782943)
I think you don't need to run [the python script](https://github.com/bitcoin/bitcoin/pull/29397#pullrequestreview-1868440624) cos that core PR I mentioned above was already merged on this `gui` repo before this PR and since this PR is now merged too, you would need to perform just the `make` command on `master` before this PR.
πŸ“ xavier6 opened a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.
βœ… fanquake closed a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
πŸ“ fanquake locked a pull request: "Musicjoin"
(https://github.com/bitcoin/bitcoin/pull/29429)
I wanted to add the ability to append Opentimestamp data onto the blockchain to assess the verity of some of these blocks. I have a video file that is a photo of Drake (the rapper) and me backstage, with one of his songs playing, as the timestamp for the block. I want to create a safe place to house our timestamps.
πŸ“ xavier6 opened a pull request: "Add Opentimestamps Verity"
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".
πŸ’¬ xavier6 commented on pull request "Add Opentimestamps Verity":
(https://github.com/bitcoin/bitcoin/pull/29430#issuecomment-1943080114)
Hopefully it works!
βœ… achow101 closed a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)
πŸ“ achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29430)
Change files' location to "ots/Block &727215/".