💬 epiccurious commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1485441251)
Why remove this?

💬 epiccurious commented on pull request "log: Nuke error(...)":
(https://github.com/bitcoin/bitcoin/pull/29236#issuecomment-1937407280)
Concept ACK fa1d4f07c36dda3c72fb328918bddd7de062ef96.

> Fix all issues by removing it.

Any conceivable downsides to removing it?

💬 epiccurious commented on pull request "logging: Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#issuecomment-1937408052)
> Changes all uses of LogPrintLevel() where the level is hardcoded, and changes all LogPrintf and LogPrint uses in init.cpp.

Trying to understand the concept here. What problem does this solve?

💬 epiccurious commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-1937408907)
I'd like to reproduce your issue on my local environment.

Can you please provide steps to reproduce this issue?

Also, does this issue happen every time, or is it intermittent?

💬 epiccurious commented on issue "Update security.md with all PGP fingerprints":
(https://github.com/bitcoin/bitcoin/issues/29366#issuecomment-1937413112)
> points to a "private list of security officers" where no member is explicitly named

In light of this, @ariard are you comfortable closing the issue? If not, what specific objection?

💬 ishaanam commented on pull request "wallet: track mempool conflicts with wallet transactions":
(https://github.com/bitcoin/bitcoin/pull/27307#issuecomment-1937431126)
> I think a good approach would avoid adding a TxStateMempoolConflicted top-level state, and just add a bool mempool_conflicts or std::set<Txid> mempool_conflicts member to the TxStateInactive struct.

Thanks for your feedback, I have implemented this.

📝 oceannoc opened a pull request: "Create Bitcoin"
(https://github.com/bitcoin/bitcoin/pull/29417)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ oceannoc closed a pull request: "Create Bitcoin"
(https://github.com/bitcoin/bitcoin/pull/29417)

💬 helpau commented on issue "Connection between nodes on the PC interfaces doesn't work":
(https://github.com/bitcoin/bitcoin/issues/29097#issuecomment-1937477377)
I tried again with a fully synchronised node, did not reproduce. I think minimumchainwork will similarly solve the problem. Thanks for the reply.

📝 vasild opened a pull request: "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'"
(https://github.com/bitcoin/bitcoin/pull/29418)
Introduce a new RPC, `getnetmsgstats` to retrieve traffic bytes and count of messages possibly broken down by:
* direction (sent or received)
* network (ipv4, tor, etc)
* connection type (outbound-full-relay, block-relay-only, etc)
* message type (verack, ping, etc)

Implements: https://github.com/bitcoin/bitcoin/issues/26337 Add per message stats to getnettotals rpc

---

Examples:

<details>
<summary>bitcoin-cli getnetmsgstats '["direction", "network", "connection_type", "message_
...

💬 vasild commented on pull request "rpc: add 'getnetmsgstats' RPC":
(https://github.com/bitcoin/bitcoin/pull/28926#issuecomment-1937492567)
> Should I PR the above branch?

Opened https://github.com/bitcoin/bitcoin/pull/29418

💬 TheCharlatan commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1937538080)
Concept ACK

💬 maflcko commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-1937653514)
@epiccurious The issue is intermittent, because "Restarting node helped." (see the report)

💬 maflcko commented on pull request "log: Nuke error(...)":
(https://github.com/bitcoin/bitcoin/pull/29236#issuecomment-1937657442)
> Any conceivable downsides to removing it?

I can't see one, apart from the change consuming time to review it.

✅ sdaftuar closed a pull request: "Enforce incentive compatibility for all RBF replacements"
(https://github.com/bitcoin/bitcoin/pull/26451)

💬 sdaftuar commented on pull request "Enforce incentive compatibility for all RBF replacements":
(https://github.com/bitcoin/bitcoin/pull/26451#issuecomment-1937672476)
This work has obviously been superseded by the cluster mempool proposal, which solves these problems in a much better way than anything contemplated here.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-1937766372)
@epiccurious, p2p encryption "solves" the spying from intermediate routers on clearnet (aka man-in-the-middle). Tor, I2P and CJDNS solve that too. While this PR uses only Tor and I2P it would solve that problem. But there is more - it will as well solve issues with spying bitcoin nodes.

📝 vasild opened a pull request: "log: deduplicate category names and improve logging.cpp"
(https://github.com/bitcoin/bitcoin/pull/29419)
The code in `logging.cpp` needs to:
* Get the category name given the flag (e.g. `BCLog::PRUNE` -> `"prune"`)
* Get the flag given the category name (e.g. `"prune"` -> `BCLog::PRUNE`)
* Get the list of category names sorted in alphabetical order

Achieve this by using the proper std containers. The result is
* less code (the diff of the first commit is +62 / -129)
* faster code (to linear search and no copy+sort)
* more maintainable code (the categories are no longer duplicated in `LogC
...

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1485605463)
Done in https://github.com/bitcoin/bitcoin/pull/29419, thanks for the suggestion!

📝 vasild opened a pull request: "test: extend the SOCKS5 Python proxy to actually connect to a destination"
(https://github.com/bitcoin/bitcoin/pull/29420)
If requested, make the SOCKS5 Python proxy redirect connections to a set of given destinations. Actually act as a real proxy, connecting the client to a destination, except that the destination is not what the client asked for.

This would enable us to "connect" to Tor addresses from the functional tests.

Plus a few other minor improvements in the test framework as individual commits.

---

These changes are part of https://github.com/bitcoin/bitcoin/pull/29415 but they make sense on th
...