💬 epiccurious commented on pull request "test: p2p: check disconnect due to lack of desirable service flags":
(https://github.com/bitcoin/bitcoin/pull/29279#discussion_r1485426813)
ACK this nit. Any reason to not include all here?

💬 epiccurious commented on pull request "test: p2p: check disconnect due to lack of desirable service flags":
(https://github.com/bitcoin/bitcoin/pull/29279#issuecomment-1937398262)
> good to include a test case ... only connect to NODE_NETWORK_LIMITED peers when the local chain is within 24h window from the tip

ACK

💬 epiccurious commented on pull request "test: p2p: check disconnect due to lack of desirable service flags":
(https://github.com/bitcoin/bitcoin/pull/29279#issuecomment-1937398480)
utACK d82eafb173d6bfa98a59e86a845013cc8528b65d.

💬 epiccurious commented on pull request "bitcoin-cli help detail to show full help for all RPCs":
(https://github.com/bitcoin/bitcoin/pull/29163#issuecomment-1937401871)
utACK c6b68c29707770a17617d7d6af572d7460170eab.

> This would be helpful to me

Being able to search through the descriptions of all commands would be helpful.

> This PR allows you to run: `bitcoin-cli help detail`

This approach seems awkward. Is there a better UX option here? What about `bitcoin-cli helpdetail`?

💬 epiccurious commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#issuecomment-1937402710)
Concept ACK 5023b47e85161a0b35839ce03c7b5d55ff1cd4c1.

💬 epiccurious commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#issuecomment-1937406162)
utACK 6aae096b7d525e02f54b66b6eb1b4520ae4a7f0c.

💬 epiccurious commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1485441911)
Nit (feel free to disregard) - this is a run-on sentence and complicated to follow. Please break it up to be more readable.

💬 epiccurious commented on pull request "doc: Update translation process guide":
(https://github.com/bitcoin/bitcoin/pull/29414#discussion_r1485441251)
Why remove this?

💬 epiccurious commented on pull request "log: Nuke error(...)":
(https://github.com/bitcoin/bitcoin/pull/29236#issuecomment-1937407280)
Concept ACK fa1d4f07c36dda3c72fb328918bddd7de062ef96.

> Fix all issues by removing it.

Any conceivable downsides to removing it?

💬 epiccurious commented on pull request "logging: Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#issuecomment-1937408052)
> Changes all uses of LogPrintLevel() where the level is hardcoded, and changes all LogPrintf and LogPrint uses in init.cpp.

Trying to understand the concept here. What problem does this solve?

💬 epiccurious commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-1937408907)
I'd like to reproduce your issue on my local environment.

Can you please provide steps to reproduce this issue?

Also, does this issue happen every time, or is it intermittent?

💬 epiccurious commented on issue "Update security.md with all PGP fingerprints":
(https://github.com/bitcoin/bitcoin/issues/29366#issuecomment-1937413112)
> points to a "private list of security officers" where no member is explicitly named

In light of this, @ariard are you comfortable closing the issue? If not, what specific objection?

💬 ishaanam commented on pull request "wallet: track mempool conflicts with wallet transactions":
(https://github.com/bitcoin/bitcoin/pull/27307#issuecomment-1937431126)
> I think a good approach would avoid adding a TxStateMempoolConflicted top-level state, and just add a bool mempool_conflicts or std::set<Txid> mempool_conflicts member to the TxStateInactive struct.

Thanks for your feedback, I have implemented this.

📝 oceannoc opened a pull request: "Create Bitcoin"
(https://github.com/bitcoin/bitcoin/pull/29417)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ oceannoc closed a pull request: "Create Bitcoin"
(https://github.com/bitcoin/bitcoin/pull/29417)

💬 helpau commented on issue "Connection between nodes on the PC interfaces doesn't work":
(https://github.com/bitcoin/bitcoin/issues/29097#issuecomment-1937477377)
I tried again with a fully synchronised node, did not reproduce. I think minimumchainwork will similarly solve the problem. Thanks for the reply.

📝 vasild opened a pull request: "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'"
(https://github.com/bitcoin/bitcoin/pull/29418)
Introduce a new RPC, `getnetmsgstats` to retrieve traffic bytes and count of messages possibly broken down by:
* direction (sent or received)
* network (ipv4, tor, etc)
* connection type (outbound-full-relay, block-relay-only, etc)
* message type (verack, ping, etc)

Implements: https://github.com/bitcoin/bitcoin/issues/26337 Add per message stats to getnettotals rpc

---

Examples:

<details>
<summary>bitcoin-cli getnetmsgstats '["direction", "network", "connection_type", "message_
...

💬 vasild commented on pull request "rpc: add 'getnetmsgstats' RPC":
(https://github.com/bitcoin/bitcoin/pull/28926#issuecomment-1937492567)
> Should I PR the above branch?

Opened https://github.com/bitcoin/bitcoin/pull/29418

💬 TheCharlatan commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1937538080)
Concept ACK

💬 maflcko commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-1937653514)
@epiccurious The issue is intermittent, because "Restarting node helped." (see the report)