💬 ariard commented on issue "Cluster mempool, CPFP carveout, and V3 transaction policy":
(https://github.com/bitcoin/bitcoin/issues/29319#issuecomment-1935060892)
So carve-out was introduced back by #15681 with motivation to allow one extra single ancestor tx.
After testing https://github.com/bitcoin/bitcoin/commit/6337b978e77a4e1f93bb009958db7c9a619323df you can always replace a long-chain of transactions with a higher-fee candidate. Carve-out is already broken today due to NTA pinning.
LN devs can upgrade to have a single output on each commitment with one branch for each counterparty.
At least this should conserve the same level of robustness for no
...

🚀 achow101 merged a pull request: "test: fix intermittent failure in `rpc_setban.py --v2transport`, run it in CI"
(https://github.com/bitcoin/bitcoin/pull/29372)

💬 achow101 commented on pull request "test: Add makefile target for running unit tests":
(https://github.com/bitcoin/bitcoin/pull/29377#issuecomment-1935067438)
ACK 5ca9b24da18e842e7a093dc44f6b222af73e92cf

> I also wonder if this new `check-unit` test option is redundant with the existing `bitcoin_test_check` target.

`bitcoin_test_check` just fails for me, so they are at least different in this aspect. It looks like this target is used by the `check` target in `src/test/Makefile`.

👍 kristapsk approved a pull request: "i2p: log connection was refused due to arbitrary port"
(https://github.com/bitcoin/bitcoin/pull/29393#pullrequestreview-1871410459)
re-ACK 5b358cdd1a5f5d2fe87a9e41c638996eab2e2796

🚀 achow101 merged a pull request: "test: Add makefile target for running unit tests"
(https://github.com/bitcoin/bitcoin/pull/29377)

💬 shovas commented on issue "Use of a wallet shouldn't be blocked in prune mode ("wallet loading failed... beyond pruned data")":
(https://github.com/bitcoin/bitcoin/issues/27188#issuecomment-1935075611)
> @shovas, I have created #29183 to focus our efforts and delineate the working path in the clearest possible manner. It should help pushing the project forward.

Thanks, I'm watching that issue. I'm experimenting with wallets for btcoin, litecoin, dogecoin, and bitcoin cash using cli tools right now so maybe I can help in some way.

💬 shovas commented on issue "Prune Node Rescan Project Tracking":
(https://github.com/bitcoin/bitcoin/issues/29183#issuecomment-1935076754)
Here from #27188. I'm presently experimenting with wallets for bitcoin, litecoin, dogecoin, and bitcoin cash using linux cli tools right now so if I can help I'll try.

💬 ariard commented on pull request "Nuke adjusted time from validation (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/28956#issuecomment-1935077559)
> After a few attempts, I haven't found a way to trigger a consensus fork through adjusted time.

Unclear what has been tested actually (e.g setting sampled time of peers in the past and playing with blocks timestamps).
That said I think it’s a very edge scenario, and most susceptible to affect non-upgraded things like btcd.

> I now believe that the network-adjusted time implementation in master does not offer any security guarantees against an attacker trying to get a node out of consensu
...

💬 sdaftuar commented on issue "Cluster mempool, CPFP carveout, and V3 transaction policy":
(https://github.com/bitcoin/bitcoin/issues/29319#issuecomment-1935097759)
@ariard I agree that this would be simpler if there is just 1 anchor output (see also @instagibbs' proposal for ephemeral anchors, fwiw). But (a) that is not up to this project to decide; (b) you still need some kind of pinning solution if a too-large spend is created (which v3 provides -- while no other workable proposals have been put forward); and (c) even then it sounds like it would take LN some time to coordinate an upgrade to a 1-anchor system (whether EA or 2 branches of a single script
...

💬 achow101 commented on pull request "test: maxuploadtarget: check for mempool msg disconnect if limit is reached, improve existing test coverage":
(https://github.com/bitcoin/bitcoin/pull/28996#issuecomment-1935137249)
ACK b58f009d9585aab775998644de07e27e2a4a8045

💬 araujo88 commented on pull request "rpc: getdescriptorinfo also returns normalized descriptor":
(https://github.com/bitcoin/bitcoin/pull/29396#issuecomment-1935143088)
I'm getting an error in one the functional tests cases in `test/functional/rpc_getdescriptorinfo.py`.

A fix would be changing the derivation path from `1/2h` (hardened) to `1/2` (non-hardened):

```
- self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/1h/2)", isrange=False, issolvable=True, hasprivatekeys=False)
+ self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLn
...

🚀 achow101 merged a pull request: "test: maxuploadtarget: check for mempool msg disconnect if limit is reached, improve existing test coverage"
(https://github.com/bitcoin/bitcoin/pull/28996)

📝 pablomartin4btc opened a pull request: "doc: Update translation process guide"
(https://github.com/bitcoin/bitcoin/pull/29414)
Updating Transifex broken link and setup Transifex config file with a token.

💬 achow101 commented on pull request "rpc: getdescriptorinfo also returns normalized descriptor":
(https://github.com/bitcoin/bitcoin/pull/29396#issuecomment-1935265831)
> I'm getting an error in one the functional tests cases in `test/functional/rpc_getdescriptorinfo.py`.
>
> A fix would be changing the derivation path from `1/2h` (hardened) to `1/2` (non-hardened):
>
> ```
> - self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/1h/2)", isrange=False, issolvable=True, hasprivatekeys=False)
> + self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Po
...

💬 epiccurious commented on pull request "fuzz: increase length of string used for `NetWhitelist{bind}Permissions::TryParse`":
(https://github.com/bitcoin/bitcoin/pull/29413#issuecomment-1935284702)
If a length of 32 is insufficient, why did you choose 1000 vs 100 or 10,000?

💬 epiccurious commented on pull request "p2p: Don't process mutated blocks":
(https://github.com/bitcoin/bitcoin/pull/29412#issuecomment-1935287441)
How do you define a mutated block? What are the known forms of mutated blocks?

💬 daniel-btc-nym commented on issue "getJsonToken assumes underlying string is null-terminated but requires end pointer":
(https://github.com/bitcoin/bitcoin/issues/28260#issuecomment-1935289038)
Yeah, I ran some valgrind tests before and after my changes and it clearly showed the "uninitialized" accesses when we copy the data first into a tight vector as you suggested.

I added more test coverage and think this should be enough for this issue.

What do you think about [the changes](https://github.com/bitcoin/bitcoin/compare/master...daniel-btc-nym:bitcoin:master)

If they look OK, I can merge them into a single commit -- (I suppose by forking again?) -- and then making a pull
...

💬 epiccurious commented on pull request "lint: Check for missing bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29408#issuecomment-1935289598)
Concept ACK f4db3546c003822e485f1597701f278eef197619.

💬 epiccurious commented on pull request "build: Add missed definition for `AM_OBJCXXFLAGS`":
(https://github.com/bitcoin/bitcoin/pull/29362#issuecomment-1935291945)
utACK 2fb758da581b5cefcc0232e1b40f13143ad2bdaf

💬 araujo88 commented on pull request "rpc: getdescriptorinfo also returns normalized descriptor":
(https://github.com/bitcoin/bitcoin/pull/29396#issuecomment-1935314945)
> > I'm getting an error in one the functional tests cases in `test/functional/rpc_getdescriptorinfo.py`.
> > A fix would be changing the derivation path from `1/2h` (hardened) to `1/2` (non-hardened):
> > ```
> > - self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3Popb3qkjcJyJUGLnL4qHHoQvao8ESaAstxYSnhyswJ76uZPStJRJCTKvosUCJZL5B/1h/2)", isrange=False, issolvable=True, hasprivatekeys=False)
> > + self.test_desc("pkh(tpubD6NzVbkrYhZ4WaWSyoBvQwbpLkojyoTZPRsgXELWz3
...