💬 maflcko commented on issue "fuzz: support for Eclipser fuzzing":
(https://github.com/bitcoin/bitcoin/issues/22572#issuecomment-1934711783)
Closing for now, but pull requests with documentation on the build with Eclipser are weclome

✅ maflcko closed an issue: "Should Bitcoin Core quit when something goes wrong?"
(https://github.com/bitcoin/bitcoin/issues/22398)

💬 maflcko commented on issue "Should Bitcoin Core quit when something goes wrong?":
(https://github.com/bitcoin/bitcoin/issues/22398#issuecomment-1934716802)
Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?

✅ maflcko closed an issue: "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree"
(https://github.com/bitcoin/bitcoin/issues/22462)

💬 maflcko commented on issue "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree":
(https://github.com/bitcoin/bitcoin/issues/22462#issuecomment-1934721482)
Closing for now. Not sure what the question is, or the bug.

💬 achow101 commented on pull request "addrman, refactor: improve stochastic test in `AddSingle`":
(https://github.com/bitcoin/bitcoin/pull/27319#issuecomment-1934725357)
ACK e064487ca28c12ba774c2f43a3c7acbdb1a278c9

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483435534)
nit: and/or manual outgoing

🚀 achow101 merged a pull request: "addrman, refactor: improve stochastic test in `AddSingle`"
(https://github.com/bitcoin/bitcoin/pull/27319)

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483439607)
Ohh ok, that used to only be relevant to inbound but we are now also applying it to manual

✅ maflcko closed an issue: "memcmp with constants that contain zero bytes are broken in GCC"
(https://github.com/bitcoin/bitcoin/issues/20005)

💬 maflcko commented on issue "memcmp with constants that contain zero bytes are broken in GCC":
(https://github.com/bitcoin/bitcoin/issues/20005#issuecomment-1934742874)
Closing for now. Feel free to reopen, but I don't think anything is going to be done about gcc 10.1 and 10.2 at this point.

See also https://github.com/bitcoin/bitcoin/pull/29091

✅ maflcko closed an issue: "Flawed PROVIDE_FUZZ_MAIN_FUNCTION test"
(https://github.com/bitcoin/bitcoin/issues/28563)

💬 maflcko commented on issue "Flawed PROVIDE_FUZZ_MAIN_FUNCTION test":
(https://github.com/bitcoin/bitcoin/issues/28563#issuecomment-1934748470)
> I don't see any real practical harm in this

Let's move the discussion to https://github.com/bitcoin/bitcoin/pull/28564

📝 brunoerg opened a pull request: "fuzz: increase length of string used for `NetWhitelist{bind}Permissions::TryParse`"
(https://github.com/bitcoin/bitcoin/pull/29413)
The string `s` represents the value from `-whitelist`/`-whitebind` (e.g. "bloom,forcerelay,noban@1.2.3.4:32") and it is used in `NetWhitelistPermissions::TryParse` and `NetWhitebindPermissions::TryParse`. However, a max length of 32 is not enough to cover a lot of cases. Even disconsidering the permissions, 32 would not be enough to cover a lot of addresses. This PR fixes it.

✅ maflcko closed an issue: "Unclear documentation about TX replacements in `gettransaction`"
(https://github.com/bitcoin/bitcoin/issues/27781)

👍 maflcko approved a pull request: "test, assumeutxo: Add test to ensure failure when mempool not empty"
(https://github.com/bitcoin/bitcoin/pull/29394#pullrequestreview-1871091239)
lgtm

💬 maflcko commented on pull request "test, assumeutxo: Add test to ensure failure when mempool not empty":
(https://github.com/bitcoin/bitcoin/pull/29394#discussion_r1483492912)
please don't remove the trailing comma

💬 maflcko commented on pull request "test, assumeutxo: Add test to ensure failure when mempool not empty":
(https://github.com/bitcoin/bitcoin/pull/29394#discussion_r1483493614)
why the extra_args juggling? Isn't this set by default already?

💬 sdaftuar commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1934809271)
Updating my concept ACK. Reading through the numerous comments on this PR, the objections that have been raised have nothing to do with v3, and instead have to do with applications that might use it, and what their best design is. I think applications are free to optimize further, but this PR is not the place to do spec design of layer 2 protocols.

The way I see this issue is that RBF pinning due to the total fee requirement[^1] is a real issue for users, and has been since we first introd
...

💬 hernanmarino commented on pull request "test, assumeutxo: Add test to ensure failure when mempool not empty":
(https://github.com/bitcoin/bitcoin/pull/29394#issuecomment-1934821087)
Updated code with all suggestions.