Bitcoin Core Github
43 subscribers
122K links
Download Telegram
maflcko closed an issue: "Connection between nodes on the PC interfaces doesn't work"
(https://github.com/bitcoin/bitcoin/issues/29097)
💬 maflcko commented on issue "Connection between nodes on the PC interfaces doesn't work":
(https://github.com/bitcoin/bitcoin/issues/29097#issuecomment-1934691607)
On the server node you'll have to fully sync the chain, or disable `-minimumchainwork=<hex>` on the client.

Let us know if this is still a problem after you tried at least one of the suggested solutions.
maflcko closed an issue: "Adding a minimally-patched Guix repo to the org"
(https://github.com/bitcoin/bitcoin/issues/25098)
💬 maflcko commented on issue "Adding a minimally-patched Guix repo to the org":
(https://github.com/bitcoin/bitcoin/issues/25098#issuecomment-1934704804)
Closing (again) for now, as it is not clear if there is a need for this. Can be reopened (again) if there is one. :)
💬 TheCharlatan commented on pull request "lint: Check for missing bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29408#discussion_r1483417018)
How about this to at least filter out the easy commented lines?
```diff
diff --git a/test/lint/test_runner/src/main.rs b/test/lint/test_runner/src/main.rs
index d9950c3fba..fa5ac0a597 100644
--- a/test/lint/test_runner/src/main.rs
+++ b/test/lint/test_runner/src/main.rs
@@ -106,10 +106,16 @@ fn lint_includes_build_config() -> LintResult {
- let defines_regex = check_output(Command::new("grep").args(["undef ", "--", config_path]))
- .expect("grep failed")
- .lines()
-
...
🚀 achow101 merged a pull request: "util: Faster std::byte (pre)vector (un)serialize"
(https://github.com/bitcoin/bitcoin/pull/29114)
maflcko closed an issue: "fuzz: support for Eclipser fuzzing"
(https://github.com/bitcoin/bitcoin/issues/22572)
💬 maflcko commented on issue "fuzz: support for Eclipser fuzzing":
(https://github.com/bitcoin/bitcoin/issues/22572#issuecomment-1934711783)
Closing for now, but pull requests with documentation on the build with Eclipser are weclome
maflcko closed an issue: "Should Bitcoin Core quit when something goes wrong?"
(https://github.com/bitcoin/bitcoin/issues/22398)
💬 maflcko commented on issue "Should Bitcoin Core quit when something goes wrong?":
(https://github.com/bitcoin/bitcoin/issues/22398#issuecomment-1934716802)
Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?
maflcko closed an issue: "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree"
(https://github.com/bitcoin/bitcoin/issues/22462)
💬 maflcko commented on issue "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree":
(https://github.com/bitcoin/bitcoin/issues/22462#issuecomment-1934721482)
Closing for now. Not sure what the question is, or the bug.
💬 achow101 commented on pull request "addrman, refactor: improve stochastic test in `AddSingle`":
(https://github.com/bitcoin/bitcoin/pull/27319#issuecomment-1934725357)
ACK e064487ca28c12ba774c2f43a3c7acbdb1a278c9
💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483435534)
nit: and/or manual outgoing
🚀 achow101 merged a pull request: "addrman, refactor: improve stochastic test in `AddSingle`"
(https://github.com/bitcoin/bitcoin/pull/27319)
💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483439607)
Ohh ok, that used to only be relevant to inbound but we are now also applying it to manual
maflcko closed an issue: "memcmp with constants that contain zero bytes are broken in GCC"
(https://github.com/bitcoin/bitcoin/issues/20005)
💬 maflcko commented on issue "memcmp with constants that contain zero bytes are broken in GCC":
(https://github.com/bitcoin/bitcoin/issues/20005#issuecomment-1934742874)
Closing for now. Feel free to reopen, but I don't think anything is going to be done about gcc 10.1 and 10.2 at this point.

See also https://github.com/bitcoin/bitcoin/pull/29091
maflcko closed an issue: "Flawed PROVIDE_FUZZ_MAIN_FUNCTION test"
(https://github.com/bitcoin/bitcoin/issues/28563)
💬 maflcko commented on issue "Flawed PROVIDE_FUZZ_MAIN_FUNCTION test":
(https://github.com/bitcoin/bitcoin/issues/28563#issuecomment-1934748470)
> I don't see any real practical harm in this

Let's move the discussion to https://github.com/bitcoin/bitcoin/pull/28564