💬 achow101 commented on pull request "util: Faster std::byte (pre)vector (un)serialize":
(https://github.com/bitcoin/bitcoin/pull/29114#issuecomment-1934678359)
ACK fab41697a5448ef2861f65795bd63a4ccdda6a40

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483394708)
Sorry, my bad, looking at the diff I misinterpreted the definition of initialize that is right bellow `NetPermissions::ClearFlag` as a call to it. Disregard this commet.

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483395218)
Sorry, my bad, looking at the diff I misinterpreted the definition of initialize that is right bellow NetPermissions::ClearFlag as a call to it. Disregard this commet.

💬 maflcko commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1934682164)
Bitcoin Core makes heavy use of CPU, RAM and disk IO. Hardware defects might only become visible when running Bitcoin Core. You might want to check your hardware for defects.

* memtest86 to check your RAM
* to check the CPU behaviour under load, use linpack or Prime95
* to test your storage device use smartctl or CrystalDiskInfo

Source: https://bitcoin.stackexchange.com/a/12206

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483399472)
I guess that depends on what feedback we want to provide the user when an invalid configuration has been set (i.e. silently dropping vs being loud about it).

This is quite similar to other misconfigurations, such as setting the same permission twice, but with the particularity that it actually cannot be applied by itself, so maybe it's worth returning an error in this case

💬 delta1 commented on issue "Unclear documentation about TX replacements in `gettransaction`":
(https://github.com/bitcoin/bitcoin/issues/27781#issuecomment-1934690731)
looks like this issue can be closed as complete?

✅ maflcko closed an issue: "Connection between nodes on the PC interfaces doesn't work"
(https://github.com/bitcoin/bitcoin/issues/29097)

💬 maflcko commented on issue "Connection between nodes on the PC interfaces doesn't work":
(https://github.com/bitcoin/bitcoin/issues/29097#issuecomment-1934691607)
On the server node you'll have to fully sync the chain, or disable `-minimumchainwork=<hex>` on the client.

Let us know if this is still a problem after you tried at least one of the suggested solutions.

✅ maflcko closed an issue: "Adding a minimally-patched Guix repo to the org"
(https://github.com/bitcoin/bitcoin/issues/25098)

💬 maflcko commented on issue "Adding a minimally-patched Guix repo to the org":
(https://github.com/bitcoin/bitcoin/issues/25098#issuecomment-1934704804)
Closing (again) for now, as it is not clear if there is a need for this. Can be reopened (again) if there is one. :)

💬 TheCharlatan commented on pull request "lint: Check for missing bitcoin-config.h includes":
(https://github.com/bitcoin/bitcoin/pull/29408#discussion_r1483417018)
How about this to at least filter out the easy commented lines?
```diff
diff --git a/test/lint/test_runner/src/main.rs b/test/lint/test_runner/src/main.rs
index d9950c3fba..fa5ac0a597 100644
--- a/test/lint/test_runner/src/main.rs
+++ b/test/lint/test_runner/src/main.rs
@@ -106,10 +106,16 @@ fn lint_includes_build_config() -> LintResult {
- let defines_regex = check_output(Command::new("grep").args(["undef ", "--", config_path]))
- .expect("grep failed")
- .lines()
-
...

🚀 achow101 merged a pull request: "util: Faster std::byte (pre)vector (un)serialize"
(https://github.com/bitcoin/bitcoin/pull/29114)

✅ maflcko closed an issue: "fuzz: support for Eclipser fuzzing"
(https://github.com/bitcoin/bitcoin/issues/22572)

💬 maflcko commented on issue "fuzz: support for Eclipser fuzzing":
(https://github.com/bitcoin/bitcoin/issues/22572#issuecomment-1934711783)
Closing for now, but pull requests with documentation on the build with Eclipser are weclome

✅ maflcko closed an issue: "Should Bitcoin Core quit when something goes wrong?"
(https://github.com/bitcoin/bitcoin/issues/22398)

💬 maflcko commented on issue "Should Bitcoin Core quit when something goes wrong?":
(https://github.com/bitcoin/bitcoin/issues/22398#issuecomment-1934716802)
Is this still an issue with a recent version of Bitcoin Core? If yes, what are the steps to reproduce?

✅ maflcko closed an issue: "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree"
(https://github.com/bitcoin/bitcoin/issues/22462)

💬 maflcko commented on issue "contrib/guix/libexec/prelude.bash only works in bitcoin's worktree":
(https://github.com/bitcoin/bitcoin/issues/22462#issuecomment-1934721482)
Closing for now. Not sure what the question is, or the bug.

💬 achow101 commented on pull request "addrman, refactor: improve stochastic test in `AddSingle`":
(https://github.com/bitcoin/bitcoin/pull/27319#issuecomment-1934725357)
ACK e064487ca28c12ba774c2f43a3c7acbdb1a278c9

💬 sr-gi commented on pull request "p2p: Allow whitelisting manual connections":
(https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1483435534)
nit: and/or manual outgoing