💬 TheCharlatan commented on pull request "util: Faster std::byte (pre)vector (un)serialize":
(https://github.com/bitcoin/bitcoin/pull/29114#discussion_r1481702805)
Nit: No need for these formatting-only changes?

👍 TheCharlatan approved a pull request: "util: Faster std::byte (pre)vector (un)serialize"
(https://github.com/bitcoin/bitcoin/pull/29114#pullrequestreview-1868175505)
ACK fab41697a5448ef2861f65795bd63a4ccdda6a40

It's a nice cleanup, but I don't observe a big speedup on my machine after applying the diff and running the bench mentioned in the description on top of fab41697a5448ef2861f65795bd63a4ccdda6a40.

💬 sdaftuar commented on issue "Cluster mempool, CPFP carveout, and V3 transaction policy":
(https://github.com/bitcoin/bitcoin/issues/29319#issuecomment-1932465965)
Using a datalogging and replaying system that I have, I did some analysis of what the effect the idea of imbuing LN commitment transaction spends with v3 semantics would have had in 2023. My writeup of that is here: https://delvingbitcoin.org/t/analysis-of-attempting-to-imbue-ln-commitment-transaction-spends-with-v3-semantics/527

💬 hebasto commented on pull request "indicate explicit to the user that the wallet balances shown is watch only.":
(https://github.com/bitcoin-core/gui/pull/37#issuecomment-1932474790)
Closing due to lack of support from the author.

✅ hebasto closed a pull request: "indicate explicit to the user that the wallet balances shown is watch only."
(https://github.com/bitcoin-core/gui/pull/37)

💬 furszy commented on pull request "init: settings, do not load auto-generated warning msg":
(https://github.com/bitcoin/bitcoin/pull/29301#discussion_r1481825039)
Sure, sounds good @ryanofsky. Thanks for coming back to this!

💬 hebasto commented on pull request "debugwindow: update session ID tooltip":
(https://github.com/bitcoin-core/gui/pull/788#issuecomment-1932536186)
> When you have a v2 connection, there is always a session ID.

What if the connection type is still `DETECTING`?

The code reference:https://github.com/bitcoin-core/gui/blob/6737331c4ccc6da578bb44c809cc4e18f017ba51/src/node/connection_types.h#L83-L88

👍 jarolrod approved a pull request: "release: Update translations for v27.0 soft translation string freeze"
(https://github.com/bitcoin/bitcoin/pull/29397#pullrequestreview-1868440624)
ACK 71927b24e5aceecd8a07cdaeb916898d45486bea

Pulled in update with the update-translations.py script and and updated the source files with `make -C src translate`, with a zero-diff

🚀 hebasto merged a pull request: "Change address / amount error background"
(https://github.com/bitcoin-core/gui/pull/553)

✅ hebasto closed a pull request: "Bugfix: When restoring table columns, still set their minimum column width and stretch on last section"
(https://github.com/bitcoin-core/gui/pull/368)

💬 hebasto commented on pull request "Bugfix: When restoring table columns, still set their minimum column width and stretch on last section":
(https://github.com/bitcoin-core/gui/pull/368#issuecomment-1932610148)
Closing due to lack of activity.

💬 araujo88 commented on pull request "test: handle wallet_reorgrestore.py failed":
(https://github.com/bitcoin/bitcoin/pull/29395#issuecomment-1932611938)
> The issue is a race, so it is not deterministically reproducible. Usually, to deterministically reproduce it on all hardware, a sleep will have to be added in the right place in the source code or test code.
>
> A pull request will either have to explain where to put the sleep, or, if not possible, come up with a plausible explanation how the race could happen. Also, the pull request should explain if the bug is in the wallet code or in the test code, in which case the fix should be applied
...

📝 theuni opened a pull request: "bitcoin-config.h includes cleanup"
(https://github.com/bitcoin/bitcoin/pull/29404)
As mentioned in https://github.com/bitcoin/bitcoin/pull/26924#issuecomment-1403449932 and https://github.com/bitcoin/bitcoin/pull/29263#issuecomment-1922334399, it is currently not safe to remove `bitcoin-config.h` includes from headers because some unrelated file might be depending on it.

See also #26972 for discussion.

Solve this by including the file directly everywhere it's required, regardless of whether or not it's already included by another header.

I'm afraid it's a bit tedious
...

💬 theuni commented on pull request "bitcoin-config.h includes cleanup":
(https://github.com/bitcoin/bitcoin/pull/29404#issuecomment-1932625675)
Ping @maflcko

This (or something like it) is a prerequisite for #29404.

There doesn't seem to be any sane way to make this a scripted diff or a clang-tidy transform, so it would be great if someone could reproduce my results.

💬 mzumsande commented on pull request "test: use v2 everywhere for P2PConnection if --v2transport is enabled":
(https://github.com/bitcoin/bitcoin/pull/29358#discussion_r1481918788)
fixed

💬 mzumsande commented on pull request "test: use v2 everywhere for P2PConnection if --v2transport is enabled":
(https://github.com/bitcoin/bitcoin/pull/29358#discussion_r1481919762)
good point, done something similar.

💬 mzumsande commented on pull request "test: use v2 everywhere for P2PConnection if --v2transport is enabled":
(https://github.com/bitcoin/bitcoin/pull/29358#issuecomment-1932645404)
I have addressed feedback and squashed several test fixes into the last commit, so that the "test each commit" CI is hopefully green now. I have an unsquashed version at https://github.com/mzumsande/bitcoin/tree/202401_bip324_alltests_unsquashed, in case that helps with review.

💬 glozow commented on pull request "test: handle wallet_reorgrestore.py failed":
(https://github.com/bitcoin/bitcoin/pull/29395#issuecomment-1932649179)
> In my understanding, this race condition arises from asynchronous block processing and transaction validation. Specifically, it occurs during the blockchain reorganization process when nodes are reconnected, and their blockchains are synchronized to establish a consensus chain. The asynchronous nature of this process introduces a timing issue where the state of transactions might not be fully updated before the test assertions are executed. This leads to a discrepancy in the expected outcome o
...

👋 mzumsande's pull request is ready for review: "test: use v2 everywhere for P2PConnection if --v2transport is enabled"
(https://github.com/bitcoin/bitcoin/pull/29358)

⚠️ vuccixx21 opened an issue: "Kalm m"
(https://github.com/bitcoin/bitcoin/issues/29405)