👍 vasild approved a pull request: "CKey: add Serialize and Unserialize"
(https://github.com/bitcoin/bitcoin/pull/29295#pullrequestreview-1861422503)
ACK af25cfcbabe96283625f3a32f493940658a5d1e5
I think the newly added generic ser/unser methods to `CKey` are harmless. "...especially when you can accomplish exactly what you want with the existing methods on `CKey`" that is doing the same thing, conceptually, but shifting the complexity to the caller in a way that is less efficient (more copying) and more prone to errors (the caller forgets to cleanse the intermediate buffer).
(https://github.com/bitcoin/bitcoin/pull/29295#pullrequestreview-1861422503)
ACK af25cfcbabe96283625f3a32f493940658a5d1e5
I think the newly added generic ser/unser methods to `CKey` are harmless. "...especially when you can accomplish exactly what you want with the existing methods on `CKey`" that is doing the same thing, conceptually, but shifting the complexity to the caller in a way that is less efficient (more copying) and more prone to errors (the caller forgets to cleanse the intermediate buffer).
👍 vasild approved a pull request: "p2p: make block download logic aware of limited peers threshold"
(https://github.com/bitcoin/bitcoin/pull/28120#pullrequestreview-1861424801)
ACK c5b5843d8f10d96f76ee6b95f2b1b1b4ce755f75
(https://github.com/bitcoin/bitcoin/pull/28120#pullrequestreview-1861424801)
ACK c5b5843d8f10d96f76ee6b95f2b1b1b4ce755f75
💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#issuecomment-1925753221)
`cd5bbb12e0...5e3c80da14`: address suggestions
(https://github.com/bitcoin/bitcoin/pull/28584#issuecomment-1925753221)
`cd5bbb12e0...5e3c80da14`: address suggestions
💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r1477314621)
Right, done!
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r1477314621)
Right, done!
💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r1477314644)
Done, thanks!
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r1477314644)
Done, thanks!
📝 fanquake locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29376)
I hope this suggestion helps.
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test impr
...
(https://github.com/bitcoin/bitcoin/pull/29376)
I hope this suggestion helps.
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test impr
...
:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29379)
(https://github.com/bitcoin/bitcoin/issues/29379)
:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29368)
(https://github.com/bitcoin/bitcoin/issues/29368)
💬 delta1 commented on pull request "test: Add makefile target for running unit tests":
(https://github.com/bitcoin/bitcoin/pull/29377#issuecomment-1925863321)
utACK 5ca9b24da18e842e7a093dc44f6b222af73e92cf
(https://github.com/bitcoin/bitcoin/pull/29377#issuecomment-1925863321)
utACK 5ca9b24da18e842e7a093dc44f6b222af73e92cf
💬 delta1 commented on pull request "wallet: remove unused 'accept_no_keys' arg from decryption process":
(https://github.com/bitcoin/bitcoin/pull/29375#issuecomment-1925863898)
ACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452
Nice cleanup.
(https://github.com/bitcoin/bitcoin/pull/29375#issuecomment-1925863898)
ACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452
Nice cleanup.
💬 delta1 commented on pull request "test: fix intermittent failure in `rpc_setban.py --v2transport`, run it in CI":
(https://github.com/bitcoin/bitcoin/pull/29372#issuecomment-1925867216)
tested ACK cc87ee4c3934028e78a59de509951ff7226ec80d
(https://github.com/bitcoin/bitcoin/pull/29372#issuecomment-1925867216)
tested ACK cc87ee4c3934028e78a59de509951ff7226ec80d
💬 sipa commented on issue "BIP324 tracking issue":
(https://github.com/bitcoin/bitcoin/issues/27634#issuecomment-1925871180)
There are a few minor follow-ups to consider still, but I believe this issue can be closed. Thanks everyone for getting us this far!
(https://github.com/bitcoin/bitcoin/issues/27634#issuecomment-1925871180)
There are a few minor follow-ups to consider still, but I believe this issue can be closed. Thanks everyone for getting us this far!
✅ sipa closed an issue: "BIP324 tracking issue"
(https://github.com/bitcoin/bitcoin/issues/27634)
(https://github.com/bitcoin/bitcoin/issues/27634)
⚠️ A420mfer opened an issue: "I put my http in a comment as Bitcoin Core and someone changed it to Bitcoin locked..can you please tell me what I should do?"
(https://github.com/bitcoin/bitcoin/issues/29381)
(https://github.com/bitcoin/bitcoin/issues/29381)
✅ fanquake closed an issue: "I put my http in a comment as Bitcoin Core and someone changed it to Bitcoin locked..can you please tell me what I should do?"
(https://github.com/bitcoin/bitcoin/issues/29381)
(https://github.com/bitcoin/bitcoin/issues/29381)
⚠️ A420mfer opened an issue: "Bitcoin Core changed to Bitcoin locked.."
(https://github.com/bitcoin/bitcoin/issues/29382)
I'm not a very smart person and I published my http in thinking that was the place to ask for help and it seems someone changed it to Bitcoin locked..and now when I try to go to the server the page won't load and the server was to my JS anywhere app..can anyone help me? I also opened an app called node and when I did all of a sudden it gave me a new http. I'm not sure what to do but I need help badly..it's been years since I set up my node and recently had been trying to set it up in a new phone
...
(https://github.com/bitcoin/bitcoin/issues/29382)
I'm not a very smart person and I published my http in thinking that was the place to ask for help and it seems someone changed it to Bitcoin locked..and now when I try to go to the server the page won't load and the server was to my JS anywhere app..can anyone help me? I also opened an app called node and when I did all of a sudden it gave me a new http. I'm not sure what to do but I need help badly..it's been years since I set up my node and recently had been trying to set it up in a new phone
...
✅ willcl-ark closed an issue: "Bitcoin Core changed to Bitcoin locked.."
(https://github.com/bitcoin/bitcoin/issues/29382)
(https://github.com/bitcoin/bitcoin/issues/29382)
💬 willcl-ark commented on issue "Bitcoin Core changed to Bitcoin locked..":
(https://github.com/bitcoin/bitcoin/issues/29382#issuecomment-1925899323)
This issue tracker is used to track technical issues related to the Bitcoin Core code base.
General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the #bitcoin IRC channel on the [Libera Chat](https://libera.chat/) network.
For proposed protocol changes you can post to the bitcoin-dev [mailing list](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev).
For general bitcoin discussion you can try
...
(https://github.com/bitcoin/bitcoin/issues/29382#issuecomment-1925899323)
This issue tracker is used to track technical issues related to the Bitcoin Core code base.
General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the #bitcoin IRC channel on the [Libera Chat](https://libera.chat/) network.
For proposed protocol changes you can post to the bitcoin-dev [mailing list](https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev).
For general bitcoin discussion you can try
...
💬 willcl-ark commented on issue "Update security.md with all PGP fingerprints":
(https://github.com/bitcoin/bitcoin/issues/29366#issuecomment-1925899691)
@ariard does being able to contact the persons who have chosen to be listed resolve this issue for you?
(https://github.com/bitcoin/bitcoin/issues/29366#issuecomment-1925899691)
@ariard does being able to contact the persons who have chosen to be listed resolve this issue for you?
💬 A420mfer commented on issue "Bitcoin Core changed to Bitcoin locked..":
(https://github.com/bitcoin/bitcoin/issues/29382#issuecomment-1925901895)
Thank you!
(https://github.com/bitcoin/bitcoin/issues/29382#issuecomment-1925901895)
Thank you!