💬 tdb3 commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#discussion_r1473700874)
## Action (5): __Successfully executed response, legacy behavior retained__
`curl --user test --data-binary '{"jsonrpc":"1.0","method":"getblockchaininfo","id":"tester"}' -H 'content-type: text/plain;' http://127.0.0.1:38332/`

Result: Successfully executed response

v26.0 behavior: `{"result":{"chain":"signet","blocks":4320,"headers":4320,"bestblockhash":"0000013e07d388dd5c8cb66c990caa546fc04e7533cad18c27ed3d603f37a6c0","difficulty":0.001127075738664131,"time":1706750596,"mediantime":17067
...

⚠️ starius opened an issue: "build warnings in outputtype.cpp: may be used uninitialized"
(https://github.com/bitcoin/bitcoin/issues/29359)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Building Bitcoin Core from source using official instructions from https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md I got compilation warnings, complaining about may be used uninitialized variables in two destructors.

Log of `make -j 10`:
[bitcoin-compilation-warning-master.txt](https://github.com/bitcoin/bitcoin/files/14119565/bitcoin-compilation-warning-master.txt)


...

💬 hernanmarino commented on pull request "Modify command line help to show support for BIP21 URIs":
(https://github.com/bitcoin-core/gui/pull/752#discussion_r1473761422)
Done

💬 hernanmarino commented on pull request "Modify command line help to show support for BIP21 URIs":
(https://github.com/bitcoin-core/gui/pull/752#discussion_r1473761491)
Done

💬 hernanmarino commented on pull request "Modify command line help to show support for BIP21 URIs":
(https://github.com/bitcoin-core/gui/pull/752#issuecomment-1920456532)
Fixed the 2 typos mentioned by @luke-jr and @kristapsk . Also rebased for CI.

💬 hernanmarino commented on pull request "Modify command line help to show support for BIP21 URIs":
(https://github.com/bitcoin-core/gui/pull/752#issuecomment-1920461069)
Fixed the 2 typos mentioned by @luke-jr and @kristapsk . Also rebased for CI.

💬 stratospher commented on pull request "test: use v2 everywhere for P2PConnection if --v2transport is enabled":
(https://github.com/bitcoin/bitcoin/pull/29358#issuecomment-1920563086)
> Hmm, "test each commit fails" The problem is that commit https://github.com/bitcoin/bitcoin/commit/606f4f32014f029a6999d7f94b7231fefafdf55f (which switches P2PConnection to v2 by default) is enabled last. It might be best to squash everything into one big commit (even if that might make review a bit harder) or I'd have to add some temporary workarounds. Opinions?

would reordering the commits to keep the last commit as first commit work? reviewing is definitely easier with separate commits.

💬 maflcko commented on issue "build warnings in outputtype.cpp: may be used uninitialized":
(https://github.com/bitcoin/bitcoin/issues/29359#issuecomment-1920779707)
I guess regardless of the g++ version used on Ubuntu or Debian, some kind of false positive warnings will be printed. I wonder why g++ on other distros does not print those warnings.

👍 MarnixCroes approved a pull request: "Modify command line help to show support for BIP21 URIs"
(https://github.com/bitcoin-core/gui/pull/752#pullrequestreview-1855939371)
ack ede5014c445dcb40ddcfdede2c51236bbfe85f5e

💬 maflcko commented on pull request "log: Nuke error(...)":
(https://github.com/bitcoin/bitcoin/pull/29236#issuecomment-1920925835)
rebased

⚠️ maflcko opened an issue: "ci: Android NDK has too old libc++"
(https://github.com/bitcoin/bitcoin/issues/29360)
The android CI task fails because the embedded libc++ in the NDK is too old.

Can it be bumped?

💬 maflcko commented on issue "ci: Android NDK has too old libc++":
(https://github.com/bitcoin/bitcoin/issues/29360#issuecomment-1920972420)
Reference:

```
./util/fs.h:65:30: error: no matching constructor for initialization of 'const std::u8string &' (aka 'const basic_string<char8_t> &')
const std::u8string& utf8_str{std::filesystem::path::u8string()};
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/ci_container_base/depends/SDKs/android/ndk/23.2.8568313/toolchains/llvm/prebuilt/linux-x86_64/bin/../sysroot/usr/include/c++/v1/string:794:40: note: candidate constructor not viable: no known conv
...

👍 kristapsk approved a pull request: "Modify command line help to show support for BIP21 URIs"
(https://github.com/bitcoin-core/gui/pull/752#pullrequestreview-1856201976)
utACK ede5014c445dcb40ddcfdede2c51236bbfe85f5e

⚠️ Xaspr reopened an issue: "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error"
(https://github.com/bitcoin/bitcoin/issues/29255)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

After installing Bitcoin Core 26.0 in Windows Pro 11 and starting IBD, Core crashes.

I know Windows might not be exactly ideal, but I like to run a pruned node on my work laptop as well. I didn't set pruning yet by the way, I started Core just with the standard settings.

Bitcoin Core crashes and the following error pops up in debug.log:

`ERROR: ReadBlockFromDisk: Deserialize or
...

💬 Xaspr commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1921081600)
Not sure if related, but I'm still running into issues. I've tried a lot by now, from changing antivirus program, disabling antivirus and anti-malware, checking CPU temperature, checking SSD integrity, updating firmware, updating BIOS, trying older versions of Bitcoin Core and more.

This specific data corruption error hasn't come up the last few attempts to get to IBD. But often after stopping Core and starting it up again, I get the message that I should reindex. This seems to be a problem
...

💬 maflcko commented on issue "Unable to sync blockchain on laptop: ERROR: ReadBlockFromDisk: Deserialize or I/O error":
(https://github.com/bitcoin/bitcoin/issues/29255#issuecomment-1921094517)
> It's may still be antivirus software that's persistent in interfering with Core.

It would be good to check this. If you have a completely separate machine, you could try to install the "anti"-virus software there and see if the issue happens?

Other than that, I believe this is a caused by overheating. It may be possible that the CPU itself happens to work under high heat as part of a benchmark or stress test. Also, other hardware components are fine by themselves as part of a benchmark o
...

📝 maflcko opened a pull request: "refactor: Fix timedata includes"
(https://github.com/bitcoin/bitcoin/pull/29361)
Remove unused includes. Also, fixup comments, see https://github.com/bitcoin/bitcoin/pull/28956/files#r1464827885. Also, add missing includes to `chain.h` while touching it.

📝 hebasto opened a pull request: "build: Add missed definition for `AM_OBJCXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/29362)
This PR adds the missed definition for `AM_OBJCXXFLAGS` which has the same value as `AM_CXXFLAGS`.

Otherwise, the compiling flags used by Objective C++ (for `.mm` source files) differ from C++ ones including hardening, debug, warning etc options.

✅ dergoegge closed a pull request: "wip: Split fuzz binary"
(https://github.com/bitcoin/bitcoin/pull/29010)

💬 dergoegge commented on pull request "wip: Split fuzz binary":
(https://github.com/bitcoin/bitcoin/pull/29010#issuecomment-1921159121)
I'll re-open this once we switched to cmake.

I've rebased the commits on the current cmake staging branch and building individual binaries using cmake is quite easy (assuming there is one harness per file):

```cmake
file(GLOB fuzz_harness_file_list RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "./*.cpp")
# Remove fuzz.cpp and util.cpp as they don't contain fuzz harnesses
list(REMOVE_ITEM fuzz_harness_file_list "fuzz.cpp")
list(REMOVE_ITEM fuzz_harness_file_list "util.cpp")

foreach(
...