⚠️ techy2 opened an issue: "loadtxoutset fails to recognize assumeutxo blockhash"
(https://github.com/bitcoin/bitcoin/issues/29340)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Unable to load UTXO snapshot, assumeutxo block hash in snapshot metadata not
recognized (00000000000000000000d4041fe771edd9dcb945bb85dfa739af1d2724a464e8)
(code -32603)
### Expected behaviour
expect txoutset to load properly
after researching issues, can't tell if this is new or has been recently fixed, so reporting as new
### Steps to reproduce
on 64 bit ubuntu bionic bitcoin-q
...
(https://github.com/bitcoin/bitcoin/issues/29340)
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Unable to load UTXO snapshot, assumeutxo block hash in snapshot metadata not
recognized (00000000000000000000d4041fe771edd9dcb945bb85dfa739af1d2724a464e8)
(code -32603)
### Expected behaviour
expect txoutset to load properly
after researching issues, can't tell if this is new or has been recently fixed, so reporting as new
### Steps to reproduce
on 64 bit ubuntu bionic bitcoin-q
...
💬 dzyphr commented on pull request "Make provably unsignable standard P2PK and P2MS outpoints unspendable.":
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913753758)
> So this would make all current and future STAMPS unspendable? Or just future ones? How would this affect other potential legitimate use cases?
>
> What is the projected growth of node requirements if this situation were to get worse and how does that track with Moore's Law of the increase in computer performance? Or is there a better way to think about this?
>
> It's worth noting, making these unspendable may not stop their proliferation. For example, solutions that allow you to trade pr
...
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913753758)
> So this would make all current and future STAMPS unspendable? Or just future ones? How would this affect other potential legitimate use cases?
>
> What is the projected growth of node requirements if this situation were to get worse and how does that track with Moore's Law of the increase in computer performance? Or is there a better way to think about this?
>
> It's worth noting, making these unspendable may not stop their proliferation. For example, solutions that allow you to trade pr
...
✅ achow101 closed an issue: "loadtxoutset fails to recognize assumeutxo blockhash"
(https://github.com/bitcoin/bitcoin/issues/29340)
(https://github.com/bitcoin/bitcoin/issues/29340)
💬 achow101 commented on issue "loadtxoutset fails to recognize assumeutxo blockhash":
(https://github.com/bitcoin/bitcoin/issues/29340#issuecomment-1913754353)
Loaded utxo sets need to match hardcoded utxo set and block hashes. These are currently not set for mainnet and so `loadtxoutset` is not expected to work on mainnet.
(https://github.com/bitcoin/bitcoin/issues/29340#issuecomment-1913754353)
Loaded utxo sets need to match hardcoded utxo set and block hashes. These are currently not set for mainnet and so `loadtxoutset` is not expected to work on mainnet.
💬 dooglus commented on issue "New crash in v26.0":
(https://github.com/bitcoin-core/gui/issues/785#issuecomment-1913757550)
> It seems you are running a prune node. Please with the logs, provide your bitcoin.conf values (hiding the sensitive information).
This is what's in the pruned node's bitcoin.conf:
```
connect=localhost
prune=555
addresstype=bech32
keypool=10
upnp=0
spendzeroconfchange=1
avoidpartialspends=1
server=1
daemon=0
checkblocks=1
checklevel=0
logips=1
rpcport=8550
port=8551
wallet=a
wallet=b
wallet=c
wallet=d
deprecatedrpc=accounts
rpcuser=user
rpcpassword=pass
rpcauth=u1:p
...
(https://github.com/bitcoin-core/gui/issues/785#issuecomment-1913757550)
> It seems you are running a prune node. Please with the logs, provide your bitcoin.conf values (hiding the sensitive information).
This is what's in the pruned node's bitcoin.conf:
```
connect=localhost
prune=555
addresstype=bech32
keypool=10
upnp=0
spendzeroconfchange=1
avoidpartialspends=1
server=1
daemon=0
checkblocks=1
checklevel=0
logips=1
rpcport=8550
port=8551
wallet=a
wallet=b
wallet=c
wallet=d
deprecatedrpc=accounts
rpcuser=user
rpcpassword=pass
rpcauth=u1:p
...
🤔 murchandamus reviewed a pull request: "wallet: Add CoinGrinder coin selection algorithm"
(https://github.com/bitcoin/bitcoin/pull/27877#pullrequestreview-1847632560)
Addressed most of @sipa’s feedback except for two things I’m still mulling over
(https://github.com/bitcoin/bitcoin/pull/27877#pullrequestreview-1847632560)
Addressed most of @sipa’s feedback except for two things I’m still mulling over
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468939798)
Good catch, fixed.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468939798)
Good catch, fixed.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468939922)
Sure, makes sense.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468939922)
Sure, makes sense.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941852)
Thanks, fixed up the sentence.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941852)
Thanks, fixed up the sentence.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941377)
Added descriptions
```cpp
// The current selection and the best input set found so far, stored as the utxo_pool indices of the UTXOs forming them
std::vector<size_t> curr_selection;
std::vector<size_t> best_selection;
// The currently selected effective amount, and the effective amount of the best selection so far
CAmount curr_amount = 0;
CAmount best_selection_amount = MAX_MONEY;
// The weight of the currently selected input set, and the weight of the best selection
int curr_weig
...
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941377)
Added descriptions
```cpp
// The current selection and the best input set found so far, stored as the utxo_pool indices of the UTXOs forming them
std::vector<size_t> curr_selection;
std::vector<size_t> best_selection;
// The currently selected effective amount, and the effective amount of the best selection so far
CAmount curr_amount = 0;
CAmount best_selection_amount = MAX_MONEY;
// The weight of the currently selected input set, and the weight of the best selection
int curr_weig
...
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468960861)
That would be good, but that would take more time than I have right now. Will leave this open for the moment.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468960861)
That would be good, but that would take more time than I have right now. Will leave this open for the moment.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468947001)
This seems correct to me, and I’ve fuzzed it for five hours without failure for good measure. This changes a number of commits, in different ways, still pondering whether it’s best to put into the first implementation or to amend the commit that optimizes handling of max_weight. Will revisit.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468947001)
This seems correct to me, and I’ve fuzzed it for five hours without failure for good measure. This changes a number of commits, in different ways, still pondering whether it’s best to put into the first implementation or to amend the commit that optimizes handling of max_weight. Will revisit.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941448)
Hah, thanks, fixed.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468941448)
Hah, thanks, fixed.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468960224)
Great idea. I’ve amended the fuzz test to exit early if there are insufficient funds, otherwise brute force the solution, and then run CG twice.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468960224)
Great idea. I’ve amended the fuzz test to exit early if there are insufficient funds, otherwise brute force the solution, and then run CG twice.
💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468966253)
Good catch, thanks.
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1468966253)
Good catch, thanks.
💬 techy2 commented on issue "loadtxoutset fails to recognize assumeutxo blockhash":
(https://github.com/bitcoin/bitcoin/issues/29340#issuecomment-1913849142)
The release notes indicate this is a new feature, it does not mention that it is not expected to work. Looks like a nice feature. You should clarify the release notes PLEASE.
[bitcoin](https://github.com/bitcoin/bitcoin/tree/master)/[doc](https://github.com/bitcoin/bitcoin/tree/master/doc)/[release-notes](https://github.com/bitcoin/bitcoin/tree/master/doc/release-notes)
/release-notes-26.0.md
New RPCs
loadtxoutset has been added, which allows loading a UTXO snapshot of the format g
...
(https://github.com/bitcoin/bitcoin/issues/29340#issuecomment-1913849142)
The release notes indicate this is a new feature, it does not mention that it is not expected to work. Looks like a nice feature. You should clarify the release notes PLEASE.
[bitcoin](https://github.com/bitcoin/bitcoin/tree/master)/[doc](https://github.com/bitcoin/bitcoin/tree/master/doc)/[release-notes](https://github.com/bitcoin/bitcoin/tree/master/doc/release-notes)
/release-notes-26.0.md
New RPCs
loadtxoutset has been added, which allows loading a UTXO snapshot of the format g
...
💬 theStack commented on pull request "Make provably unsignable standard P2PK and P2MS outpoints unspendable.":
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913871919)
Fun challenge for everyone: can you link to a specific bare multisig UTXO that has been created within the past year (let's say, since block 769785) where the prunable detection in this PR would hit? Looking at an UTXO snapshot from now (block 827855), from all the 749496 P2MS UTXOs that have been created since the start of the year 2023, I haven't managed to find a _single_ one which is provably unspendable.
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913871919)
Fun challenge for everyone: can you link to a specific bare multisig UTXO that has been created within the past year (let's say, since block 769785) where the prunable detection in this PR would hit? Looking at an UTXO snapshot from now (block 827855), from all the 749496 P2MS UTXOs that have been created since the start of the year 2023, I haven't managed to find a _single_ one which is provably unspendable.
💬 dzyphr commented on pull request "Make provably unsignable standard P2PK and P2MS outpoints unspendable.":
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913883771)
> Fun challenge for everyone: can you link to a specific bare multisig UTXO that has been created within the past year (let's say, since block 769785) where the prunable detection in this PR would hit? Looking at an UTXO snapshot from now (block 827855), from all the 749496 P2MS UTXOs that have been created since the start of the year 2023, I haven't managed to find a _single_ one which is provably unspendable.
they have provided a list: https://gist.github.com/russeree/85fb9519e0a1fc166177a6
...
(https://github.com/bitcoin/bitcoin/pull/28400#issuecomment-1913883771)
> Fun challenge for everyone: can you link to a specific bare multisig UTXO that has been created within the past year (let's say, since block 769785) where the prunable detection in this PR would hit? Looking at an UTXO snapshot from now (block 827855), from all the 749496 P2MS UTXOs that have been created since the start of the year 2023, I haven't managed to find a _single_ one which is provably unspendable.
they have provided a list: https://gist.github.com/russeree/85fb9519e0a1fc166177a6
...
💬 ryanofsky commented on pull request "Improve new LogDebug/Trace/Info/Warning/Error Macros":
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1913911460)
re: https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1910905907
> But if making the log parameter optional is a requirement for you, it should be possible to implement that here and never increase verbosity in any case.
It turns out making the category argument completely optional is not too hard to implement: 69e69b2a82c95f8040be093a29e5f84c37641f3a. So you could write:
```c++
LogWarning("uncategorizable warning")
```
instead of
```
LogWarning({}, "uncategorizable
...
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1913911460)
re: https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1910905907
> But if making the log parameter optional is a requirement for you, it should be possible to implement that here and never increase verbosity in any case.
It turns out making the category argument completely optional is not too hard to implement: 69e69b2a82c95f8040be093a29e5f84c37641f3a. So you could write:
```c++
LogWarning("uncategorizable warning")
```
instead of
```
LogWarning({}, "uncategorizable
...
💬 ajtowns commented on pull request "Improve new LogDebug/Trace/Info/Warning/Error Macros":
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1913991867)
> And if you have ideas on how the harms you see could be avoided, while the problems I am trying to solve (see "Problems this PR attempts to solve" in the PR description) could be addressed,
I think the problem you are actually attempting to solve is ["I, ryanofsky, find this weird and I don't like it"](https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1450411706), and I don't think code changes are the way of solving that, any more than code changes are the right way to solve the p
...
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-1913991867)
> And if you have ideas on how the harms you see could be avoided, while the problems I am trying to solve (see "Problems this PR attempts to solve" in the PR description) could be addressed,
I think the problem you are actually attempting to solve is ["I, ryanofsky, find this weird and I don't like it"](https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1450411706), and I don't think code changes are the way of solving that, any more than code changes are the right way to solve the p
...