💬 maflcko commented on pull request "refactor: Compile unreachable walletdb code":
(https://github.com/bitcoin/bitcoin/pull/29315#issuecomment-1910133709)
Can be tested by adding a compile failure to the unreachable code. On master compilation passes, here it fails.

👍 maflcko approved a pull request: "ci: Update cache action"
(https://github.com/bitcoin/bitcoin/pull/29313#pullrequestreview-1843645352)
lgtm

💬 maflcko commented on pull request "validation: improve checkblockindex comments":
(https://github.com/bitcoin/bitcoin/pull/29299#issuecomment-1910156794)
ACK 9819db4ccaa03519a78d4d9ecce9f89f5be669e5 🌦

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK 9819db4ccaa03519a78d4d9ecc
...

💬 maflcko commented on issue "make cov fails with lcov-2":
(https://github.com/bitcoin/bitcoin/issues/28468#issuecomment-1910192420)
> but it's still broken

Same here. Is there an upstream bug report?

💬 torkelrogstad commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#discussion_r1466378645)
Sorry, I don't understand what you mean. Do you want me to use one of the functions in `strencodings` to manipulate the `fee_rate` parameter before sending it to `options.pushKV`?

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1466391538)
fixed

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1466392222)
I'll leave this as an ergonomics issue for later debate

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#issuecomment-1910238997)
didn't see any fuzzer crashes locally, all comments addressed

💬 torkelrogstad commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#issuecomment-1910256641)
Rebased, let's see if that solves the CI failure.

💬 ismaelsadeeq commented on pull request "rpc: validate fee estimation mode case insensitive":
(https://github.com/bitcoin/bitcoin/pull/29175#discussion_r1466426175)
I meant Import what you use.
`ToLower()` function is declared here.
https://github.com/bitcoin/bitcoin/blob/4ad83ef09b772f3f1e8ea9ea3a8c43dcd9db8458/src/util/strencodings.h#L327

🤔 furszy reviewed a pull request: "test: ensure output is large enough to pay for its fees"
(https://github.com/bitcoin/bitcoin/pull/29283#pullrequestreview-1843832314)
utACK 3bfc5bd36

💬 furszy commented on pull request "test: ensure output is large enough to pay for its fees":
(https://github.com/bitcoin/bitcoin/pull/29283#discussion_r1466431816)
Maybe:
```suggestion
# Ensure output is large enough to pay for its fees. Following transactions will contain one input and one unspendable output. Conservatively assuming...
```

Also, just as an extra note (no need to do it): could calculate the floor in a more dynamic manner if you want. The input type is known here, and the future tx is always fixed to be a 1 input, 1 bech32 output tx.

💬 Sjors commented on pull request "CKey: add Serialize and Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#issuecomment-1910300031)
Switched to the approach suggested by @vasild. Also supports uncompressed keys. Added test.

Keeping this draft pending #29307.

👋 Sjors's pull request is ready for review: "CKey: add Serialize and Unserialize"
(https://github.com/bitcoin/bitcoin/pull/29295)

💬 Sjors commented on pull request "CKey: add Serialize and Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#issuecomment-1910305918)
Come to think of it, this PR only changes serialization, while #29307 deals with storage. So this is ready for review.

💬 fanquake commented on pull request "depends: Do not override `CFLAGS` when building SQLite with `DEBUG=1`":
(https://github.com/bitcoin/bitcoin/pull/29287#issuecomment-1910315057)
oss-fuzz PR: https://github.com/google/oss-fuzz/pull/11540

💬 stickies-v commented on pull request "test: ensure output is large enough to pay for its fees":
(https://github.com/bitcoin/bitcoin/pull/29283#discussion_r1466450971)
Thx, will consider if I need to retouch!

🚀 fanquake merged a pull request: "ci: Update cache action"
(https://github.com/bitcoin/bitcoin/pull/29313)

💬 chrisguida commented on pull request "Add a `-permitbarepubkey` option":
(https://github.com/bitcoin/bitcoin/pull/29309#issuecomment-1910328432)
Concept ACK, it's great to give users the option of filtering out potentially abusive txs :+1:

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466462619)
Oh, this is only available in Noble? In that case I might just improve the code comment (including `sleep`) and add a note that can go away with Noble.