✅ fanquake closed an issue: "Fido2 lock after 21 Million Mint "
(https://github.com/bitcoin/bitcoin/issues/29310)

💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#discussion_r1466111038)
Thanks! My formatter is having some difficulty with diff/range-based formatting at the moment. Fixed.

💬 willcl-ark commented on pull request "init: Add option for rpccookie permissions (replace 26088)":
(https://github.com/bitcoin/bitcoin/pull/28167#discussion_r1466112815)
IMO list comprehensions are fine, but seeing as I voided half the point of using one (creating a one-liner), so took the change to a regular for loop in 7516e9120e202395dabebd5b7212d9c2d3787c43

✅ willcl-ark closed an issue: "followups: Various potential improvements arising out of chainman-deglobalizing review"
(https://github.com/bitcoin/bitcoin/issues/21766)

💬 willcl-ark commented on issue "followups: Various potential improvements arising out of chainman-deglobalizing review":
(https://github.com/bitcoin/bitcoin/issues/21766#issuecomment-1909787062)
Going to close this tracking issue as all of the changes listed in OP are now merged.

⚠️ mmaryo opened an issue: "Unable to open wallet UI with ubuntu 23.10"
(https://github.com/bitcoin/bitcoin/issues/29311)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Hello,
I noticed that the UI does not open.


### Expected behaviour

to open the UI

### Steps to reproduce

I copy past the command of the shortcut
`env BAMF_DESKTOP_FILE_HINT=/var/lib/snapd/desktop/applications/bitcoin-core_bitcoin-qt.desktop /snap/bin/bitcoin-core.qt %u`
in a terminal

The terminal output of the command line
`Fontconfig warning: FcPattern object weight does n
...

🚀 fanquake merged a pull request: "build: always set `-g -O2` in `CORE_CXXFLAGS`"
(https://github.com/bitcoin/bitcoin/pull/29205)

💬 hebasto commented on pull request "Avoid non-self-contained Windows header":
(https://github.com/bitcoin-core/gui/pull/789#discussion_r1466158566)
> Comment should be removed?

Thanks! Done.

💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#discussion_r1466158963)
Glad something useful came out of this PR :-)

💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#discussion_r1466160913)
@vasild I would also prefer to fix things in AutoFile, but perhaps add a few comments to explain what happens?

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466162584)
It was intentionally vague, because I might just be doing something else wrong. I'll read @maflcko's suggestion.

💬 Sjors commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466164116)
Without that command I got the same behavior as if the command wasn't there. Presumably it's asynchronous and we somehow have to wait for it. Maybe the above solution avoids the problem altogether.

💬 Sjors commented on pull request "CKey: add Serialize and Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#discussion_r1466165495)
Good point.

💬 maflcko commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909861017)
> Also I follow this https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions

There is no need to install dependencies for already packaged Bitcoin Core, since it has the dependencies bundled.



> Fontconfig warning: FcPattern object weight does not accept value [0 205) [1]

This issue tracker does not provide fontconfig support, but you can try a search engine of your choice to track down the issue and solutions. It may be related to the fontconfi
...

💬 fanquake commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909863507)
Close or move to GUI repo? cc @hebasto

💬 maflcko commented on pull request "Support self-hosted Cirrus workers on forks (and multi-user)":
(https://github.com/bitcoin/bitcoin/pull/29274#discussion_r1466174158)
Looks like https://packages.ubuntu.com/noble/podman and https://packages.debian.org/trixie/podman includes the fixed `--replace`, so might try that at one point.

💬 mmaryo commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909908601)
Hello
Thank you
this command line works
https://github.com/keshavbhatt/olivia/issues/95#issuecomment-774747492

But my wallet is empty?


May I find it somewhere else?
Are there logs?

💬 maflcko commented on issue "Unable to open wallet UI with ubuntu 23.10":
(https://github.com/bitcoin/bitcoin/issues/29311#issuecomment-1909918786)
> May I find it somewhere else?

If a backup exists, you can restore it from there.

> Are there logs?

There is a `debug.log` in the datadir (generally `.bitcoin`) which shows when Bitcoin Core was started, and possibly wallet logs.

💬 vasild commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#discussion_r1466212055)
This could happen:

1. fwrite() succeeds, returns ok the caller, some of the data is buffered in the OS and not yet on disk
2. fclose() is called, it tries to fflush() the buffered data to disk but fails due to IO error. The caller ignores the error returned by fclose()
3. the program continues with the wrong assumption that the data is safely on disk

💬 stickies-v commented on pull request "doc: clarify `BroadcastTransaction` comment":
(https://github.com/bitcoin/bitcoin/pull/29308#discussion_r1466213307)
I don't think we care about which specific RPCs call it? Would just mention that it can be called by RPC, that's the key info - and more maintainable.

```suggestion
// BroadcastTransaction can be called by RPC or by the wallet.
```