💬 willcl-ark commented on issue "RFC: Replacing Boost Process":
(https://github.com/bitcoin/bitcoin/issues/24907#issuecomment-1470373138)
@theStack Just tested on MacOS 13.1 (without BDB and QT) and all functional and unit tests passed ✅

👍 vasild approved a pull request: "p2p: Improve diversification of new connections"
(https://github.com/bitcoin/bitcoin/pull/27264)
ACK 72e8ffd7f8dbf908e65da6d012ede914596737ab

IMO the last commit from #19860 can also be brought up: `doc: peer selection rules do not apply to MANUAL and ADDR_FETCH`

💬 TheCharlatan commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#issuecomment-1470396179)
Code review ACK fadf8b818226dc60adf88e927160f9c9680473a4

💬 achow101 commented on pull request "wallet: Turn `destdata` entries into `CAddressBookData` fields":
(https://github.com/bitcoin/bitcoin/pull/27215#issuecomment-1470407704)
Closing in favor of #27224

✅ achow101 closed a pull request: "wallet: Turn `destdata` entries into `CAddressBookData` fields"
(https://github.com/bitcoin/bitcoin/pull/27215)

💬 achow101 commented on pull request "refactor: Remove CAddressBookData::destdata":
(https://github.com/bitcoin/bitcoin/pull/27224#discussion_r1137453458)
I strongly dislike using the empty string to indicate deletion. I think it would be better to have a separate `RemoveReceiveRequest`.

💬 achow101 commented on pull request "refactor: Remove CAddressBookData::destdata":
(https://github.com/bitcoin/bitcoin/pull/27224#discussion_r1137458690)
I'm not convinced that this needs to be a map. Receive requests are only created by the GUI, and the GUI only creates them for a newly retrieved address, so it shouldn't be possible to have multiple receive requests.

Additionally, receive requests are identified by an int which is being (un)stringified. This could just be an int to avoid that constant conversion in the GUI.

💬 dergoegge commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#discussion_r1137459181)
nit: I think it would be nice if access to this was wrapped in a getter/setter, e.g. `Importing(), {Start,Stop}Importing()`.

My thinking is that we might (in the future) want to mock the `BlockManager` to avoid expensive i/o in the fuzz tests for example. Having a clear interface defined would make that easier. A simple member like this is not a huge blocker for that so feel free to ignore.

💬 willcl-ark commented on issue "Allow groups of accounts to access the RPC cookie file":
(https://github.com/bitcoin/bitcoin/issues/25270#issuecomment-1470420202)
Am I wrong in thinking that there is probably still demand for this, even though #26088 was closed (because #17127 was merged, which does not address this issue), and we have an number of currently-working alternatives:

1. The raspiblitz startupnotify script: `-startupnotify="chmod g+r /home/bitcoin/.bitcoin/.cookie"`
2. With user+password by using `stunnel` to situate the RPC port behind ssl: `stunnel -d 8332 -r 127.0.0.1:8332 -p /path/to/your/certificate.pem -k /path/to/your/key.pem -o /v
...

💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#issuecomment-1470427455)
> I made some changes to this in a branch that could be adopted https://github.com/ryanofsky/bitcoin/commits/review.27217.1-edit

I've adopted these changes.

💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470430978)
@desirepl thanks for clarifying your use case, that makes a lot of sense. I see the appeal of placing a stub bitcoin.conf in the default location that points to other blocks, index, and log directories, as well as to another config file. This lets you specify disk layout separately from network configuration, and makes applications and command line utilities work "magically" as you say without requiring manual arguments.

So I can see how behavior (3) from https://github.com/bitcoin/bitcoin/is
...

💬 pinheadmz commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470439854)
@ryanofsky there is a discrepancy between bitcoind and the GUI though. I think it comes down to this line:

https://github.com/bitcoin/bitcoin/blob/8c4958bd4c06026dc108bc7f5f063d1f389d279b/src/qt/intro.cpp#L259-L265

The comment is well-meaning but I think what ends up happening is that `SoftSetArg()` ends up calling `ForceSetArg()` and that setting takes precedence over the `datadir` setting in the actual conf file.

with bitcoind you CAN:
- put conf file in default location
- that conf
...

💬 achow101 commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1137498953)
They will be re-randomized.

💬 achow101 commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1137504055)
Done

💬 achow101 commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1137504281)
Done

💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#issuecomment-1470477392)
`c2a86ba667...fcd4d34b96`: rebase even though it is not strictly necessary. Now (after https://github.com/bitcoin-core/gui/pull/717 is merged) the GUI does not call `LookupSubNet()`.

Invalidates ACK from @jonatack

💬 mzumsande commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1137526957)
> Hmm? Now on master on mainnet it takes 0.18 microseconds and with this PR on mainnet it will take 6000 microseconds. That is the average case (averaged by the benchmark executing Select about 3500 times). The difference in the worst case is even more pronounced.

We might be using slightly different terminology here: With "worst case", I mean the edge case where we have just one entry in AddrMan of the kind of address that we want. This is the benchmark `AddrManSelectFromAlmostEmpty` for uns
...

💬 achow101 commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1137532345)
I've added a fix, and adopted your test. The fix is simple enough to do here that I think a separate PR is unnecessary.

💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470504330)
> @ryanofsky there is a discrepancy between bitcoind and the GUI though. I think it comes down to this line:

Yes, that's a bug. That's the same line I pointed to above in "Unfortunately the behavior for bitcoin-qt is stupider than bitcoind" https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470284856. It's a simple precedence bug and fix should be straightforward.

> the GUI also has this `QSettings` object which is stored in the system and is parsed before anything else. so if a
...

💬 pinheadmz commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470506278)
👍 PR in progress on this branch: https://github.com/pinheadmz/bitcoin/commits/conf-file