💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463314778)
fixed

💬 Sjors commented on pull request "Make (Read/Write)BinaryFile work with char vector, use AutoFile":
(https://github.com/bitcoin/bitcoin/pull/29229#issuecomment-1906105122)
I opened #29295 for `CKey`.

I no longer need this PR myself, but happy to continue it.

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463315597)
taken

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463315777)
done

💬 instagibbs commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#issuecomment-1906111930)
@murchandamus comments should be addressed or taken

💬 Sjors commented on pull request "CKey: add Unserialize":
(https://github.com/bitcoin/bitcoin/pull/29295#issuecomment-1906152265)
Added `Serialize` for completeness. This only saves me a `MakeUCharSpan(key)`.

💬 fanquake commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906155455)
cc @hebasto

💬 ryanofsky commented on pull request "ci: Rename tasks (previous releases, macOS cross)":
(https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906162604)
Mostly just asking for curiousity, since I guess I can rebase, but in some of my PR's I see:

```sh
./ci/test/00_setup_env.sh: line 33: ./ci/test/00_setup_env_native_qt5.sh: No such file or directory
```

https://cirrus-ci.com/task/5895775641665536
https://cirrus-ci.com/task/5238795365253120

And I'm confused about why this happens. Which cirrus is running, is it mixing and matching the cirrus configuration and scripts from different branches?

💬 furszy commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906176335)
I briefly started working on this in the past but stopped because of the new GUI development.
Depending on the new GUI progress, I could (slowly but steady) start improving this situation.

💬 fanquake commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906178121)
Shoudn't this be closed and marked as a duplicate of one of the existing issues in the GUI repo, and or moved to the GUI repo?

💬 hebasto commented on issue "Mac App UI is freezed most of the time, with no active peers":
(https://github.com/bitcoin/bitcoin/issues/29293#issuecomment-1906194363)
Closing this a the former of reported problems
> App is not responding most of the time, mouse is spinning

is a duplicate of https://github.com/bitcoin-core/gui/issues/299.

And the latter
> there is no stable active peers - there is almost no progress for 2 weeks.

seems better to ask elsewhere, for instance, on https://bitcoin.stackexchange.com/.

✅ hebasto closed an issue: "Mac App UI is freezed most of the time, with no active peers"
(https://github.com/bitcoin/bitcoin/issues/29293)

💬 hebasto commented on issue "GUI unresponsive during IBD":
(https://github.com/bitcoin-core/gui/issues/299#issuecomment-1906195387)
From https://github.com/bitcoin/bitcoin/issues/29293:

> Seems that "connecting to peers" and the beginning of "synchronizing with network" operation block UI thread.

💬 maflcko commented on pull request "ci: Rename tasks (previous releases, macOS cross)":
(https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906227242)
Yes, Cirrus is merging the code changes with the target branch, but not the config changes with the target branch. Thus, the config will have a reference to a file name, which no longer exists in the code.

Ideally this is fixed upstream (there is an issue already open).

However, in the meantime, I think the error can be ignored.

If you want, and there is no review (or reviewers are happy to re-ACK), you can rebase your pull requests on current master.

💬 ryanofsky commented on pull request "wallet: guard against dangling to-be-reverted db transactions":
(https://github.com/bitcoin/bitcoin/pull/29253#issuecomment-1906252904)
I'm trying to understand this, but confused about why executing "ROLLBACK TRANSACTION" would be expected to fail in sqlite. It seems like the fix in e5217fea1516120643f4a7a55a474648e21e2269 is handling failure to roll back by trying to close and reopen the database. But I don't understand why rolling back a transaction would fail to begin with, unless there was some serious error like disk corruption. Probably to make the this fix clearer and safer it would be good to check the specific error co
...

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1463446504)
done

💬 andrewtoth commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1463449628)
Rebased and added a comment to address this.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1463455372)
added

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1463455637)
done

💬 josibake commented on pull request "wallet, rpc: `FundTransaction` refactor":
(https://github.com/bitcoin/bitcoin/pull/28560#issuecomment-1906326392)
> According to my `range-diff` nothing changed. reACK [18ad1b9](https://github.com/bitcoin/bitcoin/commit/18ad1b9142e91cef2f5c6a693eeb2d0fbb8c517d)

for context, this was the reason for the rebase: https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906227242