💬 rebroad commented on pull request "Refine wallet synchronization warning for enhanced clarity":
(https://github.com/bitcoin/bitcoin/pull/27262#issuecomment-1470300845)
Moved to https://github.com/bitcoin-core/gui/pull/720

💬 ryanofsky commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470305275)
> bitcoin_wallet searches wallets on datadir? but for other tools there are walletdir parameter...

This looks like another thing that should be fixed, though in practice right now `bitcoin-wallet` only operates on one wallet at a time, so if you wanted to specify `bitcoin-wallet -walletdir=/path -wallet=mywallet` you could just specify `bitcoin-wallet -wallet=/path/mywallet` instead

The `bitcoin-wallet` code actually would actually already use the `-walletdir` value if it could be passed:
...

📝 pinheadmz opened a pull request: "logging: accept "none" as argument for rpc logging"
(https://github.com/bitcoin/bitcoin/pull/27263)
The help message for rpc `logging` includes:

```
In addition, the following are available as category names with special meanings:
- "all", "1" : represent all logging categories.
- "none", "0" : even if other logging categories are specified, ignore all of them.
```

However "none" is not currently recognized:

```
$ bitcoin/src/bitcoin-cli logging "[\"none\"]"
error code: -8
error message:
unknown logging category none
```

This patch adds the string "none" to match the
...

💬 jonatack commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470312655)
I don't think that brings the missing functionality (see #27231, am updating it to just drop the functionality).

💬 fanquake commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470313674)
See also #27231.

💬 pinheadmz commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470314719)
word! sorry, will track #27231 and review when its ready

✅ pinheadmz closed a pull request: "logging: accept "none" as argument for rpc logging"
(https://github.com/bitcoin/bitcoin/pull/27263)

📝 stratospher opened a pull request: "p2p: Improve diversification of new connections"
(https://github.com/bitcoin/bitcoin/pull/27264)
Revives #19860.

In order to make sure that our persistent outbound slots belong to different netgroups, distinct net groups of our peers are added to [`setConnected`](https://github.com/bitcoin/bitcoin/blob/8c4958bd4c06026dc108bc7f5f063d1f389d279b/src/net.cpp#L1716). We’d only open a persistent outbound connection to peers which have a different netgroup compared to those netgroups present in `setConnected`.

**behaviour on master**

we open persistent outbound connections to peers which
...

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365115)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365304)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367474)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367980)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367822)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137368863)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137369578)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137369716)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137370113)


Thx, can be marked resolved

💬 stratospher commented on pull request "p2p: Improve diversification of new connections":
(https://github.com/bitcoin/bitcoin/pull/19860#issuecomment-1470325525)
revived this in #27264.

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1470327165)
re-ACK b3e78dc91d01e364b77aacd9fb9a2f88688ab8a6 🛁

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK b3e78dc91d01e364b77a
...

💬 achow101 commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1470331104)
ACK dacd3316ca0279c56d12372957633b73a999b5b2