💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1460468278)
makes sense! i've changed `respond_handshake` and `complete_handshake` to return length consumed too.

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1460468407)
yes! i've simplified the comments. hopefully it's better now?

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1460468434)
done.

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1460468510)
done.

> Also, it may be worth moving this right peer2 so inbounds and outbounds are grouped

didn't follow. i've renamed `peer7` to `peer1` since this is first peer in restarted node. is that what you meant?

🤔 murchandamus reviewed a pull request: "wallet: fix coin selection tracing to return -1 when no change pos"
(https://github.com/bitcoin/bitcoin/pull/29272#pullrequestreview-1834683381)
ACK d55fdb1a495190e213b1b5127f5d91e4a409765e

📝 TheeTw23 opened a pull request: "Merge bitcoin/bitcoin#29249: depends: add NM output to gen_id"
(https://github.com/bitcoin/bitcoin/pull/29288)
6ec2813cd88d5f0b955d746e4711a8ad256ea47f depends: add NM output to gen_id (fanquake)

Pull request description:

`NM` is part of the current toolset, and can be set by the user. Include it in `gen_id`.

ACKs for top commit:
TheCharlatan:
Re-ACK 6ec2813cd88d5f0b955d746e4711a8ad256ea47f

Tree-SHA512: 2ada61e03783f9eb441f285ef5da50557ad729cb52ce2d2c4b2c38103dab29920a26262d4545fd2ac7fbf1cedc4902cd2359833544fbc0debf829c12a63e9769

<!--
*** Please remove the following help text before submitti
...

✅ fanquake closed a pull request: "Merge bitcoin/bitcoin#29249: depends: add NM output to gen_id"
(https://github.com/bitcoin/bitcoin/pull/29288)

📝 fanquake locked a pull request: "Merge bitcoin/bitcoin#29249: depends: add NM output to gen_id"
(https://github.com/bitcoin/bitcoin/pull/29288)
6ec2813cd88d5f0b955d746e4711a8ad256ea47f depends: add NM output to gen_id (fanquake)

Pull request description:

`NM` is part of the current toolset, and can be set by the user. Include it in `gen_id`.

ACKs for top commit:
TheCharlatan:
Re-ACK 6ec2813cd88d5f0b955d746e4711a8ad256ea47f

Tree-SHA512: 2ada61e03783f9eb441f285ef5da50557ad729cb52ce2d2c4b2c38103dab29920a26262d4545fd2ac7fbf1cedc4902cd2359833544fbc0debf829c12a63e9769

<!--
*** Please remove the following help text before submitti
...

💬 0xB10C commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#issuecomment-1902355248)
ACK d55fdb1a495190e213b1b5127f5d91e4a409765e

The `int32_t` cast and the tracing related changes look good to me. Thanks for reformatting the tracepoints! I'm not familiar enough with coin selection to comment on these changes.

💬 pablomartin4btc commented on pull request "FIX:When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets' names.":
(https://github.com/bitcoin-core/gui/pull/786#discussion_r1460707827)
CI lint is [failing](https://github.com/bitcoin-core/gui/pull/786/checks?check_run_id=20356215277) due to unnecessary white-spaces in the files (you can run the script `lint-whitespace.py` locally or even [all linters](https://github.com/bitcoin/bitcoin/blob/master/test/lint/README.md#running-locally))
```suggestion
setWindowTitle(tr("Request payments - %1").arg(model->getWalletName()));
```

🤔 pablomartin4btc reviewed a pull request: "FIX:When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets' names."
(https://github.com/bitcoin-core/gui/pull/786#pullrequestreview-1834755623)
Thanks @xonx4l for working on this.

I don't think this PR fixes #259 as, according to its description and what I understand, a fix should be add more clarification (percentage?) about the rescanning of a wallet when they get open in 2 situations:
1. During bitcoin-qt startup, as author of the PR specified, the user could add the wallets manually into the `settings.json` `qt` config file. In this case, perhaps the name of each wallet (if there are many, and may be also x/ total) should be add
...

💬 eragmus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1902509121)
> > to dictate to the economy what it should or should not do
>
> @eragmus your post reads as if you have missed that the [spammer himself](https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1667208040) publicly states that they're running a spam attack. Of course, one can question the effectiveness of the spam mitigation proposed in this PR, but it's pretty absurd trying to argue that this spam would not be an attack even though the attacker is bragging about his attack in interviews
...

💬 BitcoinMechanic commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1902526507)
@eragmus MikeInSpace pontificating in a podcast to the tune of "hey, I helped with the fee market/security budget thing" is not a serious contribution to this discussion.

Visions for future revenue for miners never required invoking a broadening of use cases for bitcoin's blockchain to become a more generic medium for data storage. Such usage of bitcoin has never been considered anything other than harmful and conversations that lead to OP_RETURN (a mechanism to at least mitigate some of the
...

💬 RobinLinus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1902541143)
> "spam" is arbitrarily defined

Right, the attacker says he is [_"polluting the UTXO set [with] toxic waste"_](https://www.youtube.com/watch?v=jJV_-EFZshU&t=286s).

The term _toxic waste_ emphasizes that the problem isn't just temporary but permanent. Important distinction.

💬 eragmus commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1902554616)
> @eragmus MikeInSpace pontificating in a podcast to the tune of "hey, I helped with the fee market/security budget thing" is not a serious contribution to this discussion.

@BitcoinMechanic Hello. There was more context than that. If the argument is to justify a change because this guy admitted to attacking bitcoin, yet that is based on a few cherry-picked horrendous lines out of a 40 minute podcast, that seems pretty silly. The goal should be to understand what he actually thinks.

> Visions f
...

✅ maflcko closed a pull request: "net, refactor: extract Network and BIP155Network logic to node/network"
(https://github.com/bitcoin/bitcoin/pull/27385)

💬 maflcko commented on pull request "net, refactor: extract Network and BIP155Network logic to node/network":
(https://github.com/bitcoin/bitcoin/pull/27385#issuecomment-1902607563)
Closing for now. Feel free to open a new pull, if this is still relevant, or leave a comment here, to have it reopened.

💬 sipa commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#issuecomment-1902638542)
In https://github.com/sipa/bitcoin/commits/pr29242 I pushed another commit which makes `CompareFeerateDiagram` not modify the diagrams in-place.

💬 crediblebytes commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#issuecomment-1902643059)
With all due respect the "rough consensus" thing is shifting from representing the users of bitcoin to who has the most marketing dollars. In software development this means you are no longer building the "[right product](https://www.mojotech.com/blog/building-the-right-product-vs-building-the-product-right/)". The main use case is and always will be sound money. Not "freedom", "cypherpunk system", "database", or a "marketplace". This isn't your latest tech stack to build on. No go to AWS for th
...

🤔 furszy reviewed a pull request: "init: handle empty settings file gracefully"
(https://github.com/bitcoin/bitcoin/pull/29144#pullrequestreview-1835355513)
Rebased to cleanup spurious CI failure.